[CI] Move the macos lint jobs to the lint stage

[amenasria]

What does this PR do?

This PR moves the macos lint jobs to the lint stage

Motivation

Clearer CI.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

.lint_macos_gitlab

  .lint_macos_gitlab:
    before_script:
    - 'eval $(gimme $(cat .go-version))
  
      export GOPATH=$GOROOT
  
      echo "Don''t forget to regularly delete unused versions. Here are the installed
      versions and their memory usage on the runner:"
  
      du -sh $HOME/.gimme/versions/*
  
      '
    - "PYTHON_REPO_VERSION=$(cat .python-version)\nPYTHON_VERSION=$(python3 --version\
      \ | awk '{print $2}' | sed 's/\\.[0-9]*$//')\nif [ \"$PYTHON_REPO_VERSION\" !=\
      \ \"$PYTHON_VERSION\" ]; then\n  echo \"Python version $PYTHON_VERSION is different\
      \ from $PYTHON_REPO_VERSION in .python-version. Cleaning the environment.\"\n\
      \  pyenv uninstall -f datadog-agent\n  echo \"Installing Python $PYTHON_REPO_VERSION...\"\
      \n  pyenv virtualenv 3.11.8 datadog-agent\n  pyenv activate datadog-agent\nelse\n\
      \  echo \"Python current version $PYTHON_VERSION is the same as .python-version.\
      \ Keeping the existing environment.\"\nfi\n"
    - python3 -m pip install -r requirements.txt -r tasks/libs/requirements-github.txt
    - pyenv rehash
    - inv -e rtloader.make --python-runtimes $PYTHON_RUNTIMES
    - inv -e rtloader.install
    needs:
    - go_deps
    - go_tools_deps
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_tools.tar.xz
    - inv -e linter.go --cpus 12 --timeout 60
-   stage: source_test
+   stage: lint
    variables:
      PYTHON_RUNTIMES: '3'

lint_macos_gitlab_amd64

  lint_macos_gitlab_amd64:
    before_script:
    - 'eval $(gimme $(cat .go-version))
  
      export GOPATH=$GOROOT
  
      echo "Don''t forget to regularly delete unused versions. Here are the installed
      versions and their memory usage on the runner:"
  
      du -sh $HOME/.gimme/versions/*
  
      '
    - "PYTHON_REPO_VERSION=$(cat .python-version)\nPYTHON_VERSION=$(python3 --version\
      \ | awk '{print $2}' | sed 's/\\.[0-9]*$//')\nif [ \"$PYTHON_REPO_VERSION\" !=\
      \ \"$PYTHON_VERSION\" ]; then\n  echo \"Python version $PYTHON_VERSION is different\
      \ from $PYTHON_REPO_VERSION in .python-version. Cleaning the environment.\"\n\
      \  pyenv uninstall -f datadog-agent\n  echo \"Installing Python $PYTHON_REPO_VERSION...\"\
      \n  pyenv virtualenv 3.11.8 datadog-agent\n  pyenv activate datadog-agent\nelse\n\
      \  echo \"Python current version $PYTHON_VERSION is the same as .python-version.\
      \ Keeping the existing environment.\"\nfi\n"
    - python3 -m pip install -r requirements.txt -r tasks/libs/requirements-github.txt
    - pyenv rehash
    - inv -e rtloader.make --python-runtimes $PYTHON_RUNTIMES
    - inv -e rtloader.install
    needs:
    - go_deps
    - go_tools_deps
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_tools.tar.xz
    - inv -e linter.go --cpus 12 --timeout 60
-   stage: source_test
+   stage: lint
    tags:
    - macos:monterey-amd64
    - specific:true
    variables:
      PYTHON_RUNTIMES: '3'

lint_macos_gitlab_arm64

  lint_macos_gitlab_arm64:
    allow_failure: true
    before_script:
    - 'eval $(gimme $(cat .go-version))
  
      export GOPATH=$GOROOT
  
      echo "Don''t forget to regularly delete unused versions. Here are the installed
      versions and their memory usage on the runner:"
  
      du -sh $HOME/.gimme/versions/*
  
      '
    - "PYTHON_REPO_VERSION=$(cat .python-version)\nPYTHON_VERSION=$(python3 --version\
      \ | awk '{print $2}' | sed 's/\\.[0-9]*$//')\nif [ \"$PYTHON_REPO_VERSION\" !=\
      \ \"$PYTHON_VERSION\" ]; then\n  echo \"Python version $PYTHON_VERSION is different\
      \ from $PYTHON_REPO_VERSION in .python-version. Cleaning the environment.\"\n\
      \  pyenv uninstall -f datadog-agent\n  echo \"Installing Python $PYTHON_REPO_VERSION...\"\
      \n  pyenv virtualenv 3.11.8 datadog-agent\n  pyenv activate datadog-agent\nelse\n\
      \  echo \"Python current version $PYTHON_VERSION is the same as .python-version.\
      \ Keeping the existing environment.\"\nfi\n"
    - python3 -m pip install -r requirements.txt -r tasks/libs/requirements-github.txt
    - pyenv rehash
    - inv -e rtloader.make --python-runtimes $PYTHON_RUNTIMES
    - inv -e rtloader.install
    needs:
    - go_deps
    - go_tools_deps
    rules:
    - if: $CI_COMMIT_BRANCH == "main"
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_tools.tar.xz
    - inv -e linter.go --cpus 12 --timeout 60
-   stage: source_test
+   stage: lint
    tags:
    - macos:monterey-arm64
    - specific:true
    variables:
      PYTHON_RUNTIMES: '3'

Changes Summary

Removed	Modified	Added	Renamed
0	3	0	0

ℹ️ Diff available in the job log.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 76c9ee0e-68cb-4a13-bd1e-92d791c0a753 Metrics dashboard Target profiles

Baseline: efd16dc
Comparison: 44e129d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otel_to_otel_logs	ingress throughput	+0.51	[-0.29, +1.31]	1	Logs
➖	basic_py_check	% cpu utilization	+0.15	[-2.55, +2.85]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.08	[+0.03, +0.12]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.08, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	idle	memory utilization	-0.01	[-0.07, +0.04]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.05	[-0.78, +0.68]	1	Logs
➖	idle_all_features	memory utilization	-0.71	[-0.80, -0.62]	1	Logs
➖	file_tree	memory utilization	-0.92	[-1.04, -0.81]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-0.93	[-3.38, +1.51]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".