Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add --debug flag to the linter.go invoke tasks to better debug golangci-lint witchcraft #29802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amenasria
Copy link
Member

What does this PR do?

This PR adds a --debug flag to the linter.go invoke task.

Motivation

Better debugging of golangci-lint lint discrepancies due to version mismatches.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@amenasria amenasria added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra labels Oct 4, 2024
@amenasria amenasria requested review from a team as code owners October 4, 2024 14:14
Copy link

Regression Detector

Regression Detector Results

Run ID: b00c16dd-59c3-42a3-9ca3-a124dc373133 Metrics dashboard Target profiles

Baseline: fbe15f7
Comparison: d66c44b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +1.45 [-1.25, +4.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.42 [+1.36, +1.47] 1 Logs
idle_all_features memory utilization +0.26 [+0.17, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.09, +0.06] 1 Logs
idle memory utilization -0.54 [-0.59, -0.49] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.69 [-1.42, +0.03] 1 Logs
otel_to_otel_logs ingress throughput -0.92 [-1.73, -0.12] 1 Logs
file_tree memory utilization -1.23 [-1.34, -1.11] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.87 [-4.34, +0.59] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants