[clusteragent/autoscaling] Fix flaky DCA target test #29816
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennchenn
added
team/containers
qa/no-code-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check that DPA is added to store before continuing to test that the proper error status is set.
Motivation
This test has flaked a few times. The error seems to be caused by the object not being found "in kubernetes". This moves the call to add the object to
f.Objectsearlier, better matching the logic used in theTestLeaderCreateDeleteLocaltest.Describe how to test/QA your changes
Check that test does not flake.
Possible Drawbacks / Trade-offs
Additional Notes
It has been quite difficult to test this change as I am not able to reproduce the same failure locally, so not 100% sure this will fix the flake but probably a change we would want to make anyway.