Skip to content

[ AGNTLOG-210 ] Extend the logs agent to support a cardinality level config for the tagger - #38440

Closed
ddrthall wants to merge 3 commits into
mainfrom
ryan.hall/logger-kube-cardinality
Closed

[ AGNTLOG-210 ] Extend the logs agent to support a cardinality level config for the tagger #38440
ddrthall wants to merge 3 commits into
mainfrom
ryan.hall/logger-kube-cardinality

Conversation

@ddrthall

@ddrthall ddrthall commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Add support for tag cardinality configuration in the Logs Agent to mirror the same functionality present in Dogstatsd. This new configuration option will be named DD_LOGS_TAG_CARDINALITY to mirror the checks/dogstatsd equivalents.

Motivation

Describe how you validated your changes

In addition to automated testing expansion, all three levels ("high", "low", and "orchestrator") were tested in a kubernetes environment to confirm the appropriate set of tags were applied to each log.

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions Bot added medium review PR review might take time team/container-platform The Container Platform Team labels Jul 3, 2025
@ddrthall ddrthall added qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines labels Jul 3, 2025
@ddrthall ddrthall added this to the 7.69.0 milestone Jul 3, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Jul 3, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 823290d7-c4cd-4229-b186-bd23b3f2892e

Baseline: 52c62b6
Comparison: 42c56af
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.99 [-2.12, +4.10] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.88 [+1.52, +4.23] 1 Logs
docker_containers_cpu % cpu utilization +0.99 [-2.12, +4.10] 1 Logs
quality_gate_idle_all_features memory utilization +0.70 [+0.63, +0.77] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.54 [+0.45, +0.63] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.44 [+0.38, +0.50] 1 Logs
docker_containers_memory memory utilization +0.36 [+0.31, +0.42] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.06 [-0.53, +0.64] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.56, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.61, +0.64] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.03, +0.05] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.34, +0.31] 1 Logs
ddot_metrics memory utilization -0.10 [-0.22, +0.01] 1 Logs
otlp_ingest_logs memory utilization -0.11 [-0.24, +0.01] 1 Logs
otlp_ingest_metrics memory utilization -0.13 [-0.27, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.14 [-0.76, +0.48] 1 Logs
file_tree memory utilization -0.16 [-0.20, -0.13] 1 Logs
quality_gate_idle memory utilization -0.48 [-0.53, -0.44] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.17 [-4.93, +0.58] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6150eea

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${703.35}$$ < $${703.45}$$ $${+0.01}$$ $${177.6}$$ < $${178.35}$$
agent_deb_amd64_fips $${+0}$$ $${701.6}$$ < $${701.7}$$ $${+0.03}$$ $${177.01}$$ < $${177.76}$$
agent_heroku_amd64 $${+0.01}$$ $${354.6}$$ < $${355.37}$$ $${-0}$$ $${94.85}$$ < $${95.72}$$
agent_msi $${+0.01}$$ $${977.85}$$ < $${978.18}$$ $${+0.02}$$ $${148.64}$$ < $${149.26}$$
agent_rpm_amd64 $${+0}$$ $${703.34}$$ < $${703.44}$$ $${-0.03}$$ $${179.21}$$ < $${179.87}$$
agent_rpm_amd64_fips $${+0}$$ $${701.59}$$ < $${701.69}$$ $${-0.02}$$ $${178.81}$$ < $${179.47}$$
agent_rpm_arm64 $${+0}$$ $${693.27}$$ < $${693.48}$$ $${+0}$$ $${162.91}$$ < $${163.62}$$
agent_rpm_arm64_fips $${+0}$$ $${691.58}$$ < $${691.79}$$ $${+0.01}$$ $${161.9}$$ < $${162.65}$$
agent_suse_amd64 $${+0}$$ $${703.34}$$ < $${703.44}$$ $${-0.03}$$ $${179.21}$$ < $${179.87}$$
agent_suse_amd64_fips $${+0}$$ $${701.59}$$ < $${701.69}$$ $${-0.02}$$ $${178.81}$$ < $${179.47}$$
agent_suse_arm64 $${+0}$$ $${693.27}$$ < $${693.48}$$ $${+0}$$ $${162.91}$$ < $${163.62}$$
agent_suse_arm64_fips $${+0}$$ $${691.58}$$ < $${691.79}$$ $${+0.01}$$ $${161.9}$$ < $${162.65}$$
docker_agent_amd64 $${+0}$$ $${787.09}$$ < $${787.26}$$ $${-0.01}$$ $${270.86}$$ < $${271.51}$$
docker_agent_arm64 $${+0}$$ $${800.54}$$ < $${800.74}$$ $${+0}$$ $${258.54}$$ < $${259.24}$$
docker_agent_jmx_amd64 $${+0}$$ $${978.34}$$ < $${978.45}$$ $${+0.02}$$ $${339.88}$$ < $${340.47}$$
docker_agent_jmx_arm64 $${+0}$$ $${980.38}$$ < $${980.54}$$ $${-0}$$ $${323.5}$$ < $${324.2}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.89}$$ < $${214.5}$$ $${+0}$$ $${72.71}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${+0}$$ $${229.75}$$ < $${230.33}$$ $${+0.01}$$ $${68.97}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.71}$$ < $${39.57}$$ $${+0}$$ $${14.94}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.42}$$ < $${38.2}$$ $${-0}$$ $${14.38}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.94}$$ < $${31.4}$$ $${-0}$$ $${7.88}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${+0}$$ $${28.55}$$ < $${29.97}$$ $${+0}$$ $${6.84}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.94}$$ < $${31.4}$$ $${-0}$$ $${7.89}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.94}$$ < $${31.4}$$ $${-0}$$ $${7.89}$$ < $${8.96}$$
iot_agent_deb_amd64 $${+0}$$ $${54.04}$$ < $${54.55}$$ $${-0}$$ $${13.62}$$ < $${14.45}$$
iot_agent_deb_arm64 $${+0}$$ $${51.37}$$ < $${51.9}$$ $${-0}$$ $${11.78}$$ < $${12.63}$$
iot_agent_deb_armhf $${+0}$$ $${50.88}$$ < $${51.42}$$ $${-0}$$ $${11.86}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${+0}$$ $${54.04}$$ < $${54.55}$$ $${-0.01}$$ $${13.64}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${+0}$$ $${51.37}$$ < $${51.91}$$ $${-0}$$ $${11.8}$$ < $${12.65}$$
iot_agent_suse_amd64 $${+0}$$ $${54.04}$$ < $${54.55}$$ $${-0.01}$$ $${13.64}$$ < $${14.47}$$

@ddrthall
ddrthall marked this pull request as ready for review July 3, 2025 20:32
@ddrthall
ddrthall requested review from a team as code owners July 3, 2025 20:32
@ddrthall
ddrthall requested a review from rahulkaukuntla July 3, 2025 20:32
Comment thread pkg/config/config_template.yaml Outdated

@rtrieu rtrieu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion but otherwise looks good.

@gabedos gabedos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for a LogCardinality in the tagger looks good to me.

Curious if your team has taken into consideration the CheckTagCardinality option that is attached to checks that are autodiscovered. These checks can emit both metrics and logs. This option also allows different checks to have different levels of cardinality. #29984. Traditionally it's only been relevant to metrics since we didn't have logs supporting a configurable cardinality. Backward compatibility is likely tricky here since the default values for CheckTagCardinality and LogCardinality are different. Just something to keep in mind in the future if we want to provide the same experience for log cardinality configuration as metric cardinality configuration

@ddrthall
ddrthall force-pushed the ryan.hall/logger-kube-cardinality branch from 9aad2af to bfb8931 Compare July 14, 2025 12:21
@ddrthall ddrthall modified the milestones: 7.69.0, 7.70.0 Jul 14, 2025
@ddrthall
ddrthall force-pushed the ryan.hall/logger-kube-cardinality branch from 7636057 to 42c56af Compare July 21, 2025 14:50
@ddrthall ddrthall closed this Jul 21, 2025
@gh-worker-devtools-f43747
gh-worker-devtools-f43747 Bot deleted the ryan.hall/logger-kube-cardinality branch January 20, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines team/container-platform The Container Platform Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants