[ AGNTLOG-310 ] Lock down dynamic symbols exported in the agent binary - #41049
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 474234f ❌ Experiments with missing or malformed dataThis is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.
Optimization Goals: ✅ Improvement(s) detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | % cpu utilization | -21.76 | [-23.02, -20.51] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ✅ | tcp_syslog_to_blackhole | ingress throughput | +11.88 | [+11.81, +11.95] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.24, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.64, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.64, +0.59] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.08 | [-0.69, +0.53] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.09 | [-0.71, +0.53] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.67 | [-0.82, -0.52] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.83 | [-1.02, -0.63] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -1.23 | [-1.35, -1.10] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -1.67 | [-1.73, -1.61] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -1.73 | [-1.89, -1.56] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -2.37 | [-2.41, -2.33] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -2.69 | [-2.76, -2.61] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -2.75 | [-2.82, -2.68] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -2.80 | [-2.87, -2.74] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -2.84 | [-2.88, -2.80] | 1 | Logs |
| ✅ | docker_containers_memory | memory utilization | -5.11 | [-5.60, -4.62] | 1 | Logs |
| ✅ | quality_gate_metrics_logs | memory utilization | -6.83 | [-7.02, -6.64] | 1 | Logs bounds checks dashboard |
| ✅ | quality_gate_logs | % cpu utilization | -10.47 | [-13.08, -7.86] | 1 | Logs bounds checks dashboard |
| ✅ | docker_containers_cpu | % cpu utilization | -21.76 | [-23.02, -20.51] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
24475d3 to
9cc0d2c
Compare
3890c20 to
2edd86d
Compare
|
Can we run a full pipeline, especially all e2e tests, to ensure that nothing is breaking? Thx! :D |
98f2a26 to
a1d970c
Compare
|
View all feedbacks in Devflow UI.
Started pipeline #78863558 |
a1d970c to
5c59cff
Compare
5c59cff to
f623b2e
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
The goal of this PR is to restrict the exported dynamic symbols exported by the agent to only include those necessary for runtime operations. A go dependency (go-nvml) included in some build versions of the agent has triggered an automatic export of all symbols within the binary, which has in turn caused some symbol conflicts/segfaults that needed significant investigation to identify and fix. While the individual error case has been patched, removing unneeded dynamic symbols offers a much more secure mitigation moving forward.
Note that we DO export the nvml symbols as global symbols in this change - this is a tentative choice intended to be reviewed here. All of the existing test setups for the subset of functionality that interacts with nvml report successful runs with symbols exported.
Motivation
Describe how you validated your changes
Ultimately the testing of this change was reliant on the existing suite of automated tests. The binary was hand verified as fully functional for the purposes of the logs agent, but no other system was manually vetted.
Additional Notes