Skip to content

[ AGNTLOG-310 ] Lock down dynamic symbols exported in the agent binary - #41049

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ryan.hall/export-only-required-c-symbols
Oct 30, 2025
Merged

[ AGNTLOG-310 ] Lock down dynamic symbols exported in the agent binary#41049
dd-mergequeue[bot] merged 1 commit into
mainfrom
ryan.hall/export-only-required-c-symbols

Conversation

@ddrthall

@ddrthall ddrthall commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

The goal of this PR is to restrict the exported dynamic symbols exported by the agent to only include those necessary for runtime operations. A go dependency (go-nvml) included in some build versions of the agent has triggered an automatic export of all symbols within the binary, which has in turn caused some symbol conflicts/segfaults that needed significant investigation to identify and fix. While the individual error case has been patched, removing unneeded dynamic symbols offers a much more secure mitigation moving forward.

Note that we DO export the nvml symbols as global symbols in this change - this is a tentative choice intended to be reviewed here. All of the existing test setups for the subset of functionality that interacts with nvml report successful runs with symbols exported.

Motivation

Describe how you validated your changes

Ultimately the testing of this change was reliant on the existing suite of automated tests. The binary was hand verified as fully functional for the purposes of the logs agent, but no other system was manually vetted.

Additional Notes

@github-actions github-actions Bot added short review PR is simple enough to be reviewed quickly team/agent-devx labels Sep 18, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Sep 18, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5c9cbe80-1180-4f32-86b3-21f7094e5e11

Baseline: 474234f
Comparison: f623b2e
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

  • otlp_ingest_metrics (Logs)

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +11.88 [+11.81, +11.95] 1 Logs
docker_containers_memory memory utilization -5.11 [-5.60, -4.62] 1 Logs
quality_gate_metrics_logs memory utilization -6.83 [-7.02, -6.64] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -10.47 [-13.08, -7.86] 1 Logs bounds checks dashboard

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -21.76 [-23.02, -20.51] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +11.88 [+11.81, +11.95] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.24, +0.23] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.64, +0.61] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.64, +0.59] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.08 [-0.69, +0.53] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.09 [-0.71, +0.53] 1 Logs
ddot_metrics_sum_delta memory utilization -0.67 [-0.82, -0.52] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.83 [-1.02, -0.63] 1 Logs
ddot_metrics_sum_cumulative memory utilization -1.23 [-1.35, -1.10] 1 Logs
ddot_logs memory utilization -1.67 [-1.73, -1.61] 1 Logs
ddot_metrics memory utilization -1.73 [-1.89, -1.56] 1 Logs
quality_gate_idle_all_features memory utilization -2.37 [-2.41, -2.33] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -2.69 [-2.76, -2.61] 1 Logs
quality_gate_idle memory utilization -2.75 [-2.82, -2.68] 1 Logs bounds checks dashboard
file_tree memory utilization -2.80 [-2.87, -2.74] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -2.84 [-2.88, -2.80] 1 Logs
docker_containers_memory memory utilization -5.11 [-5.60, -4.62] 1 Logs
quality_gate_metrics_logs memory utilization -6.83 [-7.02, -6.64] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -10.47 [-13.08, -7.86] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -21.76 [-23.02, -20.51] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 474234f

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0.26}$$ $${676.95}$$ < $${702.15}$$ $${-0.09}$$ $${165.17}$$ < $${177.79}$$
agent_deb_amd64_fips $${-0.33}$$ $${671.39}$$ < $${696.65}$$ $${+0.06}$$ $${164.3}$$ < $${176.53}$$
agent_heroku_amd64 $${-0}$$ $${336.54}$$ < $${340.18}$$ $${-0.01}$$ $${89.81}$$ < $${91.08}$$
agent_msi $${0}$$ $${1013.62}$$ < $${1015.38}$$ $${-0.02}$$ $${148.23}$$ < $${150.78}$$
agent_rpm_amd64 $${-0.26}$$ $${676.94}$$ < $${702.14}$$ $${-0.06}$$ $${167.37}$$ < $${180.53}$$
agent_rpm_amd64_fips $${-0.33}$$ $${671.38}$$ < $${696.64}$$ $${-0.07}$$ $${166.06}$$ < $${178.79}$$
agent_rpm_arm64 $${-0.41}$$ $${666.81}$$ < $${686.31}$$ $${-0.08}$$ $${153.34}$$ < $${161.22}$$
agent_rpm_arm64_fips $${-0.61}$$ $${662.13}$$ < $${681.84}$$ $${-0.12}$$ $${152.44}$$ < $${160.18}$$
agent_suse_amd64 $${-0.26}$$ $${676.94}$$ < $${702.14}$$ $${-0.06}$$ $${167.37}$$ < $${180.53}$$
agent_suse_amd64_fips $${-0.33}$$ $${671.38}$$ < $${696.64}$$ $${-0.07}$$ $${166.06}$$ < $${178.79}$$
agent_suse_arm64 $${-0.41}$$ $${666.81}$$ < $${686.31}$$ $${-0.08}$$ $${153.34}$$ < $${161.22}$$
agent_suse_arm64_fips $${-0.61}$$ $${662.13}$$ < $${681.84}$$ $${-0.12}$$ $${152.44}$$ < $${160.18}$$
docker_agent_amd64 $${-0.26}$$ $${747.51}$$ < $${773.59}$$ $${-0.08}$$ $${252.03}$$ < $${266.06}$$
docker_agent_arm64 $${-0.41}$$ $${761.31}$$ < $${781.7}$$ $${-0.14}$$ $${242.56}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${-0.26}$$ $${938.37}$$ < $${964.45}$$ $${-0.08}$$ $${320.66}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0.41}$$ $${940.78}$$ < $${961.17}$$ $${-0.17}$$ $${307.16}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.72}$$ < $${213.74}$$ $${-0}$$ $${72.52}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${229.61}$$ < $${229.68}$$ $${-0}$$ $${68.77}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.45}$$ < $${39.3}$$ $${+0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.12}$$ < $${37.94}$$ $${-0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${+0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${-0.07}$$ $${28.19}$$ < $${29.11}$$ $${-0.02}$$ $${6.75}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${+0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${+0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${+0}$$ $${42.34}$$ < $${54.97}$$ $${-0}$$ $${11.05}$$ < $${14.45}$$
iot_agent_deb_arm64 $${-0.06}$$ $${40.07}$$ < $${51.9}$$ $${-0.01}$$ $${9.52}$$ < $${12.63}$$
iot_agent_deb_armhf $${-0.04}$$ $${40.0}$$ < $${51.84}$$ $${-0.01}$$ $${9.63}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${+0}$$ $${42.34}$$ < $${54.97}$$ $${-0}$$ $${11.07}$$ < $${14.47}$$
iot_agent_suse_amd64 $${+0}$$ $${42.34}$$ < $${54.97}$$ $${-0}$$ $${11.07}$$ < $${14.47}$$

@ddrthall
ddrthall force-pushed the ryan.hall/export-only-required-c-symbols branch 3 times, most recently from 24475d3 to 9cc0d2c Compare September 19, 2025 14:35
@ddrthall ddrthall changed the title WIP [ AGNTLOG-310 ] Lock down dynamic symbols exported in the agent binary Sep 19, 2025
@ddrthall
ddrthall force-pushed the ryan.hall/export-only-required-c-symbols branch 2 times, most recently from 3890c20 to 2edd86d Compare October 2, 2025 19:43
@ddrthall ddrthall added the qa/done QA done before merge and regressions are covered by tests label Oct 3, 2025
@ddrthall
ddrthall marked this pull request as ready for review October 3, 2025 14:17
@ddrthall
ddrthall requested review from a team as code owners October 3, 2025 14:17
@ddrthall
ddrthall requested a review from a team October 3, 2025 14:23
@iadjivon iadjivon self-assigned this Oct 3, 2025
@gjulianm

gjulianm commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Can we run a full pipeline, especially all e2e tests, to ensure that nothing is breaking? Thx! :D

@ddrthall
ddrthall force-pushed the ryan.hall/export-only-required-c-symbols branch 3 times, most recently from 98f2a26 to a1d970c Compare October 8, 2025 13:38
@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 9, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-09 15:30:01 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-10-09 15:30:59 UTC ℹ️ Gitlab pipeline started

Started pipeline #78863558

@ddrthall
ddrthall force-pushed the ryan.hall/export-only-required-c-symbols branch from a1d970c to 5c59cff Compare October 15, 2025 21:17
@ddrthall
ddrthall force-pushed the ryan.hall/export-only-required-c-symbols branch from 5c59cff to f623b2e Compare October 27, 2025 20:20
@ddrthall

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 30, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-30 13:14:14 UTC ℹ️ Start processing command /merge


2025-10-30 13:14:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 37m (p90).


2025-10-30 13:39:02 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 93ac62c into main Oct 30, 2025
602 of 604 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ryan.hall/export-only-required-c-symbols branch October 30, 2025 13:39
@github-actions github-actions Bot added this to the 7.73.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-devx team/agent-log-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants