Skip to content

Prevent corrupted digest value being adopted by gradual rollout - #41099

Merged
dd-mergequeue[bot] merged 11 commits into
mainfrom
tony/digest-validation
Oct 22, 2025
Merged

Prevent corrupted digest value being adopted by gradual rollout#41099
dd-mergequeue[bot] merged 11 commits into
mainfrom
tony/digest-validation

Conversation

@TonyCTHsu

@TonyCTHsu TonyCTHsu commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Prevent corrupted digest being adopted by gradual rollout

Motivation

There is a risk for receiving a corrupted digest would end up failing in customer environment during image pull.

Describe how you validated your changes

Work as usual.

Additional Notes

@github-actions github-actions Bot added team/container-platform The Container Platform Team medium review PR review might take time team/injection-platform labels Sep 19, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Sep 19, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 81d7d221-4d61-4fa1-a675-72a21a51457c

Baseline: e7a55b6
Comparison: 32d9bfa
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization +8.63 [+8.20, +9.05] 1 Logs

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +27.83 [+26.23, +29.44] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +27.83 [+26.23, +29.44] 1 Logs
docker_containers_memory memory utilization +8.63 [+8.20, +9.05] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.80 [+1.73, +1.88] 1 Logs
quality_gate_metrics_logs memory utilization +1.11 [+0.90, +1.32] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.79 [+0.62, +0.96] 1 Logs
quality_gate_idle_all_features memory utilization +0.28 [+0.24, +0.32] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.12 [-0.01, +0.25] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.07, +0.16] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.09 [+0.04, +0.13] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.08 [-0.12, +0.28] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.59, +0.61] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.18, +0.20] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.61, +0.59] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.63, +0.58] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.64, +0.57] 1 Logs
file_tree memory utilization -0.08 [-0.14, -0.02] 1 Logs
ddot_logs memory utilization -0.31 [-0.37, -0.24] 1 Logs
ddot_metrics_sum_delta memory utilization -0.32 [-0.47, -0.17] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.45 [-0.58, -0.33] 1 Logs
otlp_ingest_metrics memory utilization -0.63 [-0.75, -0.51] 1 Logs
quality_gate_logs % cpu utilization -1.04 [-3.78, +1.71] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 9/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor e7a55b6

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${676.18}$$ < $${702.15}$$ $${-0}$$ $${165.13}$$ < $${177.79}$$
agent_deb_amd64_fips $${0}$$ $${670.69}$$ < $${696.65}$$ $${+0.02}$$ $${164.67}$$ < $${176.53}$$
agent_heroku_amd64 $${0}$$ $${336.47}$$ < $${340.18}$$ $${-0.01}$$ $${89.8}$$ < $${91.08}$$
agent_msi $${0}$$ $${1013.73}$$ < $${1015.38}$$ $${-0.02}$$ $${148.41}$$ < $${150.78}$$
agent_rpm_amd64 $${0}$$ $${676.17}$$ < $${702.14}$$ $${+0.04}$$ $${167.41}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${670.68}$$ < $${696.64}$$ $${+0.01}$$ $${166.01}$$ < $${178.79}$$
agent_rpm_arm64 $${0}$$ $${666.01}$$ < $${686.31}$$ $${-0.01}$$ $${153.27}$$ < $${161.22}$$
agent_rpm_arm64_fips $${0}$$ $${661.54}$$ < $${681.84}$$ $${+0.02}$$ $${152.65}$$ < $${160.18}$$
agent_suse_amd64 $${0}$$ $${676.17}$$ < $${702.14}$$ $${+0.04}$$ $${167.41}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${670.68}$$ < $${696.64}$$ $${+0.01}$$ $${166.01}$$ < $${178.79}$$
agent_suse_arm64 $${0}$$ $${666.01}$$ < $${686.31}$$ $${-0.01}$$ $${153.27}$$ < $${161.22}$$
agent_suse_arm64_fips $${0}$$ $${661.54}$$ < $${681.84}$$ $${+0.02}$$ $${152.65}$$ < $${160.18}$$
docker_agent_amd64 $${0}$$ $${746.73}$$ < $${773.59}$$ $${-0.01}$$ $${251.79}$$ < $${266.06}$$
docker_agent_arm64 $${+0}$$ $${760.51}$$ < $${781.7}$$ $${+0}$$ $${242.42}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${0}$$ $${937.6}$$ < $${964.45}$$ $${-0}$$ $${320.43}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${939.98}$$ < $${961.17}$$ $${-0}$$ $${307.02}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.05}$$ < $${213.74}$$ $${-0.01}$$ $${72.27}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${228.99}$$ < $${229.68}$$ $${-0.01}$$ $${68.53}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.45}$$ < $${39.3}$$ $${-0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.12}$$ < $${37.94}$$ $${+0}$$ $${14.29}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.25}$$ < $${29.11}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.67}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${41.93}$$ < $${54.97}$$ $${+0}$$ $${10.91}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${39.75}$$ < $${51.9}$$ $${-0}$$ $${9.42}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${39.62}$$ < $${51.84}$$ $${-0}$$ $${9.5}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${41.93}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${41.93}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$

@TonyCTHsu
TonyCTHsu force-pushed the tony/digest-validation branch from a3a7750 to bb72e50 Compare October 10, 2025 12:40
@TonyCTHsu
TonyCTHsu marked this pull request as ready for review October 10, 2025 13:07
@TonyCTHsu
TonyCTHsu requested review from a team as code owners October 10, 2025 13:07
@TonyCTHsu
TonyCTHsu force-pushed the tony/digest-validation branch from bb72e50 to 54cdc52 Compare October 15, 2025 12:57

@erikayasuda erikayasuda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the call out to keep the CanonicalVersion field LGTM

@erikayasuda

Copy link
Copy Markdown
Contributor

@TonyCTHsu Just a call out that this will go out in the 7.73 release line unless we backport.

@TonyCTHsu TonyCTHsu added the changelog/no-changelog No changelog entry needed label Oct 16, 2025

@stanistan stanistan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TonyCTHsu TonyCTHsu added the qa/done QA done before merge and regressions are covered by tests label Oct 22, 2025
@TonyCTHsu

TonyCTHsu commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 22, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-22 11:00:19 UTC ℹ️ Start processing command /mergequeue


2025-10-22 11:00:20 UTC ℹ️ Help: mergequeue

Admin command - Actions about mergequeue

Available actions:

  • flush: Flush the mergequeue

@TonyCTHsu

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 22, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-22 11:03:07 UTC ℹ️ Start processing command /merge


2025-10-22 11:03:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 39m (p90).


2025-10-22 11:16:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 4ee6640 into main Oct 22, 2025
275 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the tony/digest-validation branch October 22, 2025 11:16
@github-actions github-actions Bot added this to the 7.73.0 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team team/injection-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants