Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
189 changes: 189 additions & 0 deletions pkg/opentelemetry-mapping-go/otlp/metrics/histograms.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,189 @@
// Unless explicitly stated otherwise all files in this repository are licensed
// under the Apache License Version 2.0.
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2022-present Datadog, Inc.

package metrics

import (
"fmt"
"math"
"time"

"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/pmetric"

"github.com/DataDog/sketches-go/ddsketch"
"github.com/DataDog/sketches-go/ddsketch/mapping"
"github.com/DataDog/sketches-go/ddsketch/store"
)

// getTimeUnitScaleToNanos returns the scaling factor to convert the given unit to nanoseconds
func getTimeUnitScaleToNanos(unit string) float64 {
switch unit {
case "ns":
return float64(time.Nanosecond)
case "us", "μs":
return float64(time.Microsecond)
case "ms":
return float64(time.Millisecond)
case "s":
return float64(time.Second)
case "min":
return float64(time.Minute)
case "h":
return float64(time.Hour)
default:
// If unit is unknown, assume seconds (common for duration metrics)
return float64(time.Second)
}
}

// getBounds returns the lower and upper bounds for a histogram bucket
func getBounds(explicitBounds pcommon.Float64Slice, idx int) (lowerBound float64, upperBound float64) {
// See https://github.com/open-telemetry/opentelemetry-proto/blob/v0.10.0/opentelemetry/proto/metrics/v1/metrics.proto#L427-L439
lowerBound = math.Inf(-1)
upperBound = math.Inf(1)
if idx > 0 {
lowerBound = explicitBounds.At(idx - 1)
}
if idx < explicitBounds.Len() {
upperBound = explicitBounds.At(idx)
}
return
}

// CreateDDSketchFromHistogramOfDuration creates a DDSketch from regular histogram data point
func CreateDDSketchFromHistogramOfDuration(dp pmetric.HistogramDataPoint, unit string) (*ddsketch.DDSketch, error) {
relativeAccuracy := 0.01 // 1% relative accuracy
maxNumBins := 2048
newSketch, err := ddsketch.LogCollapsingLowestDenseDDSketch(relativeAccuracy, maxNumBins)
if err != nil {
return nil, err
}

bucketCounts := dp.BucketCounts()
explicitBounds := dp.ExplicitBounds()

// Get scaling factor to convert unit to nanoseconds
scaleToNanos := getTimeUnitScaleToNanos(unit)

// Find first and last bucket indices with count > 0
lowestBucketIndex := -1
highestBucketIndex := -1
for j := 0; j < bucketCounts.Len(); j++ {
count := bucketCounts.At(j)
if count > 0 {
if lowestBucketIndex == -1 {
lowestBucketIndex = j
}
highestBucketIndex = j
}
}

hasMin := dp.HasMin()
hasMax := dp.HasMax()
minNanoseconds := dp.Min() * scaleToNanos
maxNanoseconds := dp.Max() * scaleToNanos

for j := 0; j < bucketCounts.Len(); j++ {
lowerBound, upperBound := getBounds(explicitBounds, j)

if math.IsInf(upperBound, 1) {
upperBound = lowerBound
} else if math.IsInf(lowerBound, -1) {
lowerBound = upperBound
}

count := bucketCounts.At(j)

if count > 0 {
insertionPoint := 0.0
adjustedCount := float64(count)
midpoint := (lowerBound + upperBound) / 2 * scaleToNanos
// Determine insertion point based on bucket position
if j == lowestBucketIndex && j == highestBucketIndex {
// Special case: min and max are in the same bucket
if hasMin && hasMax {
insertionPoint = (minNanoseconds + maxNanoseconds) / 2
}
} else if j == lowestBucketIndex {
// Bottom bucket: insert at min value
if hasMin {
insertionPoint = minNanoseconds
}
} else if j == highestBucketIndex {
// Top bucket: insert at max value
if hasMax {
insertionPoint = maxNanoseconds
}
}

if insertionPoint == 0.0 {
insertionPoint = midpoint
}

err := newSketch.AddWithCount(insertionPoint, adjustedCount)
if err != nil {
return nil, fmt.Errorf("failed to add value to DDSketch: %w", err)
}
}
}

return newSketch, nil
}

func toStoreFromExponentialBucketsWithUnitScale(b pmetric.ExponentialHistogramDataPointBuckets, mapping *mapping.LogarithmicMapping, base float64, scaleToNanos float64) store.Store {
offset := b.Offset()
bucketCounts := b.BucketCounts()

store := store.NewDenseStore()
for j := 0; j < bucketCounts.Len(); j++ {
bucketIndex := j + int(offset)
count := bucketCounts.At(j)

if count > 0 {
// Calculate the actual bucket boundary value
bucketValue := math.Pow(base, float64(bucketIndex))

// Scale the bucket value to nanoseconds
scaledValue := bucketValue * scaleToNanos

// Convert back to the index in the nanosecond space
// Using the same gamma since we're keeping the same precision
scaledIndex := mapping.Index(scaledValue)
store.AddWithCount(scaledIndex, float64(count))
}
}
return store
}

// CreateDDSketchFromExponentialHistogramOfDuration creates a DDSketch from exponential histogram data point
func CreateDDSketchFromExponentialHistogramOfDuration(p pmetric.ExponentialHistogramDataPoint, unit string) (*ddsketch.DDSketch, error) {
// Create the DDSketch stores
scaleToNanos := getTimeUnitScaleToNanos(unit)

// Create the DDSketch mapping that corresponds to the ExponentialHistogram settings
gammaWithOnePercentAccuracy := 1.01 / 0.99
gamma := math.Pow(2, math.Pow(2, float64(-p.Scale())))
gamma = math.Min(gamma, gammaWithOnePercentAccuracy)
indexOffset := math.Log(scaleToNanos)
mapping, err := mapping.NewLogarithmicMappingWithGamma(gamma, indexOffset)
if err != nil {
return nil, fmt.Errorf("couldn't create LogarithmicMapping for DDSketch: %w", err)
}

// Calculate the base for the exponential histogram
base := math.Pow(2, math.Pow(2, float64(-p.Scale())))
positiveStore := toStoreFromExponentialBucketsWithUnitScale(p.Positive(), mapping, base, scaleToNanos)
negativeStore := toStoreFromExponentialBucketsWithUnitScale(p.Negative(), mapping, base, scaleToNanos)

// Create DDSketch with the above mapping and stores
sketch := ddsketch.NewDDSketch(mapping, positiveStore, negativeStore)
err = sketch.AddWithCount(0, float64(p.ZeroCount()))
if err != nil {
return nil, fmt.Errorf("failed to add ZeroCount to DDSketch: %w", err)
}

return sketch, nil
}
Loading