Skip to content

Fix otel config with nodetreemodel implementation #42031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 1 commit into from
Oct 21, 2025
Merged

Fix otel config with nodetreemodel implementation #42031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions comp/otelcol/otlp/components/exporter/serializerexporter/serializer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ func InitSerializer(logger *zap.Logger, cfg *ExporterConfig, sourceProvider sour
fxutil.FxAgentBase(),
fx.Provide(func() config.Component {
pkgconfig := create.NewConfig("DD")
pkgconfigsetup.InitConfig(pkgconfig)
pkgconfig.BuildSchema()
Comment on lines +125 to +126

@songy23 songy23 Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to be called multiple times and/or when there is no actual config?

@hush-hush hush-hush Oct 20, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildSchema don't load the config but build internal schema structure used later for validation. It's based on all the BindEnvAndSetDefault calls that register all our settings.

And yes it's safe to call multiple times.


// Set the API Key
pkgconfig.Set("api_key", string(cfg.API.Key), pkgconfigmodel.SourceFile)
Expand Down