Skip to content

Make bazel job blocking again on Windows - #42131

Merged
rdesgroppes merged 1 commit into
mainfrom
regis.desgroppes/make-bazel-job-blocking-again-on-windows
Oct 21, 2025
Merged

Make bazel job blocking again on Windows#42131
rdesgroppes merged 1 commit into
mainfrom
regis.desgroppes/make-bazel-job-blocking-again-on-windows

Conversation

@rdesgroppes

@rdesgroppes rdesgroppes commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

As #incident-42947 is now marked as stable, this change aims at bringing back (see #41023) a bazel build job to a gating criteria so that regressions when building dependencies on Windows can't go unnoticed.

The change also removes an unwanted #< CLIXML header in the job output, see PowerShell/PowerShell#16678.

@rdesgroppes
rdesgroppes requested a review from a team as a code owner October 20, 2025 08:21
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Oct 20, 2025
@rdesgroppes rdesgroppes added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog No changelog entry needed ask-review Ask in slack required teams to review this PR and removed short review PR is simple enough to be reviewed quickly labels Oct 20, 2025
@rdesgroppes
rdesgroppes force-pushed the regis.desgroppes/make-bazel-job-blocking-again-on-windows branch from d925f24 to 3d98d1c Compare October 20, 2025 09:49
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Oct 20, 2025
@cit-pr-commenter

cit-pr-commenter Bot commented Oct 20, 2025

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 75b39eca-5872-45bd-928f-e15d75f7dc72

Baseline: f0e96fd
Comparison: 07bbbb8
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -32.05 [-33.37, -30.74] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +2.24 [+2.03, +2.45] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +1.75 [-1.02, +4.52] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.70 [+0.63, +0.77] 1 Logs
ddot_metrics_sum_delta memory utilization +0.59 [+0.43, +0.76] 1 Logs
otlp_ingest_logs memory utilization +0.45 [+0.32, +0.58] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.19 [+0.06, +0.31] 1 Logs
otlp_ingest_metrics memory utilization +0.13 [+0.01, +0.25] 1 Logs
quality_gate_idle memory utilization +0.11 [+0.07, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.07 [-0.53, +0.68] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.59, +0.62] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.23, +0.23] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.65, +0.57] 1 Logs
ddot_logs memory utilization -0.08 [-0.15, -0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.12 [-0.73, +0.50] 1 Logs
file_tree memory utilization -0.18 [-0.23, -0.13] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.26 [-0.45, -0.07] 1 Logs
quality_gate_idle_all_features memory utilization -0.37 [-0.41, -0.33] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.46 [-0.62, -0.31] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.48 [-0.52, -0.44] 1 Logs
docker_containers_memory memory utilization -3.30 [-3.64, -2.96] 1 Logs
docker_containers_cpu % cpu utilization -32.05 [-33.37, -30.74] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr

agent-platform-auto-pr Bot commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f0e96fd

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${675.79}$$ < $${702.15}$$ $${+0}$$ $${165.23}$$ < $${177.79}$$
agent_deb_amd64_fips $${0}$$ $${670.3}$$ < $${696.65}$$ $${+0}$$ $${164.81}$$ < $${176.53}$$
agent_heroku_amd64 $${0}$$ $${336.62}$$ < $${340.18}$$ $${+0.01}$$ $${89.84}$$ < $${91.08}$$
agent_msi $${0}$$ $${1013.76}$$ < $${1015.38}$$ $${+0.05}$$ $${148.45}$$ < $${150.78}$$
agent_rpm_amd64 $${0}$$ $${675.78}$$ < $${702.14}$$ $${-0.01}$$ $${167.41}$$ < $${180.53}$$
agent_rpm_amd64_fips $${0}$$ $${670.29}$$ < $${696.64}$$ $${-0.01}$$ $${166.13}$$ < $${178.79}$$
agent_rpm_arm64 $${0}$$ $${665.38}$$ < $${686.31}$$ $${+0.02}$$ $${153.43}$$ < $${161.22}$$
agent_rpm_arm64_fips $${0}$$ $${660.9}$$ < $${681.84}$$ $${-0.03}$$ $${153.05}$$ < $${160.18}$$
agent_suse_amd64 $${0}$$ $${675.78}$$ < $${702.14}$$ $${-0.01}$$ $${167.41}$$ < $${180.53}$$
agent_suse_amd64_fips $${0}$$ $${670.29}$$ < $${696.64}$$ $${-0.01}$$ $${166.13}$$ < $${178.79}$$
agent_suse_arm64 $${0}$$ $${665.38}$$ < $${686.31}$$ $${+0.02}$$ $${153.43}$$ < $${161.22}$$
agent_suse_arm64_fips $${0}$$ $${660.9}$$ < $${681.84}$$ $${-0.03}$$ $${153.05}$$ < $${160.18}$$
docker_agent_amd64 $${-0}$$ $${746.35}$$ < $${773.59}$$ $${-0}$$ $${251.85}$$ < $${266.06}$$
docker_agent_arm64 $${+0}$$ $${759.88}$$ < $${781.7}$$ $${-0}$$ $${242.46}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${-0}$$ $${937.22}$$ < $${964.45}$$ $${+0}$$ $${320.5}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${939.35}$$ < $${961.17}$$ $${+0}$$ $${307.08}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${+0}$$ $${213.01}$$ < $${213.74}$$ $${+0}$$ $${72.26}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${0}$$ $${228.92}$$ < $${229.68}$$ $${+0}$$ $${68.53}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.44}$$ < $${39.3}$$ $${-0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.12}$$ < $${37.94}$$ $${+0}$$ $${14.28}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.25}$$ < $${29.11}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${-0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${41.91}$$ < $${54.97}$$ $${+0}$$ $${10.9}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${39.73}$$ < $${51.9}$$ $${-0}$$ $${9.41}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${39.6}$$ < $${51.84}$$ $${-0}$$ $${9.5}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${41.92}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$
iot_agent_suse_amd64 $${0}$$ $${41.92}$$ < $${54.97}$$ $${+0}$$ $${10.92}$$ < $${14.47}$$

@rdesgroppes
rdesgroppes force-pushed the regis.desgroppes/make-bazel-job-blocking-again-on-windows branch 5 times, most recently from 615d55a to 0345844 Compare October 20, 2025 23:39
As #incident-42947 is now marked as stable, this change aims at bringing
back (see #41023) a `bazel` build job to a gating criteria so that
regressions when building dependencies on Windows can't go unnoticed.

The change also removes an unwanted `#< CLIXML` header in the job
output, see: PowerShell/PowerShell#16678
@rdesgroppes
rdesgroppes force-pushed the regis.desgroppes/make-bazel-job-blocking-again-on-windows branch from 0345844 to 07bbbb8 Compare October 20, 2025 23:46
@rdesgroppes
rdesgroppes merged commit a6e334c into main Oct 21, 2025
312 checks passed
@rdesgroppes
rdesgroppes deleted the regis.desgroppes/make-bazel-job-blocking-again-on-windows branch October 21, 2025 07:22
@github-actions github-actions Bot added this to the 7.73.0 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask in slack required teams to review this PR changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants