Update MSI OCI install -> installer setup script by jack0x2 · Pull Request #42159 · DataDog/datadog-agent

jack0x2 · 2025-10-20T19:09:45Z

What does this PR do?

Update the MSI OCI install logic to use the installer setup script to install the OCI packages. This allows one common workflow between installer setup workflow and MSI workflow. Adds in a purge command to purge the OCI packages, similar to the OCI install.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1934
https://datadoghq.atlassian.net/browse/WINA-1912
https://datadoghq.atlassian.net/browse/WINA-1835

Describe how you validated your changes

Existing e2e tests cover making sure OCI packages are installed through setup command.
Adds e2e test to test that purge removes .NET tracing library.

Additional Notes

Right now during uninstall we ignore the results of the purge command. Should we fail uninstall if we fail to purge?

Future PR will, fix rollback logic to better handle upgrade workflows for DDOT.

Set purge to be the default option on uninstall

agent-platform-auto-pr · 2025-10-20T19:13:16Z

Gitlab CI Configuration Changes

Modified Jobs

new-e2e-installer-windows

  new-e2e-installer-windows:
    after_script:
    - CODECOV_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $CODECOV token) || exit
      $?; export CODECOV_TOKEN
    - $CI_PROJECT_DIR/tools/ci/junit_upload.sh "junit-${CI_JOB_ID}.tgz" "$E2E_RESULT_JSON"
    - "if [ -d \"$E2E_COVERAGE_OUT_DIR\" ]; then\n  dda inv -- -e coverage.process-e2e-coverage-folders\
      \ $E2E_COVERAGE_OUT_DIR\n  pip install boto3==1.38.8 # TODO: Remove this before\
      \ merging, after dda is bumped in test-infra-definitions\n  dda inv -- -e dyntest.compute-and-upload-job-index\
      \ --bucket-uri $S3_PERMANENT_ARTIFACTS_URI --coverage-folder $E2E_COVERAGE_OUT_DIR\
      \ --commit-sha $CI_COMMIT_SHA --job-id $CI_JOB_ID\nfi\n"
    artifacts:
      expire_in: 2 weeks
      paths:
      - $E2E_OUTPUT_DIR
      - $E2E_RESULT_JSON
      - junit-*.tgz
      - $E2E_COVERAGE_OUT_DIR
      reports:
        annotations:
        - $EXTERNAL_LINKS_PATH
      when: always
    before_script:
    - CURRENT_AGENT_VERSION=$(dda inv agent.version) || exit $?; export CURRENT_AGENT_VERSION
    - CURRENT_AGENT_VERSION_PACKAGE=$(dda inv agent.version --url-safe)-1 || exit $?;
      export CURRENT_AGENT_VERSION_PACKAGE
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
      || exit 101
    - rm -f modcache_e2e.tar.xz
    - mkdir -p ~/.aws
    - "if [ -n \"$E2E_USE_AWS_PROFILE\" ]; then\n  echo Using agent-qa-ci aws profile\n\
      \  $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config\
      \ || exit $?\n  # Now all `aws` commands target the agent-qa profile\n  export\
      \ AWS_PROFILE=agent-qa-ci\nelse\n  # Assume role to fetch only once credentials\
      \ and avoid rate limits\n  echo Assuming ddbuild-agent-ci role\n  roleoutput=\"\
      $(aws sts assume-role --role-arn arn:aws:iam::669783387624:role/ddbuild-agent-ci\
      \ --external-id ddbuild-agent-ci --role-session-name RoleSession)\"\n  export\
      \ AWS_ACCESS_KEY_ID=\"$(echo \"$roleoutput\" | jq -r '.Credentials.AccessKeyId')\"\
      \n  export AWS_SECRET_ACCESS_KEY=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SecretAccessKey')\"\
      \n  export AWS_SESSION_TOKEN=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SessionToken')\"\
      \nfi\n"
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
      $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
    - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
    - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
      || exit $?; export ARM_CLIENT_ID
    - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
      || exit $?; export ARM_CLIENT_SECRET
    - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
      || exit $?; export ARM_TENANT_ID
    - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
      || exit $?; export ARM_SUBSCRIPTION_ID
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
      || exit $?
    - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
    - dda inv -- -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
    - export DD_ENV=nativetest
    - export DD_CIVISIBILITY_ENABLED=true
    - export DD_CIVISIBILITY_AGENTLESS_ENABLED=true
    - DD_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_API_KEY_ORG2 token)
      || exit $?; export DD_API_KEY
    - export WINDOWS_DDNPM_DRIVER=${WINDOWS_DDNPM_DRIVER:-$(dda inv release.get-release-json-value
      "dependencies::WINDOWS_DDNPM_DRIVER" --no-worktree)}
    - export WINDOWS_DDPROCMON_DRIVER=${WINDOWS_DDPROCMON_DRIVER:-$(dda inv release.get-release-json-value
      "dependencies::WINDOWS_DDPROCMON_DRIVER" --no-worktree)}
    image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
    needs:
    - go_e2e_deps
    - go_e2e_test_binaries
    - job: new-e2e-base-coverage
      optional: true
    - deploy_windows_testing-a7
    - deploy_installer_oci
    - deploy_agent_oci
    - qa_installer_script_windows
    - deploy_ddot_oci
    parallel:
      matrix:
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackageWithAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeAgentPackageAfterRollback$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestDowngradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestStopExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentForNonExistingPackageFails$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentCurrentVersionFails$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestStopWithoutExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenServiceDies$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenTimeout$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestExperimentMSIRollbackMaintainsCustomUserAndAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRevertsExperimentWhenServiceDiesMaintainsCustomUserAndAltDir$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeWithHostNameChange$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestRunAgentMSIAfterExperiment$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestUpgradeWithAgentUser$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$/TestDowngradeWithMissingInstallSource$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDC$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDC$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesAfterDCPromotion$/TestUpgradeAfterDCPromotion$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDCWithGMSA$/TestUpgradeMSI$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesOnDCWithGMSA$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesFromGA$/TestUpgradeAgentPackage$"
      - EXTRA_PARAMS: --run "TestAgentUpgradesFromGA$/TestUpgradeAgentPackageAfterRollback$"
      - EXTRA_PARAMS: --run "TestAgentInstalls$/TestSetupScriptInstallInfo$"
      - EXTRA_PARAMS: --run "TestUpgradeWithMissingPassword$/TestUpgradeWithMissingPassword$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeSuccessful$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeFailure$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestConfigUpgradeNewAgents$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestRevertsConfigExperimentWhenServiceDies$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestRevertsConfigExperimentWhenTimeout$"
      - EXTRA_PARAMS: --run "TestAgentConfig$/TestManagedConfigActiveAfterUpgrade$"
      - EXTRA_PARAMS: --run "TestInstallExe$/TestInstallAgentPackage$"
      - EXTRA_PARAMS: --run "TestInstallExeWithProxy$/TestInstallAgentPackageWithProxy$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallAgentPackage$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallFromOldInstaller$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallIgnoreMajorMinor$"
      - EXTRA_PARAMS: --run "TestInstallScript$/TestInstallCurrentWithOldInstallerScript$"
      - EXTRA_PARAMS: --run "TestInstallScriptWithAgentUser$"
      - EXTRA_PARAMS: --run "TestInstallScriptWithAgentUserOnDC$"
      - EXTRA_PARAMS: --run "TestInstaller$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstalls$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstallsWithoutIIS/TestInstallDotnetLibraryPackageWithoutIIS$"
      - EXTRA_PARAMS: --run "TestDotnetLibraryInstallsWithoutIIS/TestMSIInstallDotnetLibraryFailsWithoutIIS$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestInstallFromMSI$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSIThenRemoteUpgrade$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestUpgradeWithMSI$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSIRollbackRemovesLibrary$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSISkipRollbackIfInstalled$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestUninstallKeepsLibrary$"
      - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestUninstallScript$"
+     - EXTRA_PARAMS: --run "TestAgentMSIInstallsDotnetLibrary/TestMSIPurge$"
      - EXTRA_PARAMS: --run "TestAgentScriptInstallsDotnetLibrary/TestInstallFromScript$"
      - EXTRA_PARAMS: --run "TestAgentScriptInstallsDotnetLibrary/TestScriptThenRemoteUpgrade$"
    retry:
      exit_codes:
      - 42
      - 101
      max: 2
      when:
      - runner_system_failure
      - stuck_or_timeout_failure
      - unknown_failure
      - api_failure
      - scheduler_failure
      - stale_schedule
      - data_integrity_failure
    rules:
    - if: $RUN_E2E_TESTS == "off"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $RUN_E2E_TESTS == "on"
      when: on_success
    - if: $CI_COMMIT_BRANCH == "main"
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: on_success
    - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
      when: on_success
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - .gitlab/e2e/e2e.yml
        - test/new-e2e/pkg/**/*
        - test/new-e2e/go.mod
        - flakes.yaml
        - release.json
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - .gitlab/**/*
        - omnibus/config/**/*
        - pkg/fleet/**/*
        - cmd/installer/**/*
        - test/new-e2e/tests/installer/**/*
        - tasks/installer.py
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - export IS_DEV_BRANCH="$(dda inv -- -e pipeline.is-dev-branch)"
    - DYNAMIC_TESTS_BREAKGLASS=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DYNAMIC_TESTS_BREAKGLASS
      value) || exit $?; export DYNAMIC_TESTS_BREAKGLASS
    - "if [ \"$DYNAMIC_TESTS_BREAKGLASS\" = \"true\" ] || [ \"$IS_DEV_BRANCH\" = \"\
      false\" ] || [ RUN_E2E_TESTS == \"on\" ]; then\n  export DYNAMIC_TESTS_FLAG=\"\
      \"\nfi\n"
    - dda inv -- -e new-e2e-tests.run $DYNAMIC_TESTS_FLAG $PRE_BUILT_BINARIES_FLAG $MAX_RETRIES_FLAG
      --local-package $CI_PROJECT_DIR/$OMNIBUS_BASE_DIR --result-json $E2E_RESULT_JSON
      --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
      -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
      --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs
      --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
    stage: e2e
    tags:
    - arch:amd64
    - specific:true
    variables:
      DYNAMIC_TESTS_FLAG: --impacted
      E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
      E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
      E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
      E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
      E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
      E2E_COVERAGE_OUT_DIR: $CI_PROJECT_DIR/coverage
      E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
      E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
      E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
      E2E_LOGS_PROCESSING_TEST_DEPTH: 1
      E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
      E2E_PIPELINE_ID: $CI_PIPELINE_ID
      E2E_RESULT_JSON: $CI_PROJECT_DIR/e2e_test_output.json
      E2E_USE_AWS_PROFILE: 'false'
      EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
      FLAKY_PATTERNS_CONFIG: $CI_PROJECT_DIR/flaky-patterns-runtime.yaml
      FLEET_INSTALL_METHOD: windows
      GIT_STRATEGY: clone
      KUBERNETES_CPU_REQUEST: 6
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      MAX_RETRIES_FLAG: --max-retries=3
      PRE_BUILT_BINARIES_FLAG: --use-prebuilt-binaries
      REMOTE_STACK_CLEANING: 'true'
      SHOULD_RUN_IN_FLAKES_FINDER: 'true'
      TARGETS: ./tests/installer/windows
      TEAM: windows-products

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2025-10-20T19:51:54Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a51f35a

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${677.26}$$ < $${702.15}$$	$${+0.01}$$	$${165.26}$$ < $${177.79}$$
✅	agent_deb_amd64_fips	$${0}$$	$${671.76}$$ < $${696.65}$$	$${-0.03}$$	$${164.22}$$ < $${176.53}$$
✅	agent_heroku_amd64	$${0}$$	$${336.54}$$ < $${340.18}$$	$${+0}$$	$${89.82}$$ < $${91.08}$$
✅	agent_msi	$${0}$$	$${1013.64}$$ < $${1015.38}$$	$${-0.02}$$	$${148.23}$$ < $${150.78}$$
✅	agent_rpm_amd64	$${0}$$	$${677.25}$$ < $${702.14}$$	$${-0.02}$$	$${167.42}$$ < $${180.53}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${671.75}$$ < $${696.64}$$	$${+0}$$	$${166.1}$$ < $${178.79}$$
✅	agent_rpm_arm64	$${0}$$	$${667.25}$$ < $${686.31}$$	$${-0.04}$$	$${153.41}$$ < $${161.22}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${662.78}$$ < $${681.84}$$	$${-0.06}$$	$${152.58}$$ < $${160.18}$$
✅	agent_suse_amd64	$${0}$$	$${677.25}$$ < $${702.14}$$	$${-0.02}$$	$${167.42}$$ < $${180.53}$$
✅	agent_suse_amd64_fips	$${0}$$	$${671.75}$$ < $${696.64}$$	$${+0}$$	$${166.1}$$ < $${178.79}$$
✅	agent_suse_arm64	$${0}$$	$${667.25}$$ < $${686.31}$$	$${-0.04}$$	$${153.41}$$ < $${161.22}$$
✅	agent_suse_arm64_fips	$${0}$$	$${662.78}$$ < $${681.84}$$	$${-0.06}$$	$${152.58}$$ < $${160.18}$$
✅	docker_agent_amd64	$${-0}$$	$${747.81}$$ < $${773.59}$$	$${-0}$$	$${252.13}$$ < $${266.06}$$
✅	docker_agent_arm64	$${-0}$$	$${761.76}$$ < $${781.7}$$	$${-0}$$	$${242.72}$$ < $${251.85}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${938.68}$$ < $${964.45}$$	$${+0.01}$$	$${320.76}$$ < $${334.68}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${941.22}$$ < $${961.17}$$	$${-0}$$	$${307.3}$$ < $${316.44}$$
✅	docker_cluster_agent_amd64	$${0}$$	$${213.72}$$ < $${213.74}$$	$${+0}$$	$${72.51}$$ < $${73.14}$$
✅	docker_cluster_agent_arm64	$${+0}$$	$${229.61}$$ < $${229.68}$$	$${+0}$$	$${68.76}$$ < $${69.41}$$
✅	docker_cws_instrumentation_amd64	$${+0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${38.45}$$ < $${39.3}$$	$${-0}$$	$${14.84}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${+0}$$	$${37.12}$$ < $${37.94}$$	$${+0}$$	$${14.28}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.82}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.25}$$ < $${29.11}$$	$${-0}$$	$${6.77}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.66}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.33}$$ < $${54.97}$$	$${-0}$$	$${11.05}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.12}$$ < $${51.9}$$	$${+0}$$	$${9.54}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.04}$$ < $${51.84}$$	$${-0}$$	$${9.64}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.33}$$ < $${54.97}$$	$${-0}$$	$${11.07}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.33}$$ < $${54.97}$$	$${-0}$$	$${11.07}$$ < $${14.47}$$

cit-pr-commenter · 2025-10-20T20:00:31Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: caaa00e7-50b2-4ad7-bcb3-5c5718f3418e

Baseline: a51f35a
Comparison: 0893d50
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.09	[-0.90, +1.07]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.65	[-1.15, +4.45]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.87	[+0.69, +1.06]	1	Logs
➖	file_tree	memory utilization	+0.78	[+0.72, +0.83]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.47	[+0.41, +0.53]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.47	[+0.27, +0.66]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.31	[+0.28, +0.35]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.28	[+0.23, +0.32]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.14	[+0.01, +0.26]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.12	[-0.49, +0.74]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.09	[-0.51, +0.70]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.09	[-0.90, +1.07]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.57, +0.62]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.59, +0.60]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.22, +0.22]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	ddot_logs	memory utilization	-0.07	[-0.13, -0.01]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.12	[-0.26, +0.02]	1	Logs
➖	ddot_metrics	memory utilization	-0.41	[-0.59, -0.23]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.60	[-0.80, -0.41]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.98	[-1.06, -0.89]	1	Logs
➖	otlp_ingest_logs	memory utilization	-1.61	[-1.69, -1.53]	1	Logs
➖	docker_containers_memory	memory utilization	-4.55	[-5.03, -4.08]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

bmermet · 2025-10-24T14:28:33Z

-                    InstallPackage(libWithVersion.Name, libWithVersion.Version);
                }
+                // add purge command to the rollback data store
+                _rollbackDataStore.Add(new InstallerPackageRollback("purge"));


Should we do that only on a fresh install? It might be better to keep updated packages, than no packages at all.

The rollback task will only actually run on fresh install. We just store it everywhere

bmermet · 2025-10-24T14:33:02Z

+        private bool ShouldPurge()
        {
-            return $"datadog-apm-library-{language}";
+            var purge = _session.Property("PURGE");


If we don't have a reason not to since our last discussion, I'm in favor of making purge the default and skipping it only when a flag is passed.

I am doing that in a future PR, as that way we can more easily roll it back if something goes wrong

jack0x2 · 2025-10-27T21:55:24Z

/merge

dd-devflow-routing-codex · 2025-10-27T21:55:28Z

View all feedbacks in Devflow UI.

2025-10-27 21:55:28 UTC ℹ️ Start processing command /merge

2025-10-27 21:55:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-28 01:56:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

jack0x2 · 2025-10-29T16:24:29Z

/merge

dd-devflow-routing-codex · 2025-10-29T16:24:33Z

View all feedbacks in Devflow UI.

2025-10-29 16:24:33 UTC ℹ️ Start processing command /merge

2025-10-29 16:24:39 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 38m (p90).

2025-10-29 16:48:46 UTC ℹ️ MergeQueue: This merge request was merged

Base automatically changed from jack.phillips/fix-fleet-apm-setup to main October 21, 2025 14:34

jack0x2 added 5 commits October 21, 2025 13:12

update Install workflow

9581758

add purge rollback

9e83cd7

add purge option to MSI

92767bf

add test

d85ad8f

lint

714c01d

jack0x2 force-pushed the jack.phillips/msi-oci-install branch from d60e3a9 to 714c01d Compare October 21, 2025 17:14

github-actions Bot added medium review PR review might take time team/windows-products labels Oct 21, 2025

skip setup during fleet installs

6449c69

jack0x2 added the qa/done QA done before merge and regressions are covered by tests label Oct 21, 2025

jack0x2 added 8 commits October 21, 2025 14:33

update tests to pass in correct version string for new script

4fd11f5

release notes

0263a9b

update to not purge on upgrades

59e6660

update passed arg

fa8eb76

add comment

f324d31

make remote updates false

5ebefbd

remove un-need comment

bd7e149

update logic for rollback

fb46b1c

jack0x2 marked this pull request as ready for review October 23, 2025 16:31

jack0x2 requested review from a team as code owners October 23, 2025 16:31

jack0x2 added the ask-review Ask in slack required teams to review this PR label Oct 23, 2025

estherk15 approved these changes Oct 23, 2025

View reviewed changes

bmermet reviewed Oct 24, 2025

View reviewed changes

Comment thread test/new-e2e/tests/installer/windows/suites/apm-library-dotnet-package/install_no_iis_test.go

clarkb7 reviewed Oct 24, 2025

View reviewed changes

bmermet reviewed Oct 24, 2025

View reviewed changes

github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Oct 24, 2025

jack0x2 added 6 commits October 24, 2025 13:16

update property for remote_updates

5bbd580

update to correct var

0001e24

default to false

51688c6

update comments and checks

176a866

whoops add comment

c5b7d07

fix typo

a0136f5

clarkb7 approved these changes Oct 27, 2025

View reviewed changes

Comment thread pkg/fleet/installer/installer.go Outdated

Comment thread tools/windows/DatadogAgentInstaller/CustomActions/InstallOciPackages.cs Outdated

jack0x2 added 2 commits October 27, 2025 17:47

one more feedback

d2c1fea

Merge branch 'main' into jack.phillips/msi-oci-install

4ed9e6b

jack0x2 added 4 commits October 28, 2025 10:13

lint

5923de7

Merge branch 'main' into jack.phillips/msi-oci-install

7ed665a

fix to correct var

d2fd474

fix logic of exact match

0893d50

dd-mergequeue Bot merged commit 83653b0 into main Oct 29, 2025
372 checks passed

dd-mergequeue Bot deleted the jack.phillips/msi-oci-install branch October 29, 2025 16:48

github-actions Bot added this to the 7.73.0 milestone Oct 29, 2025

Uh oh!

Conversation

jack0x2 commented Oct 20, 2025 • edited by clarkb7 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

agent-platform-auto-pr Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

Uh oh!

agent-platform-auto-pr Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmermet Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

jack0x2 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

bmermet Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

jack0x2 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jack0x2 commented Oct 27, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jack0x2 commented Oct 29, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jack0x2 commented Oct 20, 2025 •

edited by clarkb7

Loading

agent-platform-auto-pr Bot commented Oct 20, 2025 •

edited

Loading

agent-platform-auto-pr Bot commented Oct 20, 2025 •

edited

Loading

cit-pr-commenter Bot commented Oct 20, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Oct 27, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Oct 29, 2025 •

edited

Loading