Skip to content

ebpf: prevent tcp queue length check from loading debug .o #42163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 1 commit into from
Oct 21, 2025
Merged

ebpf: prevent tcp queue length check from loading debug .o #42163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions pkg/collector/corechecks/ebpf/probe/tcpqueuelength/tcp_queue_length.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type Tracer struct {
// NewTracer creates a [Tracer]
func NewTracer(cfg *ebpf.Config) (*Tracer, error) {
if cfg.EnableCORE {
probe, err := loadTCPQueueLengthCOREProbe(cfg)
probe, err := loadTCPQueueLengthCOREProbe()
if err != nil {
if !cfg.AllowRuntimeCompiledFallback {
return nil, fmt.Errorf("error loading CO-RE tcp-queue-length probe: %s. set system_probe_config.allow_runtime_compiled_fallback to true to allow fallback to runtime compilation", err)
Expand Down Expand Up @@ -150,7 +150,7 @@ func (t *Tracer) GetAndFlush() model.TCPQueueLengthStats {
return result
}

func loadTCPQueueLengthCOREProbe(cfg *ebpf.Config) (*Tracer, error) {
func loadTCPQueueLengthCOREProbe() (*Tracer, error) {
kv, err := kernel.HostVersion()
if err != nil {
return nil, fmt.Errorf("error detecting kernel version: %s", err)
Expand All @@ -159,13 +159,8 @@ func loadTCPQueueLengthCOREProbe(cfg *ebpf.Config) (*Tracer, error) {
return nil, fmt.Errorf("detected kernel version %s, but tcp-queue-length probe requires a kernel version of at least 4.8.0", kv)
}

filename := "tcp-queue-length.o"
if cfg.BPFDebug {
filename = "tcp-queue-length-debug.o"
}

var probe *Tracer
err = ebpf.LoadCOREAsset(filename, func(buf bytecode.AssetReader, opts manager.Options) error {
err = ebpf.LoadCOREAsset("tcp-queue-length.o", func(buf bytecode.AssetReader, opts manager.Options) error {
probe, err = startTCPQueueLengthProbe(buf, opts)
return err
})
Expand Down