Update rules_foreign_cc patch set#43893
Merged
dd-mergequeue[bot] merged 8 commits intomainfrom Jan 9, 2026
Merged
Conversation
chouquette
added
changelog/no-changelog
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 2a3fa50 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.14 | [-4.09, +1.80] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.97 | [+0.87, +1.07] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.64 | [+0.53, +0.75] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.63 | [+0.47, +0.79] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.40 | [+0.24, +0.55] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.20 | [+0.17, +0.24] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.09 | [+0.03, +0.15] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.05 | [-0.18, +0.28] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.04 | [-0.18, +0.27] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.03 | [-0.38, +0.45] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.36, +0.39] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.01 | [-0.03, +0.06] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.04, +0.06] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.07, +0.07] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.15, +0.13] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.04 | [-0.09, +0.02] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.47, +0.35] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.10 | [-0.30, +0.11] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.18 | [-0.26, -0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.38 | [-0.43, -0.32] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.90 | [-2.37, +0.57] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -1.14 | [-4.09, +1.80] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.46 | [-1.67, -1.25] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
JSGette
reviewed
Dec 8, 2025
| export SYSTEMDRIVE="C:" | ||
| """ | ||
|
|
||
| +def increment_ld_library_path(_source): |
Contributor
There was a problem hiding this comment.
this doesn't seem right to me
Contributor
Author
There was a problem hiding this comment.
As mentioned in our daily, not returning an empty string would cause this error:
Traceback (most recent call last):
File "C:/bzl/bazel/d42blgaa/external/rules_foreign_cc+/foreign_cc/configure.bzl", line 70, column 33, in _configure_make
return cc_external_rule_impl(ctx, attrs)
File "C:/bzl/bazel/d42blgaa/external/rules_foreign_cc+/foreign_cc/private/framework.bzl", line 513, column 29, in cc_external_rule_impl
convert_shell_script(ctx, script_lines),
File "C:/bzl/bazel/d42blgaa/external/rules_foreign_cc+/foreign_cc/private/framework/helpers.bzl", line 74, column 43, in convert_shell_script
return convert_shell_script_by_context(create_context(ctx), script)
File "C:/bzl/bazel/d42blgaa/external/rules_foreign_cc+/foreign_cc/private/framework/helpers.bzl", line 90, column 31, in convert_shell_script_by_context
script = [do_function_call(line, shell_context) for line in script]
File "C:/bzl/bazel/d42blgaa/external/rules_foreign_cc+/foreign_cc/private/framework/helpers.bzl", line 186, column 46, in do_function_call
(funname, after) = get_function_name(text.strip(" "))
Error: 'NoneType' value has no field or method 'strip'
I agree that it's not elegant, so I could also replace it with pass and fix the call site.
I opened a PR upstream to see if they have an opinion to share on the matter
Contributor
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Contributor
Author
rdesgroppes
approved these changes
Jan 9, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
### What does this PR do? Build python with bazel (through rules_foreign_cc) ### Motivation Migrating our builds to bazel ### Describe how you validated your changes Local builds for linux x86_64, CI for the others ### Additional Notes This is based on top of #43893 Co-authored-by: rdesgroppes <rdesgroppes@gmail.com> Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
theomagellan
pushed a commit
that referenced
this pull request
Feb 2, 2026
### What does this PR do? Build python with bazel (through rules_foreign_cc) ### Motivation Migrating our builds to bazel ### Describe how you validated your changes Local builds for linux x86_64, CI for the others ### Additional Notes This is based on top of #43893 Co-authored-by: rdesgroppes <rdesgroppes@gmail.com> Co-authored-by: hugo.beauzee <hugo.beauzee@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
LD_LIBRARY_PATHorDYLD_LIBRARY_PATHbased on the provided dependenciesout_pc_diroutput group with a more flexibleout_data_dirapproachMotivation
Describe how you validated your changes
Additional Notes