-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ABLD-8] Proof of concept of creating install scripts with bazel #44183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b09cd03 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -3.80 | [-6.76, -0.83] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +2.18 | [+1.97, +2.38] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | +0.29 | [+0.05, +0.53] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.28 | [+0.20, +0.35] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.26 | [+0.18, +0.33] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.10 | [+0.05, +0.15] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.08 | [+0.01, +0.14] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.35, +0.48] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.03 | [-0.20, +0.26] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.08, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.12, +0.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.14, +0.13] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.01 | [-0.09, +0.07] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.39, +0.35] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.10, -0.01] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.06 | [-0.21, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.07 | [-0.47, +0.33] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.08 | [-0.11, -0.05] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.22 | [-0.42, -0.01] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.30 | [-0.45, -0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.51 | [-0.57, -0.46] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.58 | [-0.68, -0.47] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.79 | [-2.25, +0.67] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -3.80 | [-6.76, -0.83] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
7328f2c to
56aa6b1
Compare
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 49 | 0 | 0 |
Updated: .gitlab/trigger_distribution/include.yml
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 1 | 0 | 0 |
ℹ️ Diff available in the job log.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
38a2711 to
6502701
Compare
6502701 to
ccc6d11
Compare
- Create agent "flavor" flags (none, fips, heroku) - These can be used from the command line to install different pieces of the agent as needed. - Use the distinction to install the correct set of OSS licenses. - Fix license file for libpopt Changing for heroku will invalidate the cache, but I can live with that - it is a smaller build than the rest, an already a distinct pipeline - for now, we are only using it for the packaging layers. My plan is to adopt project files to be able to limit the scope of the flavor flag so that it will not reach outside of //packages/... This is a precursor to #44033 and #44183, which add top level package targets for the distinct distribution artifacts. At that time, the "select()"ion of all deps will happen from the top, and we won't need license generation in //compliance.
- create a rule that will expand a template, automatically using the command line flags to set an output dir and the path of the install_dir - create /packages/debian/etc as the place to hold the creationg of the etc files. - Do it for a single script in agent-init-scripts.rb We can follow up with more scripts in another PR.
ccc6d11 to
914ffc7
Compare
Followups
PackageFilesInfoso that we can consume it directly.testing
Related: ABLD-303