Skip to content

Conversation

@aiuto
Copy link
Contributor

@aiuto aiuto commented Dec 13, 2025

  • create a rule that will expand a template, automatically using the command line flags to set an output dir and the path of the install_dir
  • create /packages/debian/etc as the place to hold the creation of the etc files.
  • Do it for a single script in agent-init-scripts.rb

Followups

  • Convert more scripts in another PR.
  • Do the same pattern for redhat init scripts
  • Have dd_agent_expand_template return a PackageFilesInfo so that we can consume it directly.

testing

  • run CI, grab the .deb artifact, unpack it, verify /etc/init is identical to a previously built package.

Related: ABLD-303

@aiuto aiuto added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 13, 2025
@github-actions github-actions bot added team/agent-build medium review PR review might take time labels Dec 13, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 13, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9fa60b3b-665e-483e-bfa3-9c73ce324ac4

Baseline: b09cd03
Comparison: 914ffc7
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -3.80 [-6.76, -0.83] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +2.18 [+1.97, +2.38] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.29 [+0.05, +0.53] 1 Logs
ddot_logs memory utilization +0.28 [+0.20, +0.35] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.26 [+0.18, +0.33] 1 Logs
quality_gate_idle memory utilization +0.10 [+0.05, +0.15] 1 Logs bounds checks dashboard
file_tree memory utilization +0.08 [+0.01, +0.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.35, +0.48] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.03 [-0.20, +0.26] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.12, +0.12] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.14, +0.13] 1 Logs
docker_containers_memory memory utilization -0.01 [-0.09, +0.07] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.39, +0.35] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.10, -0.01] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.06 [-0.21, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.47, +0.33] 1 Logs
quality_gate_idle_all_features memory utilization -0.08 [-0.11, -0.05] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.22 [-0.42, -0.01] 1 Logs
otlp_ingest_metrics memory utilization -0.30 [-0.45, -0.14] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.51 [-0.57, -0.46] 1 Logs
otlp_ingest_logs memory utilization -0.58 [-0.68, -0.47] 1 Logs
quality_gate_logs % cpu utilization -0.79 [-2.25, +0.67] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -3.80 [-6.76, -0.83] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aiuto aiuto force-pushed the aiuto/iscripts branch 5 times, most recently from 7328f2c to 56aa6b1 Compare December 15, 2025 13:40
@agent-platform-auto-pr
Copy link
Contributor

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 49 0 0

Updated: .gitlab/trigger_distribution/include.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 1 0 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 15, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2ba0d4c

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${+0}$$ $${706.18}$$ < $${707.13}$$ $${-0}$$ $${173.27}$$ < $${174.16}$$
agent_deb_amd64_fips $${+0}$$ $${702.4}$$ < $${702.86}$$ $${-0.04}$$ $${172.58}$$ < $${173.5}$$
agent_heroku_amd64 $${0}$$ $${327.51}$$ < $${327.92}$$ $${-0}$$ $${87.23}$$ < $${88.21}$$
agent_msi $${0}$$ $${570.43}$$ < $${982.08}$$ $${+0.01}$$ $${142.49}$$ < $${143.49}$$
agent_rpm_amd64 $${+0}$$ $${706.17}$$ < $${707.12}$$ $${+0.01}$$ $${176.41}$$ < $${177.29}$$
agent_rpm_amd64_fips $${+0}$$ $${702.39}$$ < $${702.85}$$ $${+0.07}$$ $${175.35}$$ < $${176.32}$$
agent_rpm_arm64 $${0}$$ $${687.87}$$ < $${691.67}$$ $${+0.01}$$ $${159.48}$$ < $${160.7}$$
agent_rpm_arm64_fips $${0}$$ $${684.92}$$ < $${687.54}$$ $${+0.03}$$ $${159.15}$$ < $${160.11}$$
agent_suse_amd64 $${+0}$$ $${706.17}$$ < $${707.12}$$ $${+0.01}$$ $${176.41}$$ < $${177.29}$$
agent_suse_amd64_fips $${+0}$$ $${702.39}$$ < $${702.85}$$ $${+0.07}$$ $${175.35}$$ < $${176.32}$$
agent_suse_arm64 $${0}$$ $${687.87}$$ < $${691.67}$$ $${+0.01}$$ $${159.48}$$ < $${160.7}$$
agent_suse_arm64_fips $${0}$$ $${684.92}$$ < $${687.54}$$ $${+0.03}$$ $${159.15}$$ < $${160.11}$$
docker_agent_amd64 $${+0.02}$$ $${768.43}$$ < $${769.38}$$ $${-0.01}$$ $${261.12}$$ < $${262.06}$$
docker_agent_arm64 $${+0.01}$$ $${774.68}$$ < $${778.35}$$ $${-0.01}$$ $${250.23}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0.01}$$ $${959.31}$$ < $${960.26}$$ $${+0.02}$$ $${329.76}$$ < $${330.69}$$
docker_agent_jmx_arm64 $${+0.01}$$ $${954.27}$$ < $${957.95}$$ $${-0.03}$$ $${314.84}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${0}$$ $${179.41}$$ < $${179.56}$$ $${+0}$$ $${63.44}$$ < $${64.14}$$
docker_cluster_agent_arm64 $${+0}$$ $${195.36}$$ < $${196.79}$$ $${-0}$$ $${59.75}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.13}$$ < $${7.18}$$ $${-0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${-0}$$ $${38.75}$$ < $${39.38}$$ $${+0}$$ $${15.0}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${+0}$$ $${37.06}$$ < $${37.94}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${-0}$$ $${7.93}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.13}$$ < $${29.11}$$ $${+0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${29.98}$$ < $${30.61}$$ $${-0}$$ $${7.94}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.19}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${39.88}$$ < $${40.92}$$ $${+0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.44}$$ < $${41.03}$$ $${+0}$$ $${9.76}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.21}$$ < $${12.06}$$

@aiuto aiuto marked this pull request as ready for review December 15, 2025 20:50
@aiuto aiuto requested a review from a team as a code owner December 15, 2025 20:50
@aiuto aiuto added the ask-review Ask required teams to review this PR label Dec 15, 2025
@aiuto aiuto changed the title Proof of concept of creating install scripts with bazel [ABLD-303] Proof of concept of creating install scripts with bazel Dec 15, 2025
@aiuto aiuto changed the title [ABLD-303] Proof of concept of creating install scripts with bazel [ABLD-8] Proof of concept of creating install scripts with bazel Dec 15, 2025
aiuto added a commit that referenced this pull request Dec 16, 2025
- Create agent "flavor" flags (none, fips, heroku)
- These can be used from the command line to install different pieces of the agent as needed.
- Use the distinction to install the correct set of OSS licenses.
- Fix license file for libpopt

Changing for heroku will invalidate the cache, but I can live with that
- it is a smaller build than the rest, an already a distinct pipeline
- for now, we are only using it for the packaging layers.  My plan is to adopt project files to be able to limit the scope of the flavor flag so that it will not reach outside of //packages/...

This is a precursor to #44033 and #44183, which add top level package targets for the distinct distribution artifacts.
At that time, the "select()"ion of all deps will happen from the top, and we won't need license generation in //compliance.
- create a rule that will expand a template, automatically using the command line flags to set an output dir and the path of the install_dir
- create /packages/debian/etc as the place to hold the creationg of the etc files.
- Do it for a single script in agent-init-scripts.rb

We can follow up with more scripts in another PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants