Skip to content

Conversation

@liustanley
Copy link
Contributor

@liustanley liustanley commented Dec 15, 2025

What does this PR do?

Adds e2e test for DDOT Gateway. This PR adds new e2e test options to enable e2e testing for DDOT gateway deployments:

  • WithOTelAgentGateway adds otelAgentGateway helm values and enables gateway collector
  • WithOTelGatewayConfig allows you to pass in a collector config for the gateway collector (see gateway.yml)

This PR also has two relevant changes in the e2e test framework:

  • Updates datadog-agent helm chart version from 3.135.4 to 3.155.1 (previous version didn't include gateway changes)
  • Disables testingWorkloads in buildLinuxHelmValues for gateway tests, since agents.useConfigMap was causing errors in gateway deployment

Motivation

Describe how you validated your changes

Running e2e tests

Additional Notes

WithOTelAgentConfig (daemonset DDOT otel config param) cannot be used with Gateway e2e tests yet because these tests depend on the default daemonset otel config which automatically points to the gateway collector address: https://github.com/DataDog/helm-charts/blob/12f196db60526a0b67bbe77bc6b61a8c934d5d62/charts/datadog/templates/_otel_agent_config.yaml#L15.

This can be implemented in a future PR but might require some legwork.

@github-actions github-actions bot added medium review PR review might take time team/agent-devx labels Dec 15, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 15, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d1bd251

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${706.33}$$ < $${707.13}$$ $${+0.03}$$ $${173.3}$$ < $${174.16}$$
agent_deb_amd64_fips $${-0}$$ $${702.55}$$ < $${702.86}$$ $${-0.03}$$ $${172.58}$$ < $${173.5}$$
agent_heroku_amd64 $${0}$$ $${327.51}$$ < $${327.92}$$ $${-0.01}$$ $${87.23}$$ < $${88.21}$$
agent_msi $${0}$$ $${570.41}$$ < $${982.08}$$ $${+0.01}$$ $${142.48}$$ < $${143.49}$$
agent_rpm_amd64 $${-0}$$ $${706.31}$$ < $${707.12}$$ $${+0}$$ $${176.41}$$ < $${177.29}$$
agent_rpm_amd64_fips $${-0}$$ $${702.53}$$ < $${702.85}$$ $${-0.01}$$ $${175.41}$$ < $${176.32}$$
agent_rpm_arm64 $${+0}$$ $${688.02}$$ < $${691.67}$$ $${-0.03}$$ $${159.4}$$ < $${160.7}$$
agent_rpm_arm64_fips $${+0}$$ $${685.06}$$ < $${687.54}$$ $${-0.02}$$ $${159.17}$$ < $${160.11}$$
agent_suse_amd64 $${-0}$$ $${706.31}$$ < $${707.12}$$ $${+0}$$ $${176.41}$$ < $${177.29}$$
agent_suse_amd64_fips $${-0}$$ $${702.53}$$ < $${702.85}$$ $${-0.01}$$ $${175.41}$$ < $${176.32}$$
agent_suse_arm64 $${+0}$$ $${688.02}$$ < $${691.67}$$ $${-0.03}$$ $${159.4}$$ < $${160.7}$$
agent_suse_arm64_fips $${+0}$$ $${685.06}$$ < $${687.54}$$ $${-0.02}$$ $${159.17}$$ < $${160.11}$$
docker_agent_amd64 $${-0}$$ $${768.57}$$ < $${769.38}$$ $${-0}$$ $${261.17}$$ < $${262.06}$$
docker_agent_arm64 $${+0}$$ $${774.82}$$ < $${778.35}$$ $${-0}$$ $${250.27}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${+0.01}$$ $${959.46}$$ < $${960.26}$$ $${-0.04}$$ $${329.77}$$ < $${330.69}$$
docker_agent_jmx_arm64 $${+0}$$ $${954.41}$$ < $${957.95}$$ $${-0}$$ $${314.89}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${179.41}$$ < $${179.56}$$ $${-0}$$ $${63.44}$$ < $${64.14}$$
docker_cluster_agent_arm64 $${-0}$$ $${195.36}$$ < $${196.79}$$ $${+0}$$ $${59.75}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.13}$$ < $${7.18}$$ $${-0}$$ $${2.99}$$ < $${3.33}$$
docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.73}$$ < $${3.09}$$
docker_dogstatsd_amd64 $${+0}$$ $${38.75}$$ < $${39.38}$$ $${+0}$$ $${15.0}$$ < $${15.82}$$
docker_dogstatsd_arm64 $${0}$$ $${37.06}$$ < $${37.94}$$ $${+0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${+0}$$ $${7.93}$$ < $${8.79}$$
dogstatsd_deb_arm64 $${0}$$ $${28.13}$$ < $${29.11}$$ $${-0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
dogstatsd_suse_amd64 $${0}$$ $${29.97}$$ < $${30.61}$$ $${+0}$$ $${7.94}$$ < $${8.8}$$
iot_agent_deb_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${+0}$$ $${11.19}$$ < $${12.04}$$
iot_agent_deb_arm64 $${0}$$ $${39.87}$$ < $${40.92}$$ $${-0}$$ $${9.57}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.44}$$ < $${41.03}$$ $${+0}$$ $${9.76}$$ < $${10.62}$$
iot_agent_rpm_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${-0}$$ $${11.21}$$ < $${12.06}$$
iot_agent_suse_amd64 $${0}$$ $${42.73}$$ < $${43.29}$$ $${-0}$$ $${11.21}$$ < $${12.06}$$

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 15, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 97c83553-1194-4335-b360-0d1a1ec633c4

Baseline: d1bd251
Comparison: 1bd4e95
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.46 [-0.65, +5.56] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.46 [-0.65, +5.56] 1 Logs
quality_gate_logs % cpu utilization +1.53 [+0.02, +3.03] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.58 [+0.35, +0.81] 1 Logs
otlp_ingest_metrics memory utilization +0.56 [+0.41, +0.71] 1 Logs
ddot_metrics_sum_delta memory utilization +0.47 [+0.26, +0.69] 1 Logs
quality_gate_idle_all_features memory utilization +0.39 [+0.35, +0.42] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.16 [-0.06, +0.38] 1 Logs
docker_containers_memory memory utilization +0.16 [+0.08, +0.23] 1 Logs
otlp_ingest_logs memory utilization +0.12 [+0.01, +0.23] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.35, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.00 [-0.41, +0.41] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.14, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.44, +0.38] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.10 [-0.14, -0.05] 1 Logs
quality_gate_idle memory utilization -0.23 [-0.27, -0.18] 1 Logs bounds checks dashboard
file_tree memory utilization -0.32 [-0.38, -0.25] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.33 [-0.39, -0.28] 1 Logs
ddot_logs memory utilization -0.41 [-0.48, -0.34] 1 Logs
quality_gate_metrics_logs memory utilization -0.55 [-0.76, -0.34] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.57 [-0.73, -0.42] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.65 [-0.74, -0.55] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@liustanley liustanley changed the title Add DDOT gateway e2e test [OTAGENT-591] Add DDOT gateway e2e test Dec 16, 2025
@liustanley liustanley marked this pull request as ready for review December 16, 2025 21:14
@liustanley liustanley requested review from a team as code owners December 16, 2025 21:14
@liustanley liustanley requested a review from RiantZ December 16, 2025 21:14
@songy23 songy23 self-requested a review December 16, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants