-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[OTAGENT-591] Add DDOT gateway e2e test #44260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: d1bd251 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.46 | [-0.65, +5.56] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.46 | [-0.65, +5.56] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.53 | [+0.02, +3.03] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics | memory utilization | +0.58 | [+0.35, +0.81] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.56 | [+0.41, +0.71] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.47 | [+0.26, +0.69] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.39 | [+0.35, +0.42] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.16 | [-0.06, +0.38] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.16 | [+0.08, +0.23] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.12 | [+0.01, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.35, +0.40] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.00 | [-0.41, +0.41] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.14, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.44, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.10 | [-0.14, -0.05] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.23 | [-0.27, -0.18] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -0.32 | [-0.38, -0.25] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.33 | [-0.39, -0.28] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.41 | [-0.48, -0.34] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.55 | [-0.76, -0.34] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.57 | [-0.73, -0.42] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.65 | [-0.74, -0.55] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
Adds e2e test for DDOT Gateway. This PR adds new e2e test options to enable e2e testing for DDOT gateway deployments:
WithOTelAgentGatewayaddsotelAgentGatewayhelm values and enables gateway collectorWithOTelGatewayConfigallows you to pass in a collector config for the gateway collector (seegateway.yml)This PR also has two relevant changes in the e2e test framework:
3.135.4to3.155.1(previous version didn't include gateway changes)testingWorkloadsinbuildLinuxHelmValuesfor gateway tests, sinceagents.useConfigMapwas causing errors in gateway deploymentMotivation
Describe how you validated your changes
Running e2e tests
Additional Notes
WithOTelAgentConfig(daemonset DDOT otel config param) cannot be used with Gateway e2e tests yet because these tests depend on the default daemonset otel config which automatically points to the gateway collector address: https://github.com/DataDog/helm-charts/blob/12f196db60526a0b67bbe77bc6b61a8c934d5d62/charts/datadog/templates/_otel_agent_config.yaml#L15.This can be implemented in a future PR but might require some legwork.