Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
dd-octo-sts
bot
added
internal
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb82ddf282
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| switch event.Type { | ||
| case workloadmeta.EventTypeSet: | ||
| c.sandboxContainerID[ctr.SandboxID] = ctr.ID |
There was a problem hiding this comment.
A CRI pod sandbox ID is shared by every container in that sandbox, but this cache keeps only one containerID per sandboxID by overwriting on each set event. In multi-container pods (a common sidecar case), the “last event wins” behavior makes buildBaseTags query tags from an arbitrary container, so sandbox metrics can pick up unstable container-specific tags and be misattributed across containers over time.
Useful? React with 👍 / 👎.
| if !ok || ctr.SandboxID == "" { | ||
| continue |
There was a problem hiding this comment.
This early-continue means unset events without SandboxID are ignored, so stale entries are never removed from sandboxContainerID. In this repo, runtime unset events are emitted with only EntityID (for example in containerd createDeletionEvent and CRI-O generateUnsetContainerEvent), so long-lived nodes with churn will accumulate stale mappings and can retain incorrect tag associations if sandbox IDs are reused.
Useful? React with 👍 / 👎.
Go Package Import DifferencesBaseline: f2b5102
|
Files inventory check summaryFile checks results against ancestor bffaa29b: Results for datadog-agent_7.78.0~devel.git.574.eb82ddf.pipeline.102366246-1_amd64.deb:Detected file changes:
|
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
10 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: f2b5102 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.12 | [-3.16, +2.92] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.06 | [+0.83, +1.30] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.90 | [-0.72, +2.52] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.74 | [+0.61, +0.87] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.52 | [+0.44, +0.59] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.50 | [+0.32, +0.67] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.31 | [+0.20, +0.41] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.20 | [+0.14, +0.26] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.17 | [+0.11, +0.22] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.16 | [+0.11, +0.21] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.09 | [-0.09, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.42, +0.44] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.10, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.18, +0.17] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.02 | [-0.20, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.09, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.52, +0.47] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.43, +0.35] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.12 | [-3.16, +2.92] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.12 | [-0.35, +0.10] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.15 | [-0.19, -0.11] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.15 | [-0.31, +0.00] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.26 | [-0.33, -0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.35 | [-0.49, -0.22] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 729 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 273.61MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 725 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.62MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 489.09MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 203.40MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 354.29 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 414.73MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
jeremy-hanna
left a comment
jeremy-hanna
left a comment
There was a problem hiding this comment.
👍 for agent-runtime owned files
2 participants
What does this PR do?
SandboxIdin all CRI implementations (containerd, crio, dockerd, podman ...) so that Container entities have the right sandbox idsandbox<->containermap update on event, this helps extend the kata metrics' tags usingcontainer_idMotivation
Adding a new kata integration.
Previous work were proposed in integration-core and in this repo.
This integration makes more sense to be a go core check
Describe how you validated your changes
Additional Notes