Skip to content

fix(config): add systemd to integration.basic.allowed checks#47817

Open
louis-cqrl wants to merge 1 commit into7.77.xfrom
louis-cqrl/backport-fix-infrab
Open

fix(config): add systemd to integration.basic.allowed checks#47817
louis-cqrl wants to merge 1 commit into7.77.xfrom
louis-cqrl/backport-fix-infrab

Conversation

@louis-cqrl
Copy link
Contributor

What does this PR do?

Backport of #47684 to 7.77.x.

Adds systemd to the list of integration.basic.allowed checks.

Motivation

Backport fix to the 7.77.x release branch.

Describe how you validated your changes

Validated in the original PR #47684.

Additional Notes

Cherry-picked from 6682dd5.

@louis-cqrl louis-cqrl added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Mar 13, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-configuration labels Mar 13, 2026
@louis-cqrl louis-cqrl marked this pull request as ready for review March 13, 2026 14:05
@louis-cqrl louis-cqrl requested a review from a team as a code owner March 13, 2026 14:05
@louis-cqrl louis-cqrl requested a review from dustmop March 13, 2026 14:05
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 13, 2026
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 28a8fc2
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_rpm_arm64 +3.97 KiB (0.00% increase) 734.598 → 734.602 → 741.840
agent_suse_arm64 +3.97 KiB (0.00% increase) 734.598 → 734.602 → 741.840
docker_agent_amd64 +11.11 KiB (0.00% increase) 817.516 → 817.527 → 821.990
docker_agent_arm64 +15.1 KiB (0.00% increase) 820.370 → 820.385 → 828.520
docker_agent_jmx_amd64 +11.11 KiB (0.00% increase) 1008.431 → 1008.442 → 1012.870
docker_agent_jmx_arm64 +15.12 KiB (0.00% increase) 1000.064 → 1000.079 → 1008.120
25 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 756.495 MiB
agent_deb_amd64_fips 715.172 MiB
agent_heroku_amd64 323.876 MiB
agent_msi 622.671 MiB
agent_rpm_amd64 756.478 MiB
agent_rpm_amd64_fips 715.156 MiB
agent_rpm_arm64_fips 696.292 MiB
agent_suse_amd64 756.478 MiB
agent_suse_amd64_fips 715.156 MiB
agent_suse_arm64_fips 696.292 MiB
docker_cluster_agent_amd64 203.004 MiB
docker_cluster_agent_arm64 217.455 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.504 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.724 MiB
dogstatsd_deb_arm64 27.881 MiB
dogstatsd_rpm_amd64 29.724 MiB
dogstatsd_suse_amd64 29.724 MiB
iot_agent_deb_amd64 42.621 MiB
iot_agent_deb_arm64 39.723 MiB
iot_agent_deb_armhf 40.447 MiB
iot_agent_rpm_amd64 42.622 MiB
iot_agent_suse_amd64 42.622 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -3.4 KiB (0.00% reduction) 185.691 → 185.688 → 186.090
agent_deb_amd64_fips +14.45 KiB (0.01% increase) 176.269 → 176.283 → 180.330
agent_heroku_amd64 +4.27 KiB (0.00% increase) 87.046 → 87.050 → 88.440
agent_msi -32.0 KiB (0.02% reduction) 149.406 → 149.375 → 154.470
agent_rpm_amd64 -29.96 KiB (0.02% reduction) 187.609 → 187.579 → 189.170
agent_rpm_amd64_fips +24.95 KiB (0.01% increase) 178.432 → 178.456 → 181.060
agent_rpm_arm64 -39.16 KiB (0.02% reduction) 169.869 → 169.831 → 170.020
agent_rpm_arm64_fips +2.91 KiB (0.00% increase) 162.520 → 162.522 → 164.130
agent_suse_amd64 -29.96 KiB (0.02% reduction) 187.609 → 187.579 → 189.170
agent_suse_amd64_fips +24.95 KiB (0.01% increase) 178.432 → 178.456 → 181.060
agent_suse_arm64 -39.16 KiB (0.02% reduction) 169.869 → 169.831 → 170.020
agent_suse_arm64_fips +2.91 KiB (0.00% increase) 162.520 → 162.522 → 164.130
docker_agent_amd64 -30.51 KiB (0.01% reduction) 277.963 → 277.933 → 279.410
docker_agent_arm64 -13.82 KiB (0.01% reduction) 265.231 → 265.218 → 267.960
docker_agent_jmx_amd64 -38.39 KiB (0.01% reduction) 346.616 → 346.578 → 348.040
docker_agent_jmx_arm64 -15.8 KiB (0.00% reduction) 329.872 → 329.857 → 332.560
docker_cluster_agent_amd64 -15.09 KiB (0.02% reduction) 71.132 → 71.118 → 71.920
docker_cluster_agent_arm64 +3.84 KiB (0.01% increase) 66.771 → 66.775 → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.902 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.236 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.854 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.742 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.867 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.867 MiB → 8.800
iot_agent_deb_amd64 neutral 11.241 MiB → 12.040
iot_agent_deb_arm64 neutral 9.602 MiB → 10.450
iot_agent_deb_armhf neutral 9.803 MiB → 10.620
iot_agent_rpm_amd64 +3.0 KiB (0.03% increase) 11.253 → 11.256 → 12.060
iot_agent_suse_amd64 +3.0 KiB (0.03% increase) 11.253 → 11.256 → 12.060

@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9ebf2dfb-d08a-4318-9aa5-8164e7bb6fab

Baseline: 28a8fc2
Comparison: 2714cd4
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

  • file_to_blackhole_0ms_latency (Logs)
  • file_to_blackhole_1000ms_latency (Logs)
  • file_to_blackhole_100ms_latency (Logs)
  • file_to_blackhole_500ms_latency (Logs)

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -2.31 [-5.32, +0.71] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.66 [+1.44, +1.89] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization +0.84 [+0.68, +1.00] 1 Logs
ddot_metrics_sum_delta memory utilization +0.53 [+0.34, +0.73] 1 Logs
otlp_ingest_logs memory utilization +0.36 [+0.26, +0.46] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.23 [-0.01, +0.46] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.02 [-0.17, +0.20] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.19, +0.20] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.10, +0.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.07 [-0.18, +0.03] 1 Logs
docker_containers_memory memory utilization -0.08 [-0.15, -0.00] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.11 [-0.17, -0.05] 1 Logs
file_tree memory utilization -0.12 [-0.17, -0.07] 1 Logs
ddot_logs memory utilization -0.19 [-0.26, -0.12] 1 Logs
quality_gate_idle_all_features memory utilization -0.32 [-0.35, -0.29] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.33 [-0.56, -0.11] 1 Logs
quality_gate_idle memory utilization -0.37 [-0.42, -0.32] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.59 [-0.75, -0.44] 1 Logs
quality_gate_logs % cpu utilization -2.02 [-3.63, -0.42] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -2.31 [-5.32, +0.71] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 708 ≥ 26
docker_containers_memory memory_usage 10/10 275.66MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 695 ≥ 26
file_to_blackhole_0ms_latency lost_bytes 10/10 0B = 0B
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency lost_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency lost_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency lost_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.38MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 488.89MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs memory_usage 10/10 209.64MiB ≤ 220MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 388.41 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 460.66MiB ≤ 475MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants