Add anomaly detection investigator#47824
Open
ogaca-dd wants to merge 1 commit intoq-branch-observerfrom
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 420edba214
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+123
to
+125
| from := lastQueried | ||
| to := time.Now() | ||
| lastQueried = to |
There was a problem hiding this comment.
A transient Events API failure will permanently drop data from the failed interval because lastQueried is moved to to before fetchEvents succeeds. In the current loop, if the call errors once, the next poll starts after that window, so events emitted during the outage are never fetched and can’t be investigated.
Useful? React with 👍 / 👎.
Comment on lines
+169
to
+173
| if runBits { | ||
| accumulated = nil | ||
| batchStart = time.Time{} | ||
| seenIDs = make(map[string]struct{}) | ||
| } |
There was a problem hiding this comment.
The batch is only cleared when runBits is true, so in the default dry-run mode every idle poll re-flushes the same events and keeps growing the same in-memory batch forever. This contradicts the documented/printed “flush + reset” behavior and makes subsequent outputs include stale events instead of only the next batch.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| printEvents(events, "one-shot", !runBits) | ||
| if err := triggerInvestigation(apiKey, appKey, events, from, !runBits); err != nil { |
There was a problem hiding this comment.
In one-shot mode, the investigation trigger is called with from only, and the payload end time is later derived from time.Now(), so the user-provided --to bound is ignored. This makes historical replays generate investigations over a much larger window than requested, which can skew analysis and increase noise/cost.
Useful? React with 👍 / 👎.
Contributor
Go Package Import DifferencesBaseline: 681899c
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/anomaly_detection_investigatortool that polls the Datadog Events API for anomaly events emitted by the Q-branch observer (source:agent-q-branch-observer)--from/--to)--run_bits; defaults to dry-run displayTest plan
DD_API_KEY/DD_APP_KEYand run in live mode:go run ./cmd/anomaly_detection_investigator-run_bitsand confirm an investigation URL is returned-run_bits=falseand confirm dry-run output only🤖 Generated with Claude Code