libdd_discovery: build as a static library

[Yumasi]

What does this PR do?

This PR changes libdd_discovery to be built as a static library instead of a shared library.

Motivation

The shared library was not bringing anything except needing to set LD_LIBRARY_PATH to run system-probe.

Describe how you validated your changes

Additional Notes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 322e1273fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Update docs to match static library artifact

Changing the library crate type to staticlib means cargo build --release --lib now produces libdd_discovery.a, but the module README still describes building and consuming libdd_discovery.so as a shared library. That leaves developers with broken build/run instructions (including unnecessary LD_LIBRARY_PATH guidance), so this behavior change should be accompanied by a documentation update in the same commit.

Useful? React with 👍 / 👎.

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor 4fed36d1:

Results for datadog-agent_7.78.0~devel.git.584.322e127.pipeline.102430613-1_amd64.deb:

No change detected

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4fed36d
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.938 MiB
✅	agent_deb_amd64_fips	705.304 MiB
✅	agent_heroku_amd64	311.743 MiB
✅	agent_rpm_amd64	746.922 MiB
✅	agent_rpm_amd64_fips	705.288 MiB
✅	agent_rpm_arm64	724.842 MiB
✅	agent_rpm_arm64_fips	686.154 MiB
✅	agent_suse_amd64	746.922 MiB
✅	agent_suse_amd64_fips	705.288 MiB
✅	agent_suse_arm64	724.842 MiB
✅	agent_suse_arm64_fips	686.154 MiB
✅	docker_agent_amd64	807.275 MiB
✅	docker_agent_arm64	809.996 MiB
✅	docker_agent_jmx_amd64	998.190 MiB
✅	docker_agent_jmx_arm64	989.690 MiB
✅	docker_cluster_agent_amd64	203.662 MiB
✅	docker_cluster_agent_arm64	218.164 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.619 MiB
✅	docker_dogstatsd_arm64	36.939 MiB
✅	dogstatsd_deb_amd64	29.847 MiB
✅	dogstatsd_deb_arm64	28.000 MiB
✅	dogstatsd_rpm_amd64	29.847 MiB
✅	dogstatsd_suse_amd64	29.847 MiB
✅	iot_agent_deb_amd64	43.048 MiB
✅	iot_agent_deb_arm64	40.111 MiB
✅	iot_agent_deb_armhf	40.843 MiB
✅	iot_agent_rpm_amd64	43.049 MiB
✅	iot_agent_suse_amd64	43.049 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	neutral	174.457 MiB → 177.700
✅	agent_deb_amd64_fips	neutral	165.355 MiB → 172.230
✅	agent_heroku_amd64	-2.3 KiB (0.00% reduction)	75.173 → 75.171 → 79.970
✅	agent_rpm_amd64	+9.26 KiB (0.01% increase)	176.449 → 176.458 → 180.780
✅	agent_rpm_amd64_fips	-18.74 KiB (0.01% reduction)	168.112 → 168.093 → 173.370
✅	agent_rpm_arm64	-16.55 KiB (0.01% reduction)	159.336 → 159.319 → 161.610
✅	agent_rpm_arm64_fips	-42.32 KiB (0.03% reduction)	151.409 → 151.367 → 155.910
✅	agent_suse_amd64	+9.26 KiB (0.01% increase)	176.449 → 176.458 → 180.780
✅	agent_suse_amd64_fips	-18.74 KiB (0.01% reduction)	168.112 → 168.093 → 173.370
✅	agent_suse_arm64	-16.55 KiB (0.01% reduction)	159.336 → 159.319 → 161.610
✅	agent_suse_arm64_fips	-42.32 KiB (0.03% reduction)	151.409 → 151.367 → 155.910
✅	docker_agent_amd64	+2.01 KiB (0.00% increase)	267.108 → 267.110 → 271.240
✅	docker_agent_arm64	neutral	254.420 MiB → 259.800
✅	docker_agent_jmx_amd64	neutral	335.766 MiB → 339.870
✅	docker_agent_jmx_arm64	neutral	319.055 MiB → 324.390
✅	docker_cluster_agent_amd64	neutral	71.276 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	66.918 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	14.944 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.274 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.884 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.769 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.895 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.895 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.348 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.659 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.890 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.366 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.366 MiB → 12.060

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 414e644f-20f3-49d6-befb-e2c430622a97

Baseline: 9ebd458
Comparison: 322e127
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+5.36	[+2.27, +8.45]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	docker_containers_cpu	% cpu utilization	+5.36	[+2.27, +8.45]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.60	[+0.47, +0.74]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.38	[+0.31, +0.44]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.26	[+0.09, +0.42]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.24	[+0.20, +0.28]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.19	[+0.09, +0.30]	1	Logs
➖	file_tree	memory utilization	+0.11	[+0.06, +0.16]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.10	[-0.29, +0.48]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.42, +0.49]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.02	[-0.17, +0.20]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.06, +0.09]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.18, +0.19]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.43, +0.44]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.09, +0.09]	1	Logs
➖	quality_gate_idle	memory utilization	-0.02	[-0.06, +0.03]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.06	[-1.63, +1.51]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.08	[-0.31, +0.15]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.09	[-0.26, +0.07]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.13	[-0.36, +0.11]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.35	[-0.43, -0.28]	1	Logs
➖	ddot_metrics	memory utilization	-0.42	[-0.59, -0.25]	1	Logs
➖	ddot_logs	memory utilization	-0.47	[-0.55, -0.39]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.47	[-0.61, -0.33]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	692 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	274.08MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	705 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	173.34MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.18MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	204.70MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	346.44 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	417.12MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.