use synced aptly

[brycekahle]

What does this PR do?

Uses a synced version of github.com/DataDog/aptly that does not have the module renamed, so we use a replace directive in go.mod.

Motivation

Our renamed fork was pretty outdated. This will make it easier to keep synced with upstream.

Describe how you validated your changes

KMT tests.

Additional Notes

[dd-octo-sts]

Go Package Import Differences

Baseline: 6ea347c
Comparison: ae90f72

binary	os	arch	change
system-probe	linux	amd64	+15, -7 +cloud.google.com/go/compute/metadata -github.com/DataDog/aptly/aptly -github.com/DataDog/aptly/database -github.com/DataDog/aptly/deb -github.com/DataDog/aptly/http -github.com/DataDog/aptly/pgp -github.com/DataDog/aptly/utils +github.com/aptly-dev/aptly/aptly +github.com/aptly-dev/aptly/database +github.com/aptly-dev/aptly/deb +github.com/aptly-dev/aptly/http +github.com/aptly-dev/aptly/pgp +github.com/aptly-dev/aptly/utils -github.com/pborman/uuid +github.com/saracen/walker +golang.org/x/oauth2 +golang.org/x/oauth2/authhandler +golang.org/x/oauth2/google +golang.org/x/oauth2/google/externalaccount +golang.org/x/oauth2/internal +golang.org/x/oauth2/jws +golang.org/x/oauth2/jwt
system-probe	linux	arm64	+15, -7 +cloud.google.com/go/compute/metadata -github.com/DataDog/aptly/aptly -github.com/DataDog/aptly/database -github.com/DataDog/aptly/deb -github.com/DataDog/aptly/http -github.com/DataDog/aptly/pgp -github.com/DataDog/aptly/utils +github.com/aptly-dev/aptly/aptly +github.com/aptly-dev/aptly/database +github.com/aptly-dev/aptly/deb +github.com/aptly-dev/aptly/http +github.com/aptly-dev/aptly/pgp +github.com/aptly-dev/aptly/utils -github.com/pborman/uuid +github.com/saracen/walker +golang.org/x/oauth2 +golang.org/x/oauth2/authhandler +golang.org/x/oauth2/google +golang.org/x/oauth2/google/externalaccount +golang.org/x/oauth2/internal +golang.org/x/oauth2/jws +golang.org/x/oauth2/jwt

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 6ea347c4:

Results for datadog-agent_7.80.0~devel.git.807.ae90f72.pipeline.113262049-1_amd64.deb:

No change detected

[datadog-datadog-prod-us1-2]

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 50.30% (+0.01%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ae90f72 | Docs | Datadog PR Page | Give us feedback!}

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b344ad33-3466-4a47-8742-a5cd2a4f456a

Baseline: 2733956
Comparison: ae90f72
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.47	[+0.32, +6.63]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.47	[+0.32, +6.63]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.90	[+0.70, +1.09]	1	Logs
➖	docker_containers_memory	memory utilization	+0.81	[+0.67, +0.95]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.70	[+0.60, +0.80]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.53	[+0.49, +0.57]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.37	[+0.17, +0.57]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.34	[+0.16, +0.52]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.29	[+0.14, +0.45]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.07	[-0.34, +0.48]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.04	[-0.42, +0.49]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.03	[-0.46, +0.52]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.01	[-0.04, +0.05]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.08, +0.08]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.21, +0.20]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.21, +0.19]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.09	[-0.21, +0.02]	1	Logs
➖	quality_gate_idle	memory utilization	-0.10	[-0.15, -0.05]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.21	[-0.27, -0.15]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.31	[-0.47, -0.14]	1	Logs
➖	file_tree	memory utilization	-0.44	[-0.50, -0.39]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.68	[-0.91, -0.44]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.01	[-1.26, -0.76]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-1.79	[-2.77, -0.81]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	434 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	248.18MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	697 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
❌	file_to_blackhole_0ms_latency	missed_bytes	9/10	500MiB > 0MiB
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
❌	file_to_blackhole_1000ms_latency	missed_bytes	8/10	201MiB > 0MiB
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	145.17MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	480.92MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	175.40MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	335.82 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	369.13MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6ea347c
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+237.38 KiB (0.03% increase)	743.919 → 744.151 → 750.800
✅	agent_deb_amd64_fips	+233.38 KiB (0.03% increase)	701.950 → 702.178 → 703.150
✅	agent_rpm_amd64	+237.38 KiB (0.03% increase)	743.903 → 744.135 → 750.770
✅	agent_rpm_amd64_fips	+233.38 KiB (0.03% increase)	701.934 → 702.162 → 703.130
✅	agent_rpm_arm64	+217.35 KiB (0.03% increase)	721.610 → 721.822 → 724.500
✅	agent_rpm_arm64_fips	+217.38 KiB (0.03% increase)	682.760 → 682.972 → 684.870
✅	agent_suse_amd64	+237.38 KiB (0.03% increase)	743.903 → 744.135 → 750.770
✅	agent_suse_amd64_fips	+233.38 KiB (0.03% increase)	701.934 → 702.162 → 703.130
✅	agent_suse_arm64	+217.35 KiB (0.03% increase)	721.610 → 721.822 → 724.500
✅	agent_suse_arm64_fips	+217.38 KiB (0.03% increase)	682.760 → 682.972 → 684.870
✅	docker_agent_amd64	+237.38 KiB (0.03% increase)	804.065 → 804.296 → 806.340
✅	docker_agent_arm64	+217.35 KiB (0.03% increase)	806.585 → 806.797 → 810.120
✅	docker_agent_jmx_amd64	+237.38 KiB (0.02% increase)	994.984 → 995.216 → 997.060
✅	docker_agent_jmx_arm64	+217.35 KiB (0.02% increase)	986.283 → 986.496 → 989.800

19 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_heroku_amd64	309.977 MiB
✅	agent_msi	609.479 MiB
✅	docker_cluster_agent_amd64	206.841 MiB
✅	docker_cluster_agent_arm64	220.826 MiB
✅	docker_cws_instrumentation_amd64	7.154 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.503 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	docker_host_profiler_amd64	302.255 MiB
✅	docker_host_profiler_arm64	313.760 MiB
✅	dogstatsd_deb_amd64	30.162 MiB
✅	dogstatsd_deb_arm64	28.284 MiB
✅	dogstatsd_rpm_amd64	30.162 MiB
✅	dogstatsd_suse_amd64	30.162 MiB
✅	iot_agent_deb_amd64	44.389 MiB
✅	iot_agent_deb_arm64	41.358 MiB
✅	iot_agent_deb_armhf	42.067 MiB
✅	iot_agent_rpm_amd64	44.389 MiB
✅	iot_agent_suse_amd64	44.389 MiB