Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omnibus/Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source 'https://rubygems.org'

# Install omnibus
gem 'chef-sugar', git: 'https://github.com/chef/chef-sugar.git', tag: 'v3.6.0'
gem 'chef-sugar', git: 'https://github.com/chef/chef-sugar.git', tag: 'v5.1.12'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep chef-sugar within omnibus-ruby's constraint

The default Omnibus dependency here is still DataDog/omnibus-ruby at datadog-5.5.0, whose gemspec declares chef-sugar, ~> 3.3; pinning the top-level bundle to the git tag whose gem version is 5.1.12 makes Bundler unable to resolve the Omnibus bundle. Since tasks/omnibus.py removes Gemfile.lock and runs bundle install before invoking bundle exec omnibus, the Linux/macOS/Windows packaging jobs that use this Gemfile will fail before the build starts unless the omnibus-ruby ref is updated to allow chef-sugar 5.x.

Useful? React with 👍 / 👎.

gem 'omnibus', git: 'https://github.com/DataDog/omnibus-ruby.git', ref: (ENV['OMNIBUS_RUBY_VERSION'] || 'datadog-5.5.0')

gem 'mixlib-cli', '~> 2.1.0'
Loading