[Backport 7.79.x] Track evictions in VPA

[dd-octo-sts]

Backport a1c2641 from #51127.

---

What does this PR do?

Introduces eviction tracking inside PodAutoscalerInternal and prevents resubmitting eviction requests for pods that already have evictions in-flight. This should not change when pods are marked for eviction vs patching.

Motivation

So that we can submit exactly one (successful) eviction request to the API server per pod that needs it, and improve the vertical_inplace.eviction metric.

Describe how you validated your changes

Created a kind cluster with workload to be vertically autoscaled and 6 replicas. Saw that the submitted metric points sum to 6:

Additional Notes

[datadog-datadog-prod-us1]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-agent | oracle: [21.3.0-xe]     

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.

Failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a0099b2 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 89c3ee00:

Results for datadog-agent_7.79.2~rc.1.git.1.a0099b2.pipeline.116399541-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ed395873-d682-45d7-9193-c16c44d2bafc

Baseline: 89c3ee0
Comparison: a0099b2
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.15	[-5.08, +0.78]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+0.48	[+0.44, +0.52]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.30	[+0.20, +0.40]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.30	[+0.15, +0.45]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.27	[+0.08, +0.46]	1	Logs
➖	file_tree	memory utilization	+0.22	[+0.16, +0.28]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.20	[-0.02, +0.43]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.13	[+0.07, +0.19]	1	Logs
➖	ddot_logs	memory utilization	+0.10	[+0.05, +0.16]	1	Logs
➖	docker_containers_memory	memory utilization	+0.09	[+0.01, +0.18]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.05, +0.11]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.21, +0.20]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.10, +0.09]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.21, +0.20]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.47, +0.39]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.07	[-0.58, +0.44]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.12	[-0.51, +0.27]	1	Logs
➖	quality_gate_idle	memory utilization	-0.14	[-0.20, -0.09]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.21	[-0.39, -0.03]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.50	[-0.65, -0.35]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.93	[-2.16, -1.70]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-2.15	[-5.08, +0.78]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-2.25	[-2.44, -2.06]	1	Logs
➖	quality_gate_logs	% cpu utilization	-3.90	[-5.49, -2.32]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	710 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	276.53MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	697 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.24GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	175.19MiB ≤ 181MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	507.51MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	207.41MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	366.72 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	405.70MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

[avonengel]

closing as outdated, as we will not release new 7.79.x versions