-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(dbm): add 'agent integration setup postgres' CLI command #51751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sangeetashivaji
wants to merge
11
commits into
main
Choose a base branch
from
sangeeta/dbm-setup-cli-postgres
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
befc375
feat(dbm): add 'agent db setup postgres' CLI command
sangeetashivaji 18e7c0f
refactor(dbm): move 'db setup postgres' under 'agent integration setu…
sangeetashivaji 0e48c1b
chore: fix Python lint and add release note for integration setup pos…
sangeetashivaji 4f0af9b
fix: ship postgres_setup.py with agent assets and fix script lookup path
sangeetashivaji a96eba2
Merge branch 'main' into sangeeta/dbm-setup-cli-postgres
sangeetashivaji bc5c2ea
refactor(dbm): use integration's configure_connection instead of mirr…
sangeetashivaji f042e91
Tunnel integration setup to the Postgres integration's setup module
sangeetashivaji a90ce41
Merge remote-tracking branch 'origin/main' into sangeeta/dbm-setup-cl…
sangeetashivaji b8e2672
Add unit tests for the integration setup CLI's Go plumbing
sangeetashivaji e00dd28
Fix CI build failures: regenerate Bazel BUILD files and lint issues
sangeetashivaji 42d6686
Merge remote-tracking branch 'origin/main' into sangeeta/dbm-setup-cl…
sangeetashivaji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| """DBM setup script assets.""" | ||
|
|
||
| load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_files", "strip_prefix") | ||
|
|
||
| pkg_files( | ||
| name = "python_files", | ||
| srcs = glob( | ||
| ["**"], | ||
| exclude = ["BUILD.bazel"], | ||
| ), | ||
| attributes = pkg_attributes(mode = "0644"), | ||
| prefix = "bin/agent/dist/setup", | ||
| strip_prefix = strip_prefix.from_pkg(), | ||
| visibility = ["//cmd/agent/dist:__pkg__"], | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Bazel review guideline for this repo forbids recursive
glob(["**"])patterns because they silently skip files under future subpackages and hurt incremental/remote-cache behavior. This package currently only shipspostgres_setup.py, so listing that file explicitly keeps the package hermetic and avoids the recursive-glob trap.Useful? React with 👍 / 👎.