Skip to content
Draft
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/agent/dist/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ pkg_filegroup(
":python_files",
"//cmd/agent/dist/checks:python_files",
"//cmd/agent/dist/utils:python_files",
"//cmd/agent/dist/setup:python_files",
],
visibility = [
"//cmd/agent:__subpackages__",
Expand Down
15 changes: 15 additions & 0 deletions cmd/agent/dist/setup/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
"""DBM setup script assets."""

load("@rules_pkg//pkg:mappings.bzl", "pkg_attributes", "pkg_files", "strip_prefix")

pkg_files(
name = "python_files",
srcs = glob(
["**"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Avoid a recursive glob in the new package

The Bazel review guideline for this repo forbids recursive glob(["**"]) patterns because they silently skip files under future subpackages and hurt incremental/remote-cache behavior. This package currently only ships postgres_setup.py, so listing that file explicitly keeps the package hermetic and avoids the recursive-glob trap.

Useful? React with 👍 / 👎.

exclude = ["BUILD.bazel"],
),
attributes = pkg_attributes(mode = "0644"),
prefix = "bin/agent/dist/setup",
strip_prefix = strip_prefix.from_pkg(),
visibility = ["//cmd/agent/dist:__pkg__"],
)
Loading
Loading