Update module github.com/cloudfoundry-community/go-cfclient/v2 to v3 - #53622
Update module github.com/cloudfoundry-community/go-cfclient/v2 to v3#53622renovate[bot] wants to merge 2 commits into
Conversation
renovate
Bot
added
changelog/no-changelog
|
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: CI tests failed. Please fix the failing tests to continue. |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7711817f39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| github.com/clbanning/mxj/v2 v2.7.0 | ||
| github.com/cloudflare/cbpfc v0.0.0-20260219140841-0661ad29132c | ||
| github.com/cloudfoundry-community/go-cfclient/v2 v2.0.1-0.20230503155151-3d15366c5820 | ||
| github.com/cloudfoundry-community/go-cfclient/v3 v3.0.0-alpha.21 |
There was a problem hiding this comment.
This swaps the required module to /v3, but the Cloud Foundry code still imports github.com/cloudfoundry-community/go-cfclient/v2 in cmd/cluster-agent-cloudfoundry/subcommands/run/command.go and pkg/util/cloudproviders/cloudfoundry/*.go, and the Bazel deps still point at com_github_cloudfoundry_community_go_cfclient_v2. Because Go treats /v2 and /v3 as distinct modules, the affected Cloud Foundry packages will still need the old module while this PR adds an unused v3 requirement; please either keep the v2 requirement or update the imports, Bazel module/deps, and sums together.
Useful? React with 👍 / 👎.
7711817 to
5fb7ecb
Compare
Go Package Import DifferencesBaseline: 8691556
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: 63145d5 | Docs | Datadog PR Page | Give us feedback! |
Files inventory check summaryFile checks results against ancestor 86915561: Results for datadog-agent_7.83.0~devel.git.188.63145d5.pipeline.125218081-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3e31e7b Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.82 | [+1.80, +3.83] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_idle | memory utilization | +0.49 | [+0.43, +0.56] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.00 | [-0.25, +0.25] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_no_fs_load | memory utilization | -0.01 | [-0.11, +0.09] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.17 | [-0.22, -0.12] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_mean_fs_load | memory utilization | -0.36 | [-0.41, -0.32] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.38 | [-0.46, -0.30] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 145.92MiB ≤ 154MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 736.22KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ❌ | quality_gate_idle_all_features | memory_usage | 9/10 | 497.70MiB > 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.12MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 180.85MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.51MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 383.73 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 408.29MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
| ✅ | quality_gate_security_idle | cpu_usage | 10/10 | 29.46 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_idle | memory_usage | 10/10 | 300.63MiB ≤ 330MiB | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | cpu_usage | 10/10 | 61.89 ≤ 200 | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | memory_usage | 10/10 | 277.16MiB ≤ 310MiB | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | cpu_usage | 10/10 | 21.71 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | memory_usage | 10/10 | 285.15MiB ≤ 320MiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (ddprof)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_security_idle | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_idle | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_mean_fs_load | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_mean_fs_load | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_no_fs_load | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_no_fs_load | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
- quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
32 successful checks with minimal change (< 2 KiB)
|
d44189c to
f848e0f
Compare
github-actions
Bot
added
long review
5d2b595 to
2adda56
Compare
2adda56 to
5d31a3b
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
regis.desgroppes@datadoghq.com unqueued this merge request |
migrate the Cloud Foundry client code from v2 to v3. Renovate proposed github.com/cloudfoundry-community/go-cfclient/v3, but that module's own go.mod declares its path as github.com/cloudfoundry/go-cfclient/v3 (the project moved orgs), which made the dependency unresolvable and broke all CI on the PR. Ports pkg/util/cloudproviders/cloudfoundry and cmd/cluster-agent-cloudfoundry to the v3 API: client/config/resource package split, functional-options config construction, pointer-based Metadata and typed Relationships, and native paginated sub-clients replacing the old hand-rolled raw-HTTP pagination code.
5d31a3b to
63145d5
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
regis.desgroppes@datadoghq.com unqueued this merge request |
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
1 participant
This PR contains the following updates:
v2.0.1-0.20230503155151-3d15366c5820→v3.0.0-beta.1Release Notes
cloudfoundry/go-cfclient (github.com/cloudfoundry/go-cfclient/v3)
v3.0.0-beta.1Compare Source
This is the first non-alpha release.
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.21...v3.0.0-beta.1
v3.0.0-alpha.21Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.20...v3.0.0-alpha.21
v3.0.0-alpha.20Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.19...v3.0.0-alpha.20
v3.0.0-alpha.19Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.18...v3.0.0-alpha.19
v3.0.0-alpha.18Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.17...v3.0.0-alpha.18
v3.0.0-alpha.17Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.16...v3.0.0-alpha.17
v3.0.0-alpha.16Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.15...v3.0.0-alpha.16
v3.0.0-alpha.15Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.14...v3.0.0-alpha.15
v3.0.0-alpha.14Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.13...v3.0.0-alpha.14
v3.0.0-alpha.13Compare Source
What's Changed
New Contributors
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.12...v3.0.0-alpha.13
v3.0.0-alpha.12Compare Source
What's Changed
New Contributors
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.11...v3.0.0-alpha.12
v3.0.0-alpha.11Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.10...v3.0.0-alpha.11
v3.0.0-alpha.10Compare Source
What's Changed
cpu_entitlementandlog_ratefields toProcessStat.relationships.current_dropletto app resource.New Contributors
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.9...v3.0.0-alpha.10
v3.0.0-alpha.9Compare Source
What's Changed
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.8...v3.0.0-alpha.9
v3.0.0-alpha.8Compare Source
What's Changed
New Contributors
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.7...v3.0.0-alpha.8
v3.0.0-alpha.7: v3.0.0 alpha 7Compare Source
Moved to cloudfoundry org and changed the way config is constructed to use the more typical Golang functional options pattern.
What's Changed
New Contributors
Full Changelog: cloudfoundry/go-cfclient@v3.0.0-alpha.6...v3.0.0-alpha.7
v3.0.0-alpha.6: v3.0.0 alpha 6Compare Source
Fix multiple issues around oauth token renewals, especially for long lived processes and some additional features.
v3.0.0-alpha.5: v3.0.0 alpha 5Compare Source
v3.0.0-alpha.4: v3.0.0 alpha 4Compare Source
v3.0.0-alpha.3: v3.0.0 alpha 3Compare Source
Add missing SyslogDrainURL and RouteServiceURL properties to ServiceInstance
v3.0.0-alpha.2: v3.0.0 alpha 2Compare Source
Add some missing security group bind/unbind functionality and ability to get raw access token
Configuration
📅 Schedule: (in timezone Europe/Paris)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.