Update module github.com/twmb/franz-go/pkg/kmsg to v2 - #53824
Update module github.com/twmb/franz-go/pkg/kmsg to v2#53824renovate[bot] wants to merge 2 commits into
Conversation
renovate
Bot
added
changelog/no-changelog
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 743bd7da67
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| github.com/twmb/franz-go v1.21.5 | ||
| github.com/twmb/franz-go/pkg/kadm v1.18.0 | ||
| github.com/twmb/franz-go/pkg/kmsg v1.13.1 | ||
| github.com/twmb/franz-go/pkg/kmsg/v2 v2.0.1 |
There was a problem hiding this comment.
This line switches the requirement to github.com/twmb/franz-go/pkg/kmsg/v2, but the repo still imports the v1 path (pkg/network/usm/kafka_monitor_test.go) and Bazel still references @com_github_twmb_franz_go_pkg_kmsg. In any linux_bpf Kafka test/build or tidy check, this leaves the actual imported module out of sync while adding an unused v2 module, so dda inv tidy/dependency checks will revert this rather than validate the upgrade. Please update the imports/Bazel dependency to /v2 as part of the upgrade, or keep the v1 requirement.
Useful? React with 👍 / 👎.
This commit was created from the local commit with hash 440ebed80c2444ca0c524cec15b06e2b00774a80.
Files inventory check summaryFile checks results against ancestor 3114c9b7: Results for datadog-agent_7.83.0~devel.git.206.3ffcf42.pipeline.125579922-1_amd64.deb:No change detected |
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
regis.desgroppes@datadoghq.com cancelled this merge request build |
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
1 participant
This PR contains the following updates:
v1.13.1→v2.0.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (in timezone Europe/Paris)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.