Skip to content

Update module go.etcd.io/etcd/client/v2 to v3 #53825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 2 commits into from
Closed

Update module go.etcd.io/etcd/client/v2 to v3 #53825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864e19c
Update module go.etcd.io/etcd/client/v2 to v3
renovate[bot] Jul 20, 2026
e1cb429
[renovate skip] Auto-generate go.sum and LICENSE-3rdparty.csv changes
dd-octo-sts[bot] Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comp/core/autodiscovery/providers/etcd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"strings"
"time"

"go.etcd.io/etcd/client/v2"
"go.etcd.io/etcd/client/v3"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the v2 etcd client import

When building the Agent with its normal tags (tasks/build_tags.bzl:102-110 includes etcd in AGENT_TAGS), this provider still uses the legacy v2 Keys API (client.GetOptions{Recursive: true}, client.Response/Node, client.NewKeysAPI, ModifiedIndex). The replacement package go.etcd.io/etcd/client/v3 is the clientv3 gRPC KV client and does not provide those types/functions, so this import leaves the etcd-tagged provider uncompilable until the implementation is rewritten for v3 or the v2 module is retained.

Useful? React with 👍 / 👎.


"github.com/DataDog/datadog-agent/comp/core/autodiscovery/common/utils"
"github.com/DataDog/datadog-agent/comp/core/autodiscovery/integration"
Expand Down
2 changes: 1 addition & 1 deletion comp/core/autodiscovery/providers/etcd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"go.etcd.io/etcd/client/v2"
"go.etcd.io/etcd/client/v3"
)

type etcdTest struct {
Expand Down
7 changes: 3 additions & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ require (
github.com/yusufpapurcu/wmi v1.2.4
gitlab.com/gitlab-org/api/client-go v1.46.0
go.etcd.io/bbolt v1.5.0
go.etcd.io/etcd/client/v2 v2.305.32
go.etcd.io/etcd/client/v3 v3.7.0
go.mongodb.org/mongo-driver/v2 v2.8.0
go.opentelemetry.io/collector/component v1.62.0
go.opentelemetry.io/collector/component/componentstatus v0.156.0
Expand Down Expand Up @@ -1052,9 +1052,8 @@ require (
github.com/youmark/pkcs8 v0.0.0-20240726163527-a2c0da244d78 // indirect
github.com/zeebo/xxh3 v1.1.0 // indirect
github.com/zorkian/go-datadog-api v2.30.0+incompatible // indirect
go.etcd.io/etcd/api/v3 v3.6.11 // indirect
go.etcd.io/etcd/client/pkg/v3 v3.6.11 // indirect
go.etcd.io/etcd/client/v3 v3.6.11 // indirect
go.etcd.io/etcd/api/v3 v3.7.0 // indirect
go.etcd.io/etcd/client/pkg/v3 v3.7.0 // indirect
go.mongodb.org/mongo-driver v1.17.9 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
Expand Down
14 changes: 6 additions & 8 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading