Skip to content

[DSEC-140] rustchecks: support sending event platform events as bytes#54089

Open
aimenebelfodil wants to merge 2 commits into
mainfrom
aimene.belfodil/dsec-140/add-sdsresult-protobuf-part-2
Open

[DSEC-140] rustchecks: support sending event platform events as bytes#54089
aimenebelfodil wants to merge 2 commits into
mainfrom
aimene.belfodil/dsec-140/add-sdsresult-protobuf-part-2

Conversation

@aimenebelfodil

@aimenebelfodil aimenebelfodil commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds event_platform_event_bytes (and the underlying submit_event_platform_event_bytes) to the shared-library (Rust) check core, so checks can submit event platform events as raw bytes — not just UTF-8 strings.

Motivation

The datasecurity check will emit its sds-result payload as protobuf; the existing string-based API cannot carry binary data (protobuf bytes may contain interior NULs).

Guard / memory safety

The bytes path intentionally does not wrap raw_event in a CStringGuard:

  • it is a borrowed slice (nothing is allocated here), and the Go callback copies it synchronously via C.GoBytes, so there is nothing to free;
  • a CString could not hold it, since protobuf bytes may contain interior NULs.

Describe how you validated your changes

That the bytes are transmitted correctly and received/handled properly by the Datadog platform is validated end-to-end in a subsequent PR.

Made with Cursor

@aimenebelfodil
aimenebelfodil requested a review from a team as a code owner July 24, 2026 10:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d9521eba6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

self.aggregator.submit_event_platform_event_bytes(
&self.check_id,
raw_event,
raw_event.len() as c_int,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject oversized byte events before the FFI call

When a Rust check builds a binary payload larger than c_int::MAX, this unchecked cast wraps or truncates the byte length before it reaches the C/Go callback. The Go side uses that value as the length passed to C.GoBytes, so an oversized protobuf event can be copied with the wrong length or fail instead of returning a clean Rust error; the Python binding for the same callback has an INT_MAX guard before crossing this boundary. Please use a checked conversion and return the error before invoking the callback.

Useful? React with 👍 / 👎.

@aimenebelfodil aimenebelfodil Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the same pattern as the other method
This could however be refined later (not scoped only to this added method)

@github-actions github-actions Bot added short review PR is simple enough to be reviewed quickly medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jul 24, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 52.06% (+0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b39337e | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 3b9e745b:

Results for datadog-agent_7.83.0~devel.git.371.b39337e.pipeline.126759822-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3b9e745
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 751.814 MiB
agent_deb_amd64_fips 706.583 MiB
agent_heroku_amd64 308.029 MiB
agent_rpm_amd64 751.798 MiB
agent_rpm_amd64_fips 706.566 MiB
agent_rpm_arm64 728.407 MiB
agent_rpm_arm64_fips 686.330 MiB
agent_suse_amd64 751.798 MiB
agent_suse_amd64_fips 706.566 MiB
agent_suse_arm64 728.407 MiB
agent_suse_arm64_fips 686.330 MiB
docker_agent_amd64 810.482 MiB
docker_agent_arm64 812.142 MiB
docker_agent_jmx_amd64 1001.379 MiB
docker_agent_jmx_arm64 991.692 MiB
docker_cluster_agent_amd64 209.866 MiB
docker_cluster_agent_arm64 222.953 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.243 MiB
docker_dogstatsd_arm64 37.368 MiB
docker_host_profiler_amd64 305.005 MiB
docker_host_profiler_arm64 316.331 MiB
dogstatsd_deb_amd64 29.984 MiB
dogstatsd_deb_arm64 28.024 MiB
dogstatsd_rpm_amd64 29.984 MiB
dogstatsd_suse_amd64 29.984 MiB
iot_agent_deb_amd64 46.153 MiB
iot_agent_deb_arm64 42.849 MiB
iot_agent_deb_armhf 43.613 MiB
iot_agent_rpm_amd64 46.154 MiB
iot_agent_suse_amd64 46.153 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 24, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0be6146e-7028-4d5d-9af1-fd1b3c442b48

Baseline: 5747aad
Comparison: b39337e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_idle memory utilization +0.41 [+0.35, +0.47] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.23 [-0.01, +0.48] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.21 [+0.17, +0.26] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.14 [+0.02, +0.26] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.03 [-0.06, +0.12] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.09 [-0.13, -0.06] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.37 [-0.42, -0.32] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.43 [-2.40, -0.45] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.71MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 732.61KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 503.06MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 186.07MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.17MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 373.42 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 404.30MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.55MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.79 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 302.15MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.93 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 281.12MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.88 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 290.07MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Base automatically changed from aimene.belfodil/dsec-140/add-sdsresult-protobuf-part-1 to main July 24, 2026 11:35
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot requested review from a team as code owners July 24, 2026 11:35
@aimenebelfodil
aimenebelfodil force-pushed the aimene.belfodil/dsec-140/add-sdsresult-protobuf-part-2 branch from 7d9521e to b39337e Compare July 24, 2026 11:58
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-runtimes labels Jul 24, 2026
@aimenebelfodil aimenebelfodil added the qa/done QA done before merge and regressions are covered by tests label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants