-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[DSEC-140] config: wire the sds-result event platform track gated behind data_security.enabled #54091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: aimene.belfodil/dsec-140/add-sdsresult-protobuf-part-2
Are you sure you want to change the base?
[DSEC-140] config: wire the sds-result event platform track gated behind data_security.enabled #54091
Changes from all commits
79ca596
d18cc3d
68c7f42
074d6d0
7c6f849
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Unless explicitly stated otherwise all files in this repository are licensed | ||
| // under the Apache License Version 2.0. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016-present Datadog, Inc. | ||
|
|
||
| package eventplatformimpl | ||
|
|
||
| import ( | ||
| eventplatform "github.com/DataDog/datadog-agent/comp/forwarder/eventplatform/def" | ||
| logshttp "github.com/DataDog/datadog-agent/comp/logs-library/client/http" | ||
| pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup" | ||
| ) | ||
|
|
||
| func getDataSecurityPipelines() []passthroughPipelineDesc { | ||
| return []passthroughPipelineDesc{ | ||
| { | ||
| eventType: eventplatform.EventTypeSDSResult, | ||
| category: "Data Security", | ||
| contentType: logshttp.ProtobufContentType, | ||
| endpointsConfigPrefix: "sds_result.forwarder.", | ||
| hostnameEndpointPrefix: "sds-intake.", | ||
| intakeTrackType: "sdsresult", | ||
| defaultBatchMaxConcurrentSend: 10, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a default value for this? If not, would it be possible to detail why 10 has been selected here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inspiration took it over for now. DO/Datastream/DBM/.... are using the same value (not using a constant) There is a constant // DefaultBatchMaxConcurrentSend is the default HTTP batch max concurrent send for logs
DefaultBatchMaxConcurrentSend = 0Other folks seem to not use it as it is stated that this one is for logs (I assume that 0 means a specific behavior) TLDR; passthroughPipelineDesc is mirroring other alike configs |
||
| defaultBatchMaxContentSize: pkgconfigsetup.DefaultBatchMaxContentSize, | ||
| defaultBatchMaxSize: pkgconfigsetup.DefaultBatchMaxSize, | ||
| defaultInputChanSize: pkgconfigsetup.DefaultInputChanSize, | ||
| }, | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7308,6 +7308,17 @@ properties: | |
| default: true | ||
| tags: | ||
| - full-agent-only:true | ||
| data_security: | ||
| node_type: section | ||
| type: object | ||
| properties: | ||
| enabled: | ||
| node_type: setting | ||
| type: boolean | ||
| default: false | ||
| comment: |- | ||
| Data Security: single enablement flag gating both the autodiscovery provider | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this flag work for both autodiscovery or just the sds-result pipeline now>
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The autodiscovery part is not coded yet and is currently cooking (cf. Task https://datadoghq.atlassian.net/browse/DSEC-79) |
||
| and the sds-result event platform pipeline. | ||
| data_streams: | ||
| node_type: section | ||
| type: object | ||
|
|
@@ -9689,6 +9700,110 @@ properties: | |
| default: ${run_path} | ||
| runtime_security_config: | ||
| $ref: runtime_security_config.yaml | ||
| sds_result: | ||
| node_type: section | ||
| type: object | ||
| properties: | ||
| forwarder: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it required to add a section for the "forwarder"? Is there a way for users to update all forwarders without updating each specific "product config" (here
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is generated based on this. Command
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe that generally people use the default configs. |
||
| node_type: section | ||
| type: object | ||
| properties: | ||
| additional_endpoints: | ||
| node_type: setting | ||
| type: array | ||
| default: [] | ||
| items: | ||
| type: object | ||
| batch_max_concurrent_send: | ||
| node_type: setting | ||
| type: integer | ||
| default: 0 | ||
| batch_max_content_size: | ||
| node_type: setting | ||
| type: integer | ||
| default: 5000000 | ||
| batch_max_size: | ||
| node_type: setting | ||
| type: integer | ||
| default: 1000 | ||
| batch_wait: | ||
| node_type: setting | ||
| type: number | ||
| default: 5 | ||
| tags: | ||
| - golang_type:float64 | ||
| compression_kind: | ||
| node_type: setting | ||
| type: string | ||
| default: zstd | ||
| compression_level: | ||
| node_type: setting | ||
| type: integer | ||
| default: 6 | ||
| connection_reset_interval: | ||
| node_type: setting | ||
| type: integer | ||
| default: 0 | ||
| dd_url: | ||
| node_type: setting | ||
| type: string | ||
| default: '' | ||
| dev_mode_no_ssl: | ||
| node_type: setting | ||
| type: boolean | ||
| default: false | ||
| tags: | ||
| - no-env | ||
| input_chan_size: | ||
| node_type: setting | ||
| type: integer | ||
| default: 100 | ||
| logs_dd_url: | ||
| node_type: setting | ||
| type: string | ||
| default: '' | ||
| logs_no_ssl: | ||
| node_type: setting | ||
| type: boolean | ||
| default: false | ||
| sender_backoff_base: | ||
| node_type: setting | ||
| type: number | ||
| default: 1 | ||
| tags: | ||
| - golang_type:float64 | ||
| sender_backoff_factor: | ||
| node_type: setting | ||
| type: number | ||
| default: 2 | ||
| tags: | ||
| - golang_type:float64 | ||
| sender_backoff_max: | ||
| node_type: setting | ||
| type: number | ||
| default: 120 | ||
| tags: | ||
| - golang_type:float64 | ||
| sender_recovery_interval: | ||
| node_type: setting | ||
| type: integer | ||
| default: 2 | ||
| sender_recovery_reset: | ||
| node_type: setting | ||
| type: boolean | ||
| default: false | ||
| use_compression: | ||
| node_type: setting | ||
| type: boolean | ||
| default: true | ||
| use_v2_api: | ||
| node_type: setting | ||
| type: boolean | ||
| default: true | ||
| zstd_compression_level: | ||
| node_type: setting | ||
| type: integer | ||
| default: 1 | ||
| secret_audit_file_max_size: | ||
| node_type: setting | ||
| type: integer | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| features: | ||
| - | | ||
| Added the ``data_security.enabled`` configuration flag (disabled by | ||
| default) which enables the ``sds-result`` event platform forwarder used to | ||
| send sensitive-data-scanner results to Datadog. |
Uh oh!
There was an error while loading. Please reload this page.