Bazelify gotestsum usage across the repo

[rdesgroppes]

What does this PR do?

Route gotestsum through Bazel wherever it was invoked via go install, $GOBIN, or $GOPATH, and drop it from install-tools' TOOL_LIST.

Replace every direct gotestsum invocation with bazel run @tools_gotest_gotestsum//:gotestsum whenever possible.

Otherwise install it by leveraging:

1. platform_transition_filegroup to cross-compile it without incurring the overhead of a full platform transition (for which some Bazel rules are not suited¹),
2. pkg_install for copying it out of the sandbox.

Together, both of the above provide a flawless² alternative in runtime environments where Bazel is not (yet) available.

Motivation

gotestsum's version and toolchain provenance were at best tracked by a runtime version check, and go install left it exposed to the "gotestsum not found" and wrong-arch incident class documented in prior art, leading us to land urgent PRs after incidents surfaced:

• #incident-56214,
• #incident-56215,
• #incident-56553,
• etc.

=> Bazel's hermetic build and efficient caching remove the failure mode at the source instead of patching around it again.

Describe how you validated your changes

dda inv test ran end to end through the new bazel run path: 18 tests passed with correct output and exit code.

kmt.py and system_probe.py's install paths were exercised directly, producing correct-arch binaries, verified via file(1), for host, arm64, and x86_64 targets, including the KMT cross-compile case.

Existing unit test suites, bazel_tests.py, e2e_testing_tests.py, setup_env_tests.py, and go_tests.py, pass unchanged.

Additional Notes

Footnotes

1. a bare --platforms= flag on the whole bazel run invocation doesn't just cost more, it breaks pkg_install's own launcher outright (hit this directly: a garbled venv/Python launcher, Syntax error: ')' unexpected, zero output). ↩

2. a naive bazel build followed by a copy of the resulting binary by gardening into Bazel's output is flawed: not only is the operation not atomic, but output paths collide across --platforms invocations. Also, build artifacts would get thrashed over --platforms switches. ↩

[github-actions]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f2ef16b29

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[dd-octo-sts]

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
0	172	0	0

ℹ️ Diff available in the job log.

[datadog-official]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.06% (+0.14%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 21d877d | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 052fecc6:

Results for datadog-agent_7.83.0~devel.git.389.21d877d.pipeline.126934950-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8cdd0cdd-5bdc-4b03-977e-51b295fc8b63

Baseline: 6607272
Comparison: 21d877d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.65	[+0.65, +2.64]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.53	[+0.44, +0.63]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.46	[+0.40, +0.51]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.08	[+0.04, +0.13]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.01	[-0.06, +0.04]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.06	[-0.10, -0.02]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.07	[-0.19, +0.05]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.26	[-0.51, -0.02]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	150.04MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	734.86KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	507.03MiB ≤ 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	185.55MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.16MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	353.83 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	402.76MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.08MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	30.28 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	301.29MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	63.95 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	280.83MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.75 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	286.57MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 052fecc
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	751.862 MiB
✅	agent_deb_amd64_fips	706.631 MiB
✅	agent_heroku_amd64	308.036 MiB
✅	agent_msi	640.004 MiB
✅	agent_rpm_amd64	751.846 MiB
✅	agent_rpm_amd64_fips	706.614 MiB
✅	agent_rpm_arm64	728.457 MiB
✅	agent_rpm_arm64_fips	686.377 MiB
✅	agent_suse_amd64	751.846 MiB
✅	agent_suse_amd64_fips	706.614 MiB
✅	agent_suse_arm64	728.457 MiB
✅	agent_suse_arm64_fips	686.377 MiB
✅	docker_agent_amd64	810.529 MiB
✅	docker_agent_arm64	812.193 MiB
✅	docker_agent_jmx_amd64	1001.427 MiB
✅	docker_agent_jmx_arm64	991.743 MiB
✅	docker_cluster_agent_amd64	209.866 MiB
✅	docker_cluster_agent_arm64	222.953 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.243 MiB
✅	docker_dogstatsd_arm64	37.368 MiB
✅	docker_host_profiler_amd64	305.013 MiB
✅	docker_host_profiler_arm64	316.327 MiB
✅	dogstatsd_deb_amd64	29.984 MiB
✅	dogstatsd_deb_arm64	28.024 MiB
✅	dogstatsd_rpm_amd64	29.984 MiB
✅	dogstatsd_suse_amd64	29.984 MiB
✅	iot_agent_deb_amd64	46.161 MiB
✅	iot_agent_deb_arm64	42.849 MiB
✅	iot_agent_deb_armhf	43.613 MiB
✅	iot_agent_rpm_amd64	46.162 MiB
✅	iot_agent_suse_amd64	46.161 MiB