[DSEC-212] Enable data security rust check by aimenebelfodil · Pull Request #54204 · DataDog/datadog-agent

aimenebelfodil · 2026-07-29T11:44:37Z

What does this PR do?

Ships the datasecurity Rust shared-library check by enabling it in ENABLED_CHECKS, so its cdylib is bundled with the Agent build.

Motivation

Enable the Data Security feature (RC-driven PostgreSQL scanning via the DATA_SECURITY_DB_SCAN_TASKS product) so it can be turned on with data_security.enabled + shared_library_check.enabled.

Describe how you validated your changes

The feature was already validated end-to-end in previous PRs. This PR only flips the check on for shipping.

Decision Record

https://datadoghq.atlassian.net/wiki/spaces/ABLD/pages/7034209304/Data+Security+-+Quality+Gates+Decision+Records

Note

Last commit compensate what was lost after rebasing on main (post PR merge #54419)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db784980e1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

datadog-prod-us1-4 · 2026-07-29T12:02:46Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.23% (+0.14%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 269c5d4 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-07-29T12:20:49Z

Files inventory check summary

File checks results against ancestor e531a893:

Results for datadog-agent_7.83.0~devel.git.573.269c5d4.pipeline.129028097-1_amd64.deb:

Detected file changes:

1 Added files:

etc/datadog-agent/checks.d/libdatadog-agent-datasecurity.so (3.65 MiB)

dd-octo-sts · 2026-07-29T12:26:06Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor e531a89
📊 Static Quality Gates Dashboard
🔗 SQG Job
⚠️ Exception granted by @cmourot: this PR exceeds the per-PR size thresholds but will not be blocked.

Error

	Quality gate	Change	Size (prev → curr → max)
⚠️	agent_deb_amd64 (per-PR threshold)	+3.65 MiB (0.48% increase, -41.09% of buffer)	753.989 → 757.639 → 762.870
⚠️	agent_deb_amd64_fips (per-PR threshold)	+3.65 MiB (0.52% increase, -55.81% of buffer)	707.630 → 711.280 → 714.170
⚠️	agent_heroku_amd64 (per-PR threshold)	+3.65 MiB (1.18% increase, -34.26% of buffer)	308.229 → 311.878 → 318.880
⚠️	agent_rpm_amd64 (per-PR threshold)	+3.65 MiB (0.48% increase, -41.16% of buffer)	753.973 → 757.623 → 762.840
⚠️	agent_rpm_amd64_fips (per-PR threshold)	+3.65 MiB (0.52% increase, -55.67% of buffer)	707.614 → 711.264 → 714.170
⚠️	agent_rpm_arm64 (per-PR threshold)	+3.33 MiB (0.46% increase, -93.10% of buffer)	730.394 → 733.723 → 733.970
⚠️	agent_rpm_arm64_fips (per-PR threshold)	+3.33 MiB (0.48% increase, -67.39% of buffer)	687.310 → 690.639 → 692.250
⚠️	agent_suse_amd64 (per-PR threshold)	+3.65 MiB (0.48% increase, -41.16% of buffer)	753.973 → 757.623 → 762.840
⚠️	agent_suse_amd64_fips (per-PR threshold)	+3.65 MiB (0.52% increase, -55.67% of buffer)	707.614 → 711.264 → 714.170
⚠️	agent_suse_arm64 (per-PR threshold)	+3.33 MiB (0.46% increase, -93.10% of buffer)	730.394 → 733.723 → 733.970
⚠️	agent_suse_arm64_fips (per-PR threshold)	+3.33 MiB (0.48% increase, -67.39% of buffer)	687.310 → 690.639 → 692.250
⚠️	docker_agent_amd64 (per-PR threshold)	+3.65 MiB (0.45% increase, -62.75% of buffer)	812.644 → 816.293 → 818.460
⚠️	docker_agent_arm64 (per-PR threshold)	+3.33 MiB (0.41% increase, -64.37% of buffer)	814.128 → 817.457 → 819.300
⚠️	docker_agent_jmx_amd64 (per-PR threshold)	+3.65 MiB (0.36% increase, -64.27% of buffer)	1003.541 → 1007.191 → 1009.220
⚠️	docker_agent_jmx_arm64 (per-PR threshold)	+3.33 MiB (0.34% increase, -62.79% of buffer)	993.678 → 997.007 → 998.980

Gate failure full details

Quality gate	Error type	Error message
agent_deb_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_deb_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_heroku_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_arm64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_amd64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_arm64_fips	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_jmx_amd64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.65 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_jmx_arm64	PerPRThresholdExceeded (non-blocking: exception granted by @cmourot)	On-disk size increase of 3.33 MiB exceeds the per-PR threshold of 600.0 KiB

Note: Some gates exceeded limits but are non-blocking because the size hasn't increased from the ancestor commit.

18 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_msi	639.335 MiB
✅	docker_cluster_agent_amd64	210.030 MiB
✅	docker_cluster_agent_arm64	223.077 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.312 MiB
✅	docker_dogstatsd_arm64	37.433 MiB
✅	docker_host_profiler_amd64	305.307 MiB
✅	docker_host_profiler_arm64	316.621 MiB
✅	dogstatsd_deb_amd64	30.053 MiB
✅	dogstatsd_deb_arm64	28.089 MiB
✅	dogstatsd_rpm_amd64	30.053 MiB
✅	dogstatsd_suse_amd64	30.053 MiB
✅	iot_agent_deb_amd64	46.290 MiB
✅	iot_agent_deb_arm64	42.969 MiB
✅	iot_agent_deb_armhf	43.738 MiB
✅	iot_agent_rpm_amd64	46.290 MiB
✅	iot_agent_suse_amd64	46.289 MiB

cit-pr-commenter-54b7da · 2026-07-29T12:44:44Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cee6eb67-3992-42bc-881c-4cb56f7ef791

Baseline: 24e27c3
Comparison: 805bf9c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.41	[-0.60, +1.42]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.31	[+0.26, +0.37]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.13	[-0.12, +0.37]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.11	[+0.01, +0.21]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.03	[-0.03, +0.09]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.00	[-0.04, +0.04]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.10	[-0.13, -0.06]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.21	[-0.33, -0.08]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	150.14MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	731.18KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.94MiB ≤ 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	187.19MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.20MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	390.79 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	401.79MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.91MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	28.27 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	307.04MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	70.49 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	279.07MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.23 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	287.78MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

vinckama

Based on previous discussions, it looks good to me. The review from @aiuto or @cmourot is anyway needed.

aiuto

Is there a pointer to the size increase decision?

aimenebelfodil · 2026-08-04T06:55:46Z

Just added @aiuto the link for the decision record document.

aimenebelfodil · 2026-08-04T14:16:48Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-08-04T14:16:52Z

View all feedbacks in Devflow UI.

2026-08-04 14:16:52 UTC ℹ️ Start processing command /merge

2026-08-04 14:17:01 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-08-04 14:19:36 UTC ⚠️ MergeQueue: This merge request was unqueued

aimene.belfodil@datadoghq.com unqueued this merge request

Resolved

aimenebelfodil · 2026-08-04T17:29:57Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-08-04T17:30:02Z

View all feedbacks in Devflow UI.

2026-08-04 17:30:01 UTC ℹ️ Start processing command /merge

2026-08-04 17:30:06 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).

2026-08-04 18:55:30 UTC ❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy. It's probably because:

PR is conflicting with its base branch

aimenebelfodil · 2026-08-04T19:16:18Z

I rebased due to a conflict after this PR
#54419 was merged

aimenebelfodil · 2026-08-04T20:14:27Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-08-04T20:14:31Z

View all feedbacks in Devflow UI.

2026-08-04 20:14:30 UTC ℹ️ Start processing command /merge

2026-08-04 20:14:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-08-04 20:16:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 2h (p90).

2026-08-04 22:13:39 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for e734b20:

static_quality_gates

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

aimenebelfodil · 2026-08-04T22:37:50Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-08-04T22:37:54Z

View all feedbacks in Devflow UI.

2026-08-04 22:37:53 UTC ℹ️ Start processing command /merge

2026-08-04 22:37:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-08-04 23:25:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 2h (p90).

2026-08-05 00:14:48 UTC ℹ️ MergeQueue: This merge request was merged

### What does this PR do? Ships the `datasecurity` Rust shared-library check by enabling it in `ENABLED_CHECKS`, so its cdylib is bundled with the Agent build. ### Motivation Enable the Data Security feature (RC-driven PostgreSQL scanning via the `DATA_SECURITY_DB_SCAN_TASKS` product) so it can be turned on with `data_security.enabled` + `shared_library_check.enabled`. ### Describe how you validated your changes The feature was already validated end-to-end in previous PRs. This PR only flips the check on for shipping. ### Decision Record https://datadoghq.atlassian.net/wiki/spaces/ABLD/pages/7034209304/Data+Security+-+Quality+Gates+Decision+Records ### Note Last [commit](269c5d4) compensate what was lost after rebasing on main (post PR merge #54419) Co-authored-by: aimene.belfodil <aimene.belfodil@datadoghq.com> 805bf9c

### What does this PR do? Ships the `datasecurity` Rust shared-library check by enabling it in `ENABLED_CHECKS`, so its cdylib is bundled with the Agent build. ### Motivation Enable the Data Security feature (RC-driven PostgreSQL scanning via the `DATA_SECURITY_DB_SCAN_TASKS` product) so it can be turned on with `data_security.enabled` + `shared_library_check.enabled`. ### Describe how you validated your changes The feature was already validated end-to-end in previous PRs. This PR only flips the check on for shipping. ### Decision Record https://datadoghq.atlassian.net/wiki/spaces/ABLD/pages/7034209304/Data+Security+-+Quality+Gates+Decision+Records ### Note Last [commit](DataDog@269c5d4) compensate what was lost after rebasing on main (post PR merge DataDog#54419) Co-authored-by: aimene.belfodil <aimene.belfodil@datadoghq.com> 805bf9c

### What does this PR do? Fix `fetch_main_headroom()` in tasks/static_quality_gates/metrics.py: widen its lookback from 1 day to 7 so it doesn't miss `main`'s last report over a weekend, and floor the computed headroom at `BUFFER_SIZE` instead of 0 when main is already over its own limit. ### Motivation `agent_rpm_arm64`/`agent_suse_arm64` exceeded their 735.07 MiB limit on `main`, driven mainly by #54204's Rust data-security check (+3.49 MiB). Restoring headroom via `quality-gates.exception-threshold-bump` should have been a one-line fix, but the script failed to produce a usable threshold, for two reasons. Its 1-day lookback missed `main`'s last report across the weekend gap between Friday's merges and the incident, since main only reports this metric when a commit lands. And it sets the new limit to the PR's own reported size plus main's headroom, so whenever main's headroom was at or below 0 (as it was here) the new limit collapsed to just the PR's own size: a threshold still below main's actual usage, one that would not even have unblocked `main`. ### Describe how you validated your changes Added `test_headroom_floored_when_main_over_its_own_limit` (renamed from the now-inverted `test_headroom_never_negative`) asserting the floor applies when main is over budget. Reran `quality-gates.exception-threshold-bump` twice independently: both runs produced identical thresholds, confirming the fix is deterministic.

### What does this PR do? Bump `agent_rpm_arm64`/`agent_suse_arm64`'s `max_on_disk_size` using `quality-gates.exception-threshold-bump`'s fix from #54615: the only two gates PR #54400 is actually short on headroom for. Also align each RPM/SUSE twin gate pair's `max_on_wire_size` up to the higher of the two (`agent_rpm_amd64_fips`, `agent_rpm_arm64_fips`, `agent_suse_arm64`, `iot_agent_suse_amd64`): RPM and SUSE packages are the same format, so a twin pair drifting apart is noise, not signal. ### Motivation PR #54400 (an incident fix) is blocked by these two gates, both at zero margin on `main` after #54204's Rust data-security check. A rebase alone left it short by 34 KiB. ### Describe how you validated your changes Confirmed against PR #54400's live metrics: it currently fails only `agent_rpm_arm64`/`agent_suse_arm64` on-disk, by 34.26 KiB; against these new thresholds, none of its 33 gates fail. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

### What does this PR do? Fix `fetch_main_headroom()` in tasks/static_quality_gates/metrics.py: widen its lookback from 1 day to 7 so it doesn't miss `main`'s last report over a weekend, and floor the computed headroom at `BUFFER_SIZE` instead of 0 when main is already over its own limit. ### Motivation `agent_rpm_arm64`/`agent_suse_arm64` exceeded their 735.07 MiB limit on `main`, driven mainly by #54204's Rust data-security check (+3.49 MiB). Restoring headroom via `quality-gates.exception-threshold-bump` should have been a one-line fix, but the script failed to produce a usable threshold, for two reasons: 1. its 1-day lookback missed `main`'s last report across the weekend gap between Friday's merges and the incident, since main only reports this metric when a commit lands, 2. it sets the new limit to the PR's own reported size plus main's headroom, so whenever main's headroom was at or below 0 (as it was here) the new limit collapsed to just the PR's own size: a threshold still below main's actual usage, one that would not even have unblocked `main`. ### Describe how you validated your changes Added `test_headroom_floored_when_main_over_its_own_limit` (renamed from the now-inverted `test_headroom_never_negative`) asserting the floor applies when main is over budget. Reran `quality-gates.exception-threshold-bump` twice independently: both runs produced identical thresholds, confirming the fix is deterministic. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

### What does this PR do? Fix `fetch_main_headroom()` in tasks/static_quality_gates/metrics.py: widen its lookback from 1 day to 7 so it doesn't miss `main`'s last report over a weekend, and floor the computed headroom at `BUFFER_SIZE` instead of 0 when main is already over its own limit. ### Motivation `agent_rpm_arm64`/`agent_suse_arm64` exceeded their 735.07 MiB limit on `main`, driven mainly by #54204's Rust data-security check (+3.49 MiB). Restoring headroom via `quality-gates.exception-threshold-bump` should have been a one-line fix, but the script failed to produce a usable threshold, for two reasons: 1. its 1-day lookback missed `main`'s last report across the weekend gap between Friday's merges and the incident, since main only reports this metric when a commit lands, 2. it sets the new limit to the PR's own reported size plus main's headroom, so whenever main's headroom was at or below 0 (as it was here) the new limit collapsed to just the PR's own size: a threshold still below main's actual usage, one that would not even have unblocked `main`. ### Describe how you validated your changes Added `test_headroom_floored_when_main_over_its_own_limit` (renamed from the now-inverted `test_headroom_never_negative`) asserting the floor applies when main is over budget. Reran `quality-gates.exception-threshold-bump` twice independently: both runs produced identical thresholds, confirming the fix is deterministic. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com> 1d86ce7

### What does this PR do? Bump `agent_rpm_arm64`/`agent_suse_arm64`'s `max_on_disk_size` using `quality-gates.exception-threshold-bump`'s fix from #54615: the only two gates PR #54400 is actually short on headroom for. Also align each RPM/SUSE twin gate pair's `max_on_wire_size` up to the higher of the two (`agent_rpm_amd64_fips`, `agent_rpm_arm64_fips`, `agent_suse_arm64`, `iot_agent_suse_amd64`): RPM and SUSE packages are the same format, so a twin pair drifting apart is noise, not signal. ### Motivation #54400 (an incident fix) is blocked by these two gates, both at zero margin on `main` after #54204's Rust data-security check. A rebase alone left it short by 34 KiB. ### Describe how you validated your changes Confirmed against #54400's live metrics: it currently fails only `agent_rpm_arm64`/`agent_suse_arm64` on-disk, by 34.26 KiB. Against these new thresholds, none of its 33 gates fail. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

dd-octo-sts Bot added internal Identify a non-fork PR team/agent-build labels Jul 29, 2026

github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 29, 2026

aimenebelfodil marked this pull request as ready for review July 29, 2026 11:46

aimenebelfodil requested a review from a team as a code owner July 29, 2026 11:46

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread releasenotes/notes/add-data-security-autodiscovery-provider-2ab184b36fe134e9.yaml Outdated

aimenebelfodil added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Jul 29, 2026

github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jul 29, 2026

chouquette approved these changes Jul 29, 2026

View reviewed changes

aimenebelfodil force-pushed the aimene.belfodil/dsec-212/ship-data-security branch from db78498 to 6ea687b Compare July 30, 2026 16:32

aimenebelfodil requested review from a team, aiuto, cmourot and quentinus95 as code owners July 31, 2026 09:24

dd-octo-sts Bot added the team/container-platform The Container Platform Team label Jul 31, 2026

aimenebelfodil force-pushed the aimene.belfodil/dsec-212/ship-data-security branch from 1dbd45b to fc4c012 Compare July 31, 2026 09:26

vinckama approved these changes Jul 31, 2026

View reviewed changes

vinckama reviewed Jul 31, 2026

View reviewed changes

Comment thread pkg/collector/sharedlibrary/rustchecks/BUILD.bazel Outdated

vinckama reviewed Jul 31, 2026

View reviewed changes

Comment thread pkg/collector/sharedlibrary/rustchecks/BUILD.bazel Outdated

aiuto previously requested changes Aug 4, 2026

View reviewed changes

aimenebelfodil force-pushed the aimene.belfodil/dsec-212/ship-data-security branch from f35bc1d to e46946f Compare August 4, 2026 07:21

cmourot approved these changes Aug 4, 2026

View reviewed changes

aiuto approved these changes Aug 4, 2026

View reviewed changes

aimenebelfodil force-pushed the aimene.belfodil/dsec-212/ship-data-security branch from a5c4c6d to d174273 Compare August 4, 2026 19:14

aimenebelfodil added 5 commits August 5, 2026 00:35

datasecurity: enable data security rust check

78a7f39

datasecurity: add release note

a341ea8

datasecurity: update comment on ENABLED_CHECKS

b8d411b

Bump static quality gates

155615d

compensate PR #54419 after rebase

269c5d4

aimenebelfodil force-pushed the aimene.belfodil/dsec-212/ship-data-security branch from d174273 to 269c5d4 Compare August 4, 2026 22:35

gh-worker-dd-mergequeue-cf854d Bot merged commit 805bf9c into main Aug 5, 2026
305 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the aimene.belfodil/dsec-212/ship-data-security branch August 5, 2026 00:14

github-actions Bot added this to the 7.83.0 milestone Aug 5, 2026

rdesgroppes mentioned this pull request Aug 10, 2026

Fix exception-threshold-bump when restoring lost headroom #54615

Merged

rdesgroppes mentioned this pull request Aug 10, 2026

Restore static quality gates headroom for #54400 #54637

Merged

Uh oh!

Conversation

aimenebelfodil commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Decision Record

Note

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

datadog-prod-us1-4 Bot commented Jul 29, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.83.0~devel.git.573.269c5d4.pipeline.129028097-1_amd64.deb:

Detected file changes:

1 Added files:

Uh oh!

dd-octo-sts Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Error

Uh oh!

cit-pr-commenter-54b7da Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Profiling Replicate Execution Failures (ddprof)

CI Pass/Fail Decision

Uh oh!

vinckama left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aiuto left a comment

Choose a reason for hiding this comment

Uh oh!

aimenebelfodil commented Aug 4, 2026

Uh oh!

aimenebelfodil commented Aug 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimenebelfodil commented Aug 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimenebelfodil commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimenebelfodil commented Aug 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

aimenebelfodil commented Aug 4, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

aimenebelfodil commented Jul 29, 2026 •

edited

Loading

datadog-prod-us1-4 Bot commented Jul 29, 2026 •

edited by datadog-official Bot

Loading

dd-octo-sts Bot commented Jul 29, 2026 •

edited

Loading

dd-octo-sts Bot commented Jul 29, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented Jul 29, 2026 •

edited

Loading

vinckama left a comment •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 •

edited

Loading

aimenebelfodil commented Aug 4, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Aug 4, 2026 •

edited

Loading