Skip to content

[Host Profiler] dedicated log file in Bundled mode - #54216

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
theomagellan/host-profiler-log_file
Aug 5, 2026
Merged

[Host Profiler] dedicated log file in Bundled mode#54216
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
theomagellan/host-profiler-log_file

Conversation

@theomagellan

@theomagellan theomagellan commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

While creating the Agent Core in Bundled mode, we were passing log_file config value to the host profiler's logger. This value was meant for the agent and made the profiler try to write its logs there.

This PR adds a now config setting hostprofiler.log_file with a sane default to let the profiler log in its dedicated file, like other agent components do.

Motivation

This was never showing up as an error since agent.log is root-owned, and the Host Profiler was running root as well. I ran into permission errors while running the profiler on a different uid on rel-env.

Describe how you validated your changes

Additional Notes

This PR adds a new setting in the agent's config and I'm tempted to update the docs to go along the change, but we've been sending the doc targetting main to customers. Adding it now would make it misleading as the preview doesn't support it.

@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 29, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@theomagellan theomagellan changed the title make the profiler in bundled mode log in a dedicated file [Host Profiler] dedicated log file in Bundled mode Jul 30, 2026
@theomagellan

Copy link
Copy Markdown
Contributor Author

/ddci trigger

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-30 14:42:10 UTC ℹ️ Start processing command /ddci trigger


2026-07-30 14:42:13 UTC ℹ️ Devflow: /ddci trigger

Tasks sourcing running asynchronously in workflow devflow:66067b59-9a9e-400d-9acf-bb16602ba896_44:019fb379-c9de-75af-b867-6d678bf9ccad under run id 019fb379-d11b-72f9-81ae-a3cc4f3fe5ca

@theomagellan theomagellan added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Jul 30, 2026
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 52.24% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3edc5c1 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 2a66edc7:

Results for datadog-agent_7.83.0~devel.git.580.3edc5c1.pipeline.129198291-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2a66edc
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +6.87 KiB (0.00% increase, -0.13% of buffer) 757.655 → 757.662 → 762.870
agent_msi +3.0 KiB (0.00% increase, -0.02% of buffer) 639.347 → 639.350 → 657.290
agent_rpm_amd64 +6.87 KiB (0.00% increase, -0.13% of buffer) 757.639 → 757.645 → 762.840
agent_suse_amd64 +6.87 KiB (0.00% increase, -0.13% of buffer) 757.639 → 757.645 → 762.840
docker_agent_amd64 +6.86 KiB (0.00% increase, -0.31% of buffer) 816.309 → 816.316 → 818.460
docker_agent_jmx_amd64 +6.86 KiB (0.00% increase, -0.33% of buffer) 1007.207 → 1007.214 → 1009.220
27 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64_fips 711.295 MiB
agent_heroku_amd64 311.890 MiB
agent_rpm_amd64_fips 711.279 MiB
agent_rpm_arm64 733.739 MiB
agent_rpm_arm64_fips 690.663 MiB
agent_suse_amd64_fips 711.279 MiB
agent_suse_arm64 733.739 MiB
agent_suse_arm64_fips 690.663 MiB
docker_agent_arm64 817.473 MiB
docker_agent_jmx_arm64 997.023 MiB
docker_cluster_agent_amd64 210.030 MiB
docker_cluster_agent_arm64 223.077 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.312 MiB
docker_dogstatsd_arm64 37.433 MiB
docker_host_profiler_amd64 305.307 MiB
docker_host_profiler_arm64 316.621 MiB
dogstatsd_deb_amd64 30.053 MiB
dogstatsd_deb_arm64 28.089 MiB
dogstatsd_rpm_amd64 30.053 MiB
dogstatsd_suse_amd64 30.053 MiB
iot_agent_deb_amd64 46.290 MiB
iot_agent_deb_arm64 42.973 MiB
iot_agent_deb_armhf 43.738 MiB
iot_agent_rpm_amd64 46.290 MiB
iot_agent_suse_amd64 46.289 MiB

@theomagellan
theomagellan force-pushed the theomagellan/host-profiler-log_file branch from 352a5a3 to e423032 Compare July 30, 2026 15:55
  while creating the Agent Core in Bundled mode, we were passing
  `log_file` config value to the host profiler's logger. This value was
  meant for the agent and made the profiler try to write its logs there.

  we now have a dedicated logging file, like other agent components.
@theomagellan
theomagellan force-pushed the theomagellan/host-profiler-log_file branch from e423032 to b5ed136 Compare July 30, 2026 16:40
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 30, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 04704cd0-ade7-4497-b323-ac6ff769f3a6

Baseline: 11adc85
Comparison: 9f0c29e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_mean_fs_load memory utilization +0.21 [+0.17, +0.25] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.15 [+0.11, +0.20] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.05 [-0.01, +0.10] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.01 [-0.26, +0.24] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.01 [-0.05, +0.03] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.06 [-0.18, +0.07] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.35 [-0.44, -0.25] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.44 [-2.29, -0.59] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.31MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 733.65KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 493.51MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 187.36MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 360.91 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 414.44MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 70.68MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 26.92 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 298.74MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 60.94 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 277.70MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.93 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 288.36MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@theomagellan
theomagellan marked this pull request as ready for review July 30, 2026 18:02
@theomagellan
theomagellan requested review from a team as code owners July 30, 2026 18:02
@theomagellan
theomagellan requested review from Hitsuji-M and agagniere and removed request for a team July 30, 2026 18:02

@mackjmr mackjmr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions:

  • Other agent containers (e.g. trace-agent, system-probe) also have a dedicated log file, do they follow the same approach than here ? From the PR description seems like yes, but want to confirm.
  • When we generate a flare, the log files are already separated. e.g. the logs folder contains files trace-agent.log, system-probe.log, agent.log and most importantly here host-profiler.log. With this change, does host-profiler.log still make it in the flare ?

@theomagellan

theomagellan commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author
  • Other agent containers (e.g. trace-agent, system-probe) also have a dedicated log file, do they follow the same approach than here ? From the PR description seems like yes, but want to confirm.

Yes.

  • When we generate a flare, the log files are already separated. e.g. the logs folder contains files trace-agent.log, system-probe.log, agent.log and most importantly here host-profiler.log. With this change, does host-profiler.log still make it in the flare ?

I just generated 2 flares using rel-env's main deployment and a preview one on stripe, and I'm not finding any host profiler logs in there? Feel free to double check, I could be mistaken!

@mackjmr

mackjmr commented Aug 3, 2026

Copy link
Copy Markdown
Member

@theomagellan I tested the flare in staging, and indeed the host-profiler.log is missing (along with other agent log files), so it seems there is a setup issue in staging and this isn't specific to FHP. Now I also tested locally with preview image, and confirmed that host-profiler.log is present. Can you validate that this is also present with this change ?

@mackjmr mackjmr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Aug 5, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 9f0c29e into main Aug 5, 2026
301 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the theomagellan/host-profiler-log_file branch August 5, 2026 21:13
@github-actions github-actions Bot added this to the 7.83.0 milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation team/profiling-full-host

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants