Process Invalid API key events from Remote Agents

[atanzu]

What does this PR do?

Add a hook to trigger API key refresh if Remote Agents inform us that they get Invalid API Key errors.

Motivation

When users enable secrets to handle their API keys, Remote Agents need a mechanism to ask Agent to refresh those keys when endpoints return 403s on submissions, because in this case a 403 is not a hard fault, but rather a signal that the key has become stale and we need a new one. Here we add this trigger to the existing RAR event mechanism.

Describe how you validated your changes

Add a unit test to check that Invalid API Key events trigger a refresh.

Additional Notes

• closes: AGTMETRICS-504

[atanzu]

/dd-review claude

[github-actions]

AI review by Claude - workflow run

Warning

AI review could not be posted: model output did not parse as JSON (Unexpected non-whitespace character after JSON at position 2 (line 1 column 3))

See workflow run for details.

[datadog-prod-us1-4]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.18% (-3.15%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7abb9ca | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 5eaeaa7e:

Results for datadog-agent_7.83.0~devel.git.454.7abb9ca.pipeline.127898325-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 5eaeaa7
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	docker_agent_amd64	-5.44 KiB (0.00% reduction, +0.19% of buffer)	811.045 → 811.040 → 813.790
✅	docker_agent_arm64	-5.44 KiB (0.00% reduction, +0.23% of buffer)	812.675 → 812.669 → 815.030
✅	docker_agent_jmx_amd64	-5.45 KiB (0.00% reduction, +0.20% of buffer)	1001.943 → 1001.937 → 1004.550
✅	docker_agent_jmx_arm64	-5.46 KiB (0.00% reduction, +0.21% of buffer)	992.225 → 992.219 → 994.710
✅	docker_cluster_agent_amd64	-5.43 KiB (0.00% reduction, +0.92% of buffer)	209.895 → 209.889 → 210.470
✅	docker_cluster_agent_arm64	-5.44 KiB (0.00% reduction, +20.02% of buffer)	222.953 → 222.948 → 222.980
✅	docker_host_profiler_amd64	-5.44 KiB (0.00% reduction, +0.04% of buffer)	305.018 → 305.013 → 317.640
✅	docker_host_profiler_arm64	-5.46 KiB (0.00% reduction, +0.04% of buffer)	316.335 → 316.330 → 328.900
✅	iot_agent_deb_armhf	+4.0 KiB (0.01% increase, -1.22% of buffer)	43.641 → 43.645 → 43.960

24 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.378 MiB
✅	agent_deb_amd64_fips	707.143 MiB
✅	agent_heroku_amd64	308.101 MiB
✅	agent_msi	637.906 MiB
✅	agent_rpm_amd64	752.362 MiB
✅	agent_rpm_amd64_fips	707.127 MiB
✅	agent_rpm_arm64	728.936 MiB
✅	agent_rpm_arm64_fips	686.855 MiB
✅	agent_suse_amd64	752.362 MiB
✅	agent_suse_amd64_fips	707.127 MiB
✅	agent_suse_arm64	728.936 MiB
✅	agent_suse_arm64_fips	686.855 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.263 MiB
✅	docker_dogstatsd_arm64	37.368 MiB
✅	dogstatsd_deb_amd64	30.008 MiB
✅	dogstatsd_deb_arm64	28.043 MiB
✅	dogstatsd_rpm_amd64	30.008 MiB
✅	dogstatsd_suse_amd64	30.008 MiB
✅	iot_agent_deb_amd64	46.189 MiB
✅	iot_agent_deb_arm64	42.876 MiB
✅	iot_agent_rpm_amd64	46.189 MiB
✅	iot_agent_suse_amd64	46.188 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6cd38903-c913-4254-91ee-5f958ef93113

Baseline: 83b0223
Comparison: 48e1a12
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.91	[+0.66, +1.16]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.35	[+0.23, +0.47]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.29	[+0.23, +0.35]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.25	[+0.19, +0.30]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.11	[+0.07, +0.15]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.21	[-1.21, +0.80]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.32	[-0.35, -0.28]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.43	[-0.53, -0.33]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	148.55MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	730.60KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	492.53MiB ≤ 512MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	190.90MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.81MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	355.14 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	406.71MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	72.07MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	28.12 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	303.14MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	65.06 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	280.26MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.45 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	289.64MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.