fix(cluster-agent): restore rate_limit_queries telemetry after external metrics refactor - #54273
Open
a7i wants to merge 1 commit into
Open
fix(cluster-agent): restore rate_limit_queries telemetry after external metrics refactor#54273a7i wants to merge 1 commit into
a7i wants to merge 1 commit into
Conversation
dd-octo-sts
Bot
added
community
team/container-integrations
team/container-platform
…al metrics refactor QueryExternalMetric stopped calling updateRateLimitingMetrics() when parallel query batching landed in DataDog#33272, so limit/remaining/period/reset gauges were no longer published on the cluster-agent metrics endpoint. Co-authored-by: Cursor <cursoragent@cursor.com>
a7i
force-pushed
the
fix/restore-rate-limit-queries-metrics
branch
from
July 30, 2026 19:00
c64d39d to
9972a40
Compare
a7i
marked this pull request as ready for review
July 30, 2026 19:23
vboulineau
approved these changes
Jul 31, 2026
sblumenthal
approved these changes
Jul 31, 2026
sblumenthal
added
qa/rc-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the call to
updateRateLimitingMetrics()at the end ofQueryExternalMetric, so the cluster-agent again publishesrate_limit_queries_{limit,remaining,period,reset}on its Prometheus metrics endpoint.Motivation
#33272 refactored external metrics querying to run chunks in parallel but dropped the
updateRateLimitingMetrics()call that used to run after queries completed. The helper and gauges still exist, but onlyrate_limit_queries_remaining_minis updated today (insidequeryDatadogExternal). Integrations and dashboards expectingdatadog.cluster_agent.datadog.rate_limit_queries.limit(and related metrics) see no data on DCA 7.66+.Describe how you validated your changes
Additional Notes
QueryExternalMetricstill documents that it updates rate limit statistics; this restores that behavior without changing query batching semantics.Made with Cursor