CWS: sync BTFHub constants - #54296
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca37528d32
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -83,6 +83,193 @@ | |||
| "task_struct_pid_link_offset": 1880, | |||
| "task_struct_real_cred_offset": 2232, | |||
| "task_struct_signal_offset": 2328, | |||
| "task_struct_thread_offset": 3152, | |||
There was a problem hiding this comment.
Include the ARM64 uw offset in BTFHub constants
For ARM64, AppendProbeRequestsToFetcher requests both task_struct_thread_offset and thread_struct_uw_offset, and the eBPF helper reads task + thread_offset + uw_offset to find the TLS thread pointer. This sync adds task_struct_thread_offset to every ARM64 constant set, but constants_arm64.json contains no thread_struct_uw_offset entries, so matching BTFHub kernels still get ErrorSentinel for the second half and CreateConstantEditors patches it as 0; Go label/TLSDESC reads will use the start of thread_struct instead of thread_struct.uw. Regenerate or add the ARM64 thread_struct_uw_offset values alongside these new task offsets.
AGENTS.md reference: AGENTS.md:L177-L178
Useful? React with 👍 / 👎.
|
🎯 Code Coverage (details) 🔗 Commit SHA: ca37528 | Docs | Datadog PR Page | Give us feedback! |
Files inventory check summaryFile checks results against ancestor 4a581ee5: Results for datadog-agent_7.83.0~devel.git.413.ca37528.pipeline.128203325-1_amd64.deb:No change detected |
|
Superseded — the sync commit has been cherry-picked directly onto Note for future syncs: this run was dispatched with |
What does this PR do?
This PR syncs the BTFHub constants used by CWS
This PR was autogenerated