Add cws-btfhub-sync skill - #54297
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88f38d9f0a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --- | ||
| name: cws-btfhub-sync | ||
| description: Sync CWS BTFHub constants after adding a new constantfetch offset, so pre-BTF kernels can resolve it. Use when KMT secagent jobs log "failed to fetch constant for <name>". | ||
| allowed-tools: Read, Grep, Bash, AskUserQuestion | ||
| model: sonnet |
There was a problem hiding this comment.
Add the missing skill contract details
Scores: Description 20/25, Writing philosophy 18/25, Structure/progressive disclosure 23/25, Output/examples 12/25, total 73/100; overall recommendation: Approve with suggestions. Top improvements: declare an owning team in the skill metadata/body, since every AI artifact needs an owner; add prerequisites and an explicit success checklist/output shape, such as authenticated gh, current branch pushed, generated PR found, constants file changed, and source PR closed; make the wait example actually background-safe or include how to capture the run id, because the current copied command still runs a foreground polling loop despite warning against foreground waits.
Useful? React with 👍 / 👎.
88f38d9 to
31cda9b
Compare
Files inventory check summaryFile checks results against ancestor 5fcb9f95: Results for datadog-agent_7.84.0~devel.git.223.52010cd.pipeline.131271312-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.223.52010cd.pipeline.131271312-1_amd64.deb:No change detected |
31cda9b to
540bb5e
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
Documents how to regenerate the CWS BTFHub constants after adding a new constantfetch offset, so pre-BTF kernels can resolve it.
540bb5e to
52010cd
Compare
Skill file documenting how to trigger the
cws-btfhub-syncworkflow and land its output after adding a new constantfetch offset.Covers the two things that are easy to get wrong:
--ref main+base_branch=<feature-branch>(otherwise the generator never sees the new offset requests and the sync yields an empty diff), and polling the ~15-job matrix from a background shell instead ofgh run watch.Docs only, no code change.
🤖 Generated with Claude Code