Skip to content

fix(e2e/discovery): Let a crash-looping fixture fail instead of restarting forever #54350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Aug 4, 2026
Merged

fix(e2e/discovery): Let a crash-looping fixture fail instead of restarting forever #54350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/new-e2e/tests/discovery/testdata/provision/provision.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,20 @@ install_systemd_unit() {
done <<< "${extraenv} "
fi

# The start limit is left enabled on purpose. These services are
# Restart=always with RestartSec=1, so one which fails immediately restarts
# forever: it stays in "activating (auto-restart)" and never reaches "failed",
# which makes a broken fixture look like a service the Agent failed to
# discover rather than a service that is not running. Letting the limit stop
# it turns that into a failed unit instead. The counter is reset by an
# explicit systemctl stop, so the start/stop cycles the tests do between
# subtests never accumulate towards it.
cat > "/etc/systemd/system/${name}.service" <<- EOM
[Unit]
Description=${name}
After=network.target
StartLimitIntervalSec=0
StartLimitIntervalSec=60
StartLimitBurst=5

[Service]
Type=simple
Expand Down
Loading