Skip to content

[ACIX-1916] feat(ai): Create /follow-pr skill - #54482

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 9 commits into
mainfrom
pierrelouis.veyrenc/ACIX-1916-create-follow-pr-skill
Aug 7, 2026
Merged

[ACIX-1916] feat(ai): Create /follow-pr skill#54482
gh-worker-dd-mergequeue-cf854d[bot] merged 9 commits into
mainfrom
pierrelouis.veyrenc/ACIX-1916-create-follow-pr-skill

Conversation

@Ishirui

@Ishirui Ishirui commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a new skill, /follow-pr for.... well, following the status of a PR.

Motivation

This is meant as a base for a future, more fully-featured /polish-pr skill

Describe how you validated your changes

Additional Notes

@Ishirui
Ishirui requested a review from a team as a code owner August 5, 2026 16:01
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-devx labels Aug 5, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2aa046924d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/skills/create-pr/SKILL.md
Comment thread .agents/skills/follow-pr/create_devenv.sh Outdated
@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Aug 5, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 079eb1d3:

Results for datadog-agent_7.84.0~devel.git.24.8d01ea8.pipeline.129658848-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.24.8d01ea8.pipeline.129658848-1_amd64.deb:

No change detected

@quentinus95 quentinus95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to see this in action
Sharing minor comments, not approving because I fear PR Shepherd could merge before you have time to review

Comment thread .agents/skills/follow-pr/create_devenv.sh Outdated
Comment thread .agents/skills/follow-pr/create_devenv.sh Outdated
Comment thread .agents/skills/follow-pr/SKILL.md Outdated
Comment thread .agents/skills/follow-pr/SKILL.md Outdated
Comment thread .agents/skills/follow-pr/SKILL.md Outdated

@quentinus95 quentinus95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous review and comments

@Ishirui

Ishirui commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 14:19:19 UTC ℹ️ Start processing command /merge


2026-08-07 14:19:34 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-08-07 14:50:15 UTC ⚠️ MergeQueue: This merge request was unqueued

pierrelouis.veyrenc@datadoghq.com unqueued this merge request

@Ishirui

Ishirui commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 14:27:32 UTC ℹ️ Start processing command /code blockers


2026-08-07 14:27:33 UTC ℹ️ Devflow:

Checking merge blockers for #54482...


2026-08-07 14:27:47 UTC ℹ️ Devflow: /code blockers

Detected 3 merge blocker(s) to address:

Could not determine:

  • Merge conflict status is still being computed

@Ishirui
Ishirui force-pushed the pierrelouis.veyrenc/ACIX-1916-create-follow-pr-skill branch from 810a6e2 to fd4e813 Compare August 7, 2026 14:34
@Ishirui Ishirui added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 7, 2026
@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Aug 7, 2026
@Ishirui

Ishirui commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 15:17:38 UTC ℹ️ Start processing command /merge


2026-08-07 15:17:46 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-08-07 15:53:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 3h (p90).


2026-08-07 16:24:29 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-08-07 16:42:57 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-08-07 17:31:57 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 25ec4bf into main Aug 7, 2026
239 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the pierrelouis.veyrenc/ACIX-1916-create-follow-pr-skill branch August 7, 2026 17:31
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 7, 2026
github-actions Bot pushed a commit that referenced this pull request Aug 7, 2026
<!--Please give us some feedback on your experience writing this PR ! https://app.datadoghq.com/forms/43db4c02-6837-400c-8083-692e141b1b88 !-->

### What does this PR do?
Adds a new skill, `/follow-pr` for.... well, following the status of a PR.

### Motivation
This is meant as a base for a future, more fully-featured `/polish-pr` skill

### Describe how you validated your changes

### Additional Notes

Co-authored-by: pierrelouis.veyrenc <pierrelouis.veyrenc@datadoghq.com> 25ec4bf
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff2ded06-3b64-451e-850f-1935c789f464

Baseline: fd17682
Comparison: 25ec4bf
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.55 [+0.30, +0.80] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.36 [+0.32, +0.40] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.28 [+0.16, +0.40] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.27 [+0.23, +0.30] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.09 [+0.04, +0.13] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.03 [-0.07, +0.12] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.02 [-0.07, +0.03] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.90 [-1.75, -0.04] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.08MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 733.17KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 493.68MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 186.63MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.13MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 380.08 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 399.33MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.02MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.45 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 297.89MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.21 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 278.24MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.30 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 287.61MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

niharikag09 pushed a commit to niharikag09/datadog-agent that referenced this pull request Aug 10, 2026
<!--Please give us some feedback on your experience writing this PR ! https://app.datadoghq.com/forms/43db4c02-6837-400c-8083-692e141b1b88 !-->

### What does this PR do?
Adds a new skill, `/follow-pr` for.... well, following the status of a PR.

### Motivation
This is meant as a base for a future, more fully-featured `/polish-pr` skill

### Describe how you validated your changes

### Additional Notes


Co-authored-by: pierrelouis.veyrenc <pierrelouis.veyrenc@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants