Skip to content

fix(cws): register accepted sockets in the flow_pid map - #54663

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
yoanngh/accept-flow-pid-kernel-7
Aug 11, 2026
Merged

fix(cws): register accepted sockets in the flow_pid map#54663
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
yoanngh/accept-flow-pid-kernel-7

Conversation

@YoannGh

@YoannGh YoannGh commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Registers IPv6 flows in the flow_pid map using the socket returned by accept().

Motivation

Until Linux 7.0, the flow for such socket was classified on its first transmit in the security_sk_classify_flow hook, so an accepted connection on a wildcard listener was attributed to the process owning it. Linux 7.0 now skips that classification whenever the socket already holds a route, which is always the case for incoming connections, so those flows were left unattributed on that kernel version.

Describe how you validated your changes

Existing functional tests running on Ubuntu 26.04 that this PR fixes.

Additional Notes

IPv4 flows are unaffected as these are still registered as part of the security_sk_classify_flow hook.

@YoannGh
YoannGh requested review from a team as code owners August 10, 2026 17:22
@YoannGh YoannGh added the changelog/no-changelog No changelog entry needed label Aug 10, 2026
@github-actions github-actions Bot added component/system-probe and removed changelog/no-changelog No changelog entry needed labels Aug 10, 2026
@YoannGh YoannGh added the changelog/no-changelog No changelog entry needed label Aug 10, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Aug 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 679837175f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/security/ebpf/probes/event_types.go Outdated
@YoannGh YoannGh changed the title fix(cws): register accepted sockets in the flow to PID map fix(cws): register accepted sockets in the flow_pid map Aug 10, 2026
@YoannGh YoannGh added the qa/done QA done before merge and regressions are covered by tests label Aug 10, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 52.34% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a0335db | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor b39d95df:

Results for datadog-agent_7.84.0~devel.git.52.a0335db.pipeline.130089938-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.52.a0335db.pipeline.130089938-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b39d95d
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +53.68 KiB (0.01% increase, -1.07% of buffer) 759.543 → 759.595 → 764.430
agent_deb_amd64_fips +53.68 KiB (0.01% increase, -1.88% of buffer) 712.888 → 712.941 → 715.680
agent_rpm_amd64 +53.68 KiB (0.01% increase, -1.08% of buffer) 759.526 → 759.579 → 764.400
agent_rpm_amd64_fips +53.68 KiB (0.01% increase, -1.87% of buffer) 712.872 → 712.924 → 715.680
agent_rpm_arm64 +54.82 KiB (0.01% increase, -5.38% of buffer) 735.495 → 735.548 → 736.490
agent_rpm_arm64_fips +54.82 KiB (0.01% increase, -3.48% of buffer) 692.104 → 692.157 → 693.640
agent_suse_amd64 +53.68 KiB (0.01% increase, -1.08% of buffer) 759.526 → 759.579 → 764.400
agent_suse_amd64_fips +53.68 KiB (0.01% increase, -1.87% of buffer) 712.872 → 712.924 → 715.680
agent_suse_arm64 +54.82 KiB (0.01% increase, -5.38% of buffer) 735.495 → 735.548 → 736.490
agent_suse_arm64_fips +54.82 KiB (0.01% increase, -3.48% of buffer) 692.104 → 692.157 → 693.640
docker_agent_amd64 +53.68 KiB (0.01% increase, -2.89% of buffer) 818.154 → 818.206 → 819.970
docker_agent_arm64 +54.83 KiB (0.01% increase, -3.51% of buffer) 819.166 → 819.220 → 820.690
docker_agent_jmx_amd64 +53.68 KiB (0.01% increase, -3.12% of buffer) 1009.052 → 1009.104 → 1010.730
docker_agent_jmx_arm64 +54.82 KiB (0.01% increase, -3.24% of buffer) 998.716 → 998.770 → 1000.370
19 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 312.269 MiB
agent_msi 643.247 MiB
docker_cluster_agent_amd64 210.228 MiB
docker_cluster_agent_arm64 223.267 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.479 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.801 MiB
docker_host_profiler_arm64 317.116 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.416 MiB
iot_agent_deb_arm64 43.092 MiB
iot_agent_deb_armhf 43.871 MiB
iot_agent_rpm_amd64 46.416 MiB
iot_agent_suse_amd64 46.415 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 10, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c00a4d3e-67c5-4862-9473-38de5988dfc2

Baseline: 7418217
Comparison: 0942aad
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.40 [+1.54, +3.27] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.42 [+0.30, +0.54] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.25 [+0.21, +0.29] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.21 [-0.03, +0.46] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.11 [+0.06, +0.16] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.08 [-0.13, -0.02] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.08 [-0.12, -0.04] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.18 [-0.28, -0.08] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.69MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 731.79KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 488.10MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 183.79MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 373.80 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 398.10MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.55MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 26.62 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 301.36MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 59.24 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 282.63MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.35 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 286.56MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Accepting a connection on a wildcard listener yields a child socket bound to
the concrete local address the connection landed on, which the listener's
BIND_ENTRY does not cover. That child used to be classified on its first
transmit, because inet6_csk_xmit called inet6_csk_route_socket unconditionally
and the classification sits ahead of the route cache lookup inside it.

Linux 7.0 moved the cache lookup up into inet6_csk_xmit, which now only routes
on a miss. A child socket is given its route at SYN-RECV time, so the lookup
always hits and the classification never runs, leaving server side flows
unattributed. The passive open path has no other registration point: the hook
it does go through is the one for connection requests, which we do not track.

Register the flow from the socket accept returns, reusing the existing accept
hook so a single program stays attached to inet_csk_accept. That hook now
loads with the network probes, since the registration has to happen whenever
network tracking is on, and only sends its event once the event type shows up
in the enabled_events map.

Only native IPv6 sockets need this: the IPv4 path has always skipped
classification for a socket that already holds a route, and IPv4 traffic over
an AF_INET6 socket takes that path too.
The network selectors are only applied when network tracking is enabled, while
accept events stay valid without it. Leaving the per event type selector empty
detached the hook in that configuration, dropping accept events for policies
that ask for them.
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 0942aad into main Aug 11, 2026
443 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the yoanngh/accept-flow-pid-kernel-7 branch August 11, 2026 09:14
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category/bugfix changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-build team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants