Skip to content

[Backport 7.82.x] feat(eudm): auto-enable logon_duration in end_user_device mode - #54664

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
7.82.xfrom
backport-54434-to-7.82.x
Aug 13, 2026
Merged

[Backport 7.82.x] feat(eudm): auto-enable logon_duration in end_user_device mode#54664
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
7.82.xfrom
backport-54434-to-7.82.x

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Backport 1dbeb46 from #54434.


What does this PR do?

Automatically enables the logon_duration feature when the Agent is in end-user-device mode (infrastructure_mode: end_user_device), so operators no longer have to set logon_duration.enabled: true separately.

Two changes:

  1. pkg/config/setup/config.goapplyInfrastructureModeOverrides now force-enables logon_duration.enabled (with SourceInfraMode) in the end_user_device branch, alongside the existing process_collection, software_inventory, and notable_events overrides. Because SourceInfraMode sits below explicit user config, a user who sets logon_duration.enabled: false still wins.

  2. pkg/system-probe/config/config.go — the macOS logon_duration system-probe module gate now reads the flag from the core config (datadog.yaml) instead of the system-probe config (system-probe.yaml). Without this, the EUD override (which is applied to the core config) would enable the agent-side component but never start the system-probe module that actually collects the data on macOS. This mirrors how software_inventory is gated.

Motivation

WINA-3004 — reduce configuration friction for end-user-device deployments; logon_duration should be on by default in that mode.

Describe how you validated your changes

  • Unit tests added in pkg/config/setup/config_test.go: EUD auto-enables logon_duration.enabled; non-EUD modes leave it at the default (false); an explicit user false overrides the EUD default.
  • dda inv test --targets=./pkg/config/setup and --targets=./pkg/system-probe/config both pass.

Additional Notes

  • Behavior change on macOS: setting logon_duration.enabled only in system-probe.yaml no longer starts the module — the value must come from datadog.yaml (or DD_LOGON_DURATION_ENABLED). This matches software_inventory.

… ### What does this PR do?

Automatically enables the `logon_duration` feature when the Agent is in end-user-device mode (`infrastructure_mode: end_user_device`), so operators no longer have to set `logon_duration.enabled: true` separately.

Two changes:

1. **`pkg/config/setup/config.go`** — `applyInfrastructureModeOverrides` now force-enables `logon_duration.enabled` (with `SourceInfraMode`) in the `end_user_device` branch, alongside the existing `process_collection`, `software_inventory`, and `notable_events` overrides. Because `SourceInfraMode` sits below explicit user config, a user who sets `logon_duration.enabled: false` still wins.

2. **`pkg/system-probe/config/config.go`** — the macOS `logon_duration` system-probe module gate now reads the flag from the **core** config (`datadog.yaml`) instead of the **system-probe** config (`system-probe.yaml`). Without this, the EUD override (which is applied to the core config) would enable the agent-side component but never start the system-probe module that actually collects the data on macOS. This mirrors how `software_inventory` is gated.

### Motivation

WINA-3004 — reduce configuration friction for end-user-device deployments; `logon_duration` should be on by default in that mode.

### Describe how you validated your changes

- Unit tests added in `pkg/config/setup/config_test.go`: EUD auto-enables `logon_duration.enabled`; non-EUD modes leave it at the default (`false`); an explicit user `false` overrides the EUD default.
- `dda inv test --targets=./pkg/config/setup` and `--targets=./pkg/system-probe/config` both pass.

### Additional Notes

- **Behavior change on macOS:** setting `logon_duration.enabled` only in `system-probe.yaml` no longer starts the module — the value must come from `datadog.yaml` (or `DD_LOGON_DURATION_ENABLED`). This matches `software_inventory`.

Co-authored-by: mohammad.rafi <mohammad.rafi@datadoghq.com>
(cherry picked from commit 1dbeb46)

___

Co-authored-by: Mohammad Rafi <36865458+mrafi97@users.noreply.github.com>
@dd-octo-sts dd-octo-sts Bot added backport bot internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform labels Aug 10, 2026
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner August 10, 2026 17:48
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner August 10, 2026 17:48
@dd-octo-sts
dd-octo-sts Bot requested a review from dustmop August 10, 2026 17:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b7b09a30b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

config.Set("process_config.process_collection.enabled", true, pkgconfigmodel.SourceInfraMode)
config.Set("software_inventory.enabled", true, pkgconfigmodel.SourceInfraMode)
config.Set("notable_events.enabled", true, pkgconfigmodel.SourceInfraMode)
config.Set("logon_duration.enabled", true, pkgconfigmodel.SourceInfraMode)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Re-run infra-mode overrides after fleet policy merge

When infrastructure_mode: end_user_device is supplied from a fleet policy, this derived default is not applied: LoadDatadog runs override funcs before comp/core/config/setup.go merges fleet_policies_dir/datadog.yaml, and the post-merge path only reruns ADP-specific overrides. Those fleet-managed EUDM hosts keep logon_duration.enabled at its default false, so the agent-side component and the macOS system-probe module remain disabled despite the new auto-enable behavior.

Useful? React with 👍 / 👎.

@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Files inventory check summary

File checks results against ancestor 335b1258:

Results for datadog-agent_7.82.1.git.3.0b7b09a.pipeline.130019887-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 10, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 30eac421-25e8-46a4-8adf-2527592c9cc0

Baseline: 335b125
Comparison: 0b7b09a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.26 [+0.01, +0.52] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.18 [+0.14, +0.22] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.18 [+0.13, +0.23] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.10 [+0.06, +0.14] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.12 [-0.22, -0.02] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.58 [-0.64, -0.52] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.74 [-1.71, +0.23] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 146.25MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 733.69KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 485.22MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 182.65MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 362.65 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 405.58MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 30.26 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 295.35MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.41 ≤ 80 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 279.73MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 25.78 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 282.93MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Oom killed Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4a26b5d into 7.82.x Aug 13, 2026
332 of 343 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the backport-54434-to-7.82.x branch August 13, 2026 16:12
@github-actions github-actions Bot added this to the 7.82.2 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bot internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/ebpf-platform team/fleet-automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant