Debug-log and collect Agent logs on failure in domain-controller upgrade test - #54726
Draft
clarkb7 wants to merge 2 commits into
Draft
Debug-log and collect Agent logs on failure in domain-controller upgrade test#54726clarkb7 wants to merge 2 commits into
clarkb7 wants to merge 2 commits into
Conversation
…n-controller upgrade test Reduces fakeintake memory buildup across the multi-step install/upgrade flow to avoid OOM.
Contributor
|
@codex review |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3114f40e41
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Files inventory check summaryFile checks results against ancestor a055712c: Results for datadog-agent_7.84.0~devel.git.89.3b38619.pipeline.130254493-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.89.3b38619.pipeline.130254493-1_amd64.deb:No change detected |
clarkb7
added
changelog/no-changelog
…ain-controller upgrade test Replaces the fakeintake flush with agent-side debug logging plus a log collection AfterTest hook, to get better diagnostics on failures like the fakeintake connectivity timeout in WINA-3019.
clarkb7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_leveltodebugat runtime after each install step intestUpgradeSuite.TestGivenDomainUserCanUpgradeAgent.AfterTesthook that downloads the Agent log folder from the remote host into the session output dir when the test fails.Motivation
https://datadoghq.atlassian.net/browse/WINA-3019
Test plan
TestInstallsOnDomainController/testUpgradeSuitein CI and check the fakeintake dashboard for this run's stack to confirm memory usage stays under ~500MB across the install/upgrade flow.