Skip to content

Copy python files to avoid junction issues - #54819

Open
JSGette wants to merge 6 commits into
mainfrom
jsgette/fix-windows-cpython-install-runfiles
Open

Copy python files to avoid junction issues#54819
JSGette wants to merge 6 commits into
mainfrom
jsgette/fix-windows-cpython-install-runfiles

Conversation

@JSGette

@JSGette JSGette commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

As described in bazelbuild/rules_pkg#1076, Bazel creates a junction on files that is wrong as they are only supposed to be used with directories. This leads to permission errors:

PermissionError: [Errno 13] Permission denied

@JSGette JSGette self-assigned this Aug 13, 2026
@JSGette JSGette added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 13, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-build labels Aug 13, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 13, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor cf93aeb3:

Results for datadog-agent_7.84.0~devel.git.193.0b64802.pipeline.131253026-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.193.0b64802.pipeline.131253026-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cf93aeb
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 760.081 MiB
agent_deb_amd64_fips 712.942 MiB
agent_heroku_amd64 312.420 MiB
agent_msi 643.509 MiB
agent_rpm_amd64 760.065 MiB
agent_rpm_amd64_fips 712.925 MiB
agent_rpm_arm64 735.964 MiB
agent_rpm_arm64_fips 692.151 MiB
agent_suse_amd64 760.065 MiB
agent_suse_amd64_fips 712.925 MiB
agent_suse_arm64 735.964 MiB
agent_suse_arm64_fips 692.151 MiB
docker_agent_amd64 818.697 MiB
docker_agent_arm64 819.640 MiB
docker_agent_jmx_amd64 1009.594 MiB
docker_agent_jmx_arm64 999.190 MiB
docker_cluster_agent_amd64 210.475 MiB
docker_cluster_agent_arm64 223.456 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.482 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.814 MiB
docker_host_profiler_arm64 317.125 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.467 MiB
iot_agent_deb_arm64 43.120 MiB
iot_agent_deb_armhf 43.907 MiB
iot_agent_rpm_amd64 46.468 MiB
iot_agent_suse_amd64 46.467 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 13, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: cef98c14-8bdc-4b30-abfe-e4e2b3c37e5c

Baseline: cf93aeb
Comparison: 0b64802
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.33 [+0.08, +0.58] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.30 [-0.59, +1.18] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.29 [+0.17, +0.41] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.22 [+0.10, +0.34] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.09 [+0.02, +0.17] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.05 [-0.06, +0.15] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.19 [-0.23, -0.15] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.31 [-0.46, -0.16] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.82MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 740.22KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 515.63MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.95MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.80MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 356.45 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 388.59MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.13MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 27.37 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 325.67MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.91 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 304.96MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.75 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 308.98MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Aug 13, 2026
@JSGette
JSGette marked this pull request as ready for review August 14, 2026 08:30
@JSGette
JSGette requested a review from a team as a code owner August 14, 2026 08:30
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Aug 14, 2026
Comment thread bazel/patches/rules_pkg-windows-junction-copy.patch Outdated
Suggested by @alopezz: realpath resolves reparse points on Windows
and symlinks on Unix, removing the need for sys.platform conditional
and os.readlink try/except.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants