-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add tailscale in devcontainer #54896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,9 @@ | |
| set -euo pipefail | ||
| featureDir=$(cd "$(dirname "$0")"; pwd) | ||
|
|
||
| # Get claude from the buildimages /root/.local/bin | ||
| # cp /root/.local/bin/claude /home/bits/.local/bin/claude | ||
| # Install tailscale so workspace devcontainers can connect to the Headscale | ||
| # overlay network and reach agent-sandbox private VMs | ||
| curl -fsSL https://tailscale.com/install.sh | sh | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Every devcontainer prebuild now executes whatever Useful? React with 👍 / 👎. |
||
|
|
||
| # Add bits user to the docker group. This should probably be handled by the base feature. But not working for now. | ||
| usermod -aG docker bits | ||
|
|
||
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually tested this manually before opening the PR. We ran tailscaled inside the devcontainer without any /dev/net/tun device mount and it worked end to end -- tailscale status showed connected, we could ping the subnet router, SSH to an agent sandbox VM returned permission denied (correct, SSH worked but Kevin's key was needed), and curl to the fakeintake ECS service returned live data. The existing SYS_ADMIN + apparmor:unconfined capabilities in the devcontainer already grant access to /dev/net/tun without needing an explicit device mount.