Skip to content

[AGENTRUN-1450][AGENTRUN-1451] fix(e2e): use go:embed for shared library files to fix working-dir flake - #54917

Open
pgimalac wants to merge 2 commits into
mainfrom
fix/shared-library-e2e-embed
Open

[AGENTRUN-1450][AGENTRUN-1451] fix(e2e): use go:embed for shared library files to fix working-dir flake#54917
pgimalac wants to merge 2 commits into
mainfrom
fix/shared-library-e2e-embed

Conversation

@pgimalac

@pgimalac pgimalac commented Aug 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Switches the shared library E2E tests from os.ReadFile (relative path) to //go:embed for the .so/.dll binaries.

Motivation

TestLinuxSharedLibraryCheckSuite and TestWindowsSharedLibraryCheckSuite fail because os.ReadFile uses a relative path that breaks when the working directory changes (regression from #54887). //go:embed bakes the files in at compile time, removing the dependency — same pattern already used for minimal_conf.yaml in this file.

Describe how you validated your changes

CI

Additional Notes

@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 14, 2026
@pgimalac pgimalac changed the title fix(e2e): use go:embed for shared library files to fix working-dir flake [AGENTRUN-1450][AGENTRUN-1451] fix(e2e): use go:embed for shared library files to fix working-dir flake Aug 14, 2026
@pgimalac pgimalac added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 14, 2026
@pgimalac
pgimalac marked this pull request as ready for review August 14, 2026 17:01
@pgimalac
pgimalac requested review from a team as code owners August 14, 2026 17:01
@pgimalac
pgimalac requested a review from jeremy-hanna August 14, 2026 17:01
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Aug 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor a614467d:

Results for datadog-agent_7.84.0~devel.git.219.508c0a2.pipeline.131152378-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.219.508c0a2.pipeline.131152378-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a614467
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 759.674 MiB
agent_deb_amd64_fips 712.535 MiB
agent_heroku_amd64 312.013 MiB
agent_msi 643.658 MiB
agent_rpm_amd64 759.657 MiB
agent_rpm_amd64_fips 712.518 MiB
agent_rpm_arm64 735.422 MiB
agent_rpm_arm64_fips 691.609 MiB
agent_suse_amd64 759.657 MiB
agent_suse_amd64_fips 712.518 MiB
agent_suse_arm64 735.422 MiB
agent_suse_arm64_fips 691.609 MiB
docker_agent_amd64 818.289 MiB
docker_agent_arm64 819.098 MiB
docker_agent_jmx_amd64 1009.187 MiB
docker_agent_jmx_arm64 998.648 MiB
docker_cluster_agent_amd64 210.475 MiB
docker_cluster_agent_arm64 223.456 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.482 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.814 MiB
docker_host_profiler_arm64 317.125 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.475 MiB
iot_agent_deb_arm64 43.127 MiB
iot_agent_deb_armhf 43.910 MiB
iot_agent_rpm_amd64 46.476 MiB
iot_agent_suse_amd64 46.475 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 14, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 339ad452-3a04-45e7-9a62-264cd19300ce

Baseline: a614467
Comparison: 508c0a2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_idle memory utilization +0.21 [+0.10, +0.31] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.03 [-0.11, +0.18] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.03 [-0.11, +0.04] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.04 [-0.16, +0.08] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.08 [-0.12, -0.04] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.17 [-0.28, -0.05] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.33 [-1.21, +0.54] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.01 [-1.26, -0.76] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.91MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 743.62KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 513.85MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 209.01MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.19MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 421.82 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 398.01MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.66MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 30.49 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 325.32MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 71.38 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 307.65MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.81 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 312.80MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

@aiuto

aiuto commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

/trigger-ci --variable RUN_E2E_TESTS=on

@gh-worker-devflow-routing-ef8351

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-14 18:14:28 UTC ℹ️ Start processing command /trigger-ci --variable RUN_E2E_TESTS=on
If you need support, contact us on Slack #ci-infra-support!


2026-08-14 18:16:31 UTC 🚨 Devflow

child workflow execution error (type: devtools.Devtools_TriggerCiFromPr, workflowID: 2bea1708-a928-4cbf-b6fa-6a838c44852c_38, runID: 01a0017b-8927-71e7-ae83-357141948f46, initiatedEventID: 38, startedEventID: 39): child workflow execution error (type: devtools.Devtools_TriggerCi, workflowID: 01a0017b-8927-71e7-ae83-357141948f46_14, runID: 01a0017b-8dcb-7b71-9d43-25ae65b2aedc, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose)

If you need support, contact us on Slack #ci-infra-support with those details!

@aiuto

aiuto commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

/trigger-ci -h

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-14 18:18:27 UTC ℹ️ Start processing command /trigger-ci -h


2026-08-14 18:18:28 UTC ℹ️ Help: trigger-ci

Trigger a Gitlab pipeline

  • -h, --help Display help for this command
  • -v, --variable stringToString 'key=value' variables forwarded to the pipeline (support multiple flags) (default [])
  • -w, --watch Get notified when pipeline completes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build team/agent-runtimes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants