Skip service discovery system-probe calls in cluster check runners

[mrdoggopat]

What does this PR do?

Stops the Agent from attempting to reach a local system-probe socket when running as a Cluster Checks Runner (CCR), caused by: #48000

Cluster Checks Runners are Deployment replicas, not DaemonSets, so they are never colocated with a system-probe on the same node and have no hostPath mount for its socket (/opt/datadog-agent/run/sysprobe.sock). Despite that, the workloadmeta process collector's service-discovery goroutine unconditionally queried system-probe's /services endpoint on CCR, which can never succeed there, and kept retrying on every collection interval, logging a no such file or directory error each time.

This PR adds a helper.IsCLCRunner(...) guard to isServiceDiscoveryEnabled() in comp/core/workloadmeta/collectors/internal/process/process_collector.go, so service discovery is treated as disabled on CCR regardless of the discovery.enabled system-probe config setting. This only gates the service-discovery goroutine and its system-probe calls; process collection, language detection, and GPU monitoring are unaffected.

There is no change in behavior for the node Agent or Cluster Agent. The guard is scoped to helper.IsCLCRunner(...).

Motivation

CONS-8502

Cluster Checks Runners have always attempted to query system-probe for service discovery on startup and on every collection interval, even though they're fundamentally incapable of reaching it (no local system-probe socket, since CCR isn't colocated per-node). This produces recurring ERROR logs about the missing socket, with no chance of ever succeeding.

Describe how you validated your changes

• Added a unit test case in TestStartConfiguration (process_collector_test.go) verifying that clc_runner_enabled: true with config_providers: [clusterchecks] disables the collector even when discovery.enabled: true.
• Built a test image and deployed it as a real CCR pod in a cluster to reproduce and validate.

[datadog-prod-us1-4]

More details

Official Helm and Operator CCR manifests satisfy the exact IsCLCRunner predicate, and the new guard controls both collector enablement and service-goroutine startup. Process, language-detection, and GPU paths remain independently gated, so no behavioral regression is evident.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Datadog Autotest · Commit c26178c · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest}

[datadog-prod-us1-4]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.39% (+0.05%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c26178c | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor afcc03c4:

Results for datadog-agent_7.84.0~devel.git.201.c26178c.pipeline.131082512-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.201.c26178c.pipeline.131082512-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor afcc03c
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	759.616 MiB
✅	agent_deb_amd64_fips	712.473 MiB
✅	agent_heroku_amd64	311.955 MiB
✅	agent_msi	643.578 MiB
✅	agent_rpm_amd64	759.600 MiB
✅	agent_rpm_amd64_fips	712.457 MiB
✅	agent_rpm_arm64	735.359 MiB
✅	agent_rpm_arm64_fips	691.546 MiB
✅	agent_suse_amd64	759.600 MiB
✅	agent_suse_amd64_fips	712.457 MiB
✅	agent_suse_arm64	735.359 MiB
✅	agent_suse_arm64_fips	691.546 MiB
✅	docker_agent_amd64	818.232 MiB
✅	docker_agent_arm64	819.035 MiB
✅	docker_agent_jmx_amd64	1009.129 MiB
✅	docker_agent_jmx_arm64	998.585 MiB
✅	docker_cluster_agent_amd64	210.475 MiB
✅	docker_cluster_agent_arm64	223.456 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.482 MiB
✅	docker_dogstatsd_arm64	37.560 MiB
✅	docker_host_profiler_amd64	305.814 MiB
✅	docker_host_profiler_arm64	317.125 MiB
✅	dogstatsd_deb_amd64	30.224 MiB
✅	dogstatsd_deb_arm64	28.247 MiB
✅	dogstatsd_rpm_amd64	30.224 MiB
✅	dogstatsd_suse_amd64	30.224 MiB
✅	iot_agent_deb_amd64	46.467 MiB
✅	iot_agent_deb_arm64	43.124 MiB
✅	iot_agent_deb_armhf	43.907 MiB
✅	iot_agent_rpm_amd64	46.468 MiB
✅	iot_agent_suse_amd64	46.467 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: a5dafef1-1a2f-461d-bcbd-a1ec9a35bc61

Baseline: 2d00390
Comparison: 441711e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+1.35	[+1.10, +1.60]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.64	[-0.22, +1.49]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.21	[+0.14, +0.28]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.18	[+0.13, +0.22]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.04	[-0.10, +0.19]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.01	[-0.10, +0.11]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.23	[-0.36, -0.10]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.24	[-0.36, -0.12]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	171.05MiB ≤ 178MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	736.49KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 = 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	517.22MiB ≤ 538MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	19 ≤ 40	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	210.97MiB ≤ 229MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.20MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	358.75 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	18 ≤ 40	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	397.18MiB ≤ 439MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.87MiB ≤ 76MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	27.62 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	328.86MiB ≤ 335MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	65.19 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	304.96MiB ≤ 314MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	20.65 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	308.22MiB ≤ 343MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.