smp experiment selection - #54933
Draft
cmetz100 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Caleb Metz <caleb.metz@datadoghq.com>
Contributor
|
@codex review |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 14, 2026
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 0 | 1 | 0 |
Updated: .gitlab/childs/smp-regression-child-pipeline.yml
Modified Jobs
.single-machine-performance-run_regression_detector
.single-machine-performance-run_regression_detector:
artifacts:
expire_in: 1 weeks
paths:
- submission_metadata
- outputs/report.md
- outputs/regression_signal.json
- outputs/bounds_check_signal.json
- outputs/junit.xml
- outputs/report.json
- outputs/decision_record.md
when: always
before_script:
- echo "BASELINE_SHA=${BASELINE_SHA}" > regression_detector.env
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
retry:
exit_codes:
- 42
max: 2
when:
- runner_system_failure
- stuck_or_timeout_failure
- unknown_failure
- api_failure
- scheduler_failure
- stale_schedule
- data_integrity_failure
script:
- DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
token)" || exit $?; export DATADOG_API_KEY
- datadog-ci tag --level job --tags smp_failure_mode:"timeout"
- mkdir outputs
- AWS_NAMED_PROFILE="single-machine-performance"
- "SMP_ACCOUNT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT account_id)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- SMP_ECR_URL=${SMP_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com
- "SMP_TEAM_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT \"${SMP_TEAM_NAME}_team_id\"\
) || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_API=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $SMP_API_URL)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_LOGIN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_TOKEN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- aws configure set aws_access_key_id "$SMP_BOT_ID" --profile ${AWS_NAMED_PROFILE}
- aws configure set aws_secret_access_key "$SMP_BOT_KEY" --profile ${AWS_NAMED_PROFILE}
- aws configure set region us-west-2 --profile ${AWS_NAMED_PROFILE}
- "aws --profile single-machine-performance s3 cp s3://smp-cli-releases/${SMP_VERSION}/x86_64-unknown-linux-musl/smp\
\ smp || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-fetch-cli\"\n exit $exit_code\n}\n"
- chmod +x smp
- source regression_detector.env
- echo "Baseline SHA is ${BASELINE_SHA}"
- echo -n "${BASELINE_SHA}" > "${CI_COMMIT_SHA}-baseline_sha"
- aws s3 cp --profile single-machine-performance --only-show-errors "${CI_COMMIT_SHA}-baseline_sha"
"s3://${SMP_TEAM_ID}-smp-artifacts/information/"
- BASELINE_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${BASELINE_SHA}-7-full-amd64
- echo "${BASELINE_SHA} | ${BASELINE_IMAGE}"
- COMPARISON_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${CI_COMMIT_SHA}-7-full-amd64
- echo "${CI_COMMIT_SHA} | ${COMPARISON_IMAGE}"
- SMP_TAGS="ci_pipeline_id=${PARENT_PIPELINE_ID},ci_job_id=${CI_JOB_ID},ci_commit_branch=${CI_COMMIT_BRANCH},purpose=agent_ci"
- echo "Tags passed through SMP are ${SMP_TAGS}"
- RUST_LOG="info,aws_config::profile::credentials=error"
- RUST_LOG_DEBUG="debug,aws_config::profile::credentials=error"
+ - "if [ \"${SELECT_EXPERIMENTS}\" == \"true\" ]; then\n export GITHUB_TOKEN=$(dd-octo-sts\
+ \ token --scope DataDog/datadog-agent --policy self.gitlab.comment-pr || true)\n\
+ \ # Resolve the PR's labels + changed files. The GitHub API calls live in the\
+ \ dda task (via\n # GithubAPI), not as curl/jq here. Empty outputs on no-PR/failure\
+ \ -> the resolver defaults.\n dda inv owners.smp-pr-context --branch \"${CI_COMMIT_BRANCH}\"\
+ \ --changed-files-out changed_files.txt --labels-out pr_labels.txt </dev/null\
+ \ \\\n || { echo \"owners.smp-pr-context failed; resolving default set.\";\
+ \ : > changed_files.txt; : > pr_labels.txt; }\n LABELS=$(cat pr_labels.txt 2>/dev/null\
+ \ || true)\n # Resolve the run set. On ANY failure or empty result, fall back\
+ \ to the always-run quality\n # gates so a selection-tooling problem (missing\
+ \ dda, resolve error, network) never silently\n # drops the gates -- the worst\
+ \ case is \"only gates run\", never \"nothing runs\".\n dda inv owners.smp-resolve\
+ \ --config-dir \"${CONFIG_DIR}\" --manifest \"${CONFIG_DIR}/selection.yaml\" --smp-bin\
+ \ ./smp --changed-files changed_files.txt --labels \"${LABELS}\" --runner container\
+ \ --exclude ebpf --out experiment_path_filter.txt </dev/null || echo \"owners.smp-resolve\
+ \ failed; falling back to quality_gates\"\n EXPERIMENT_PATH_FILTER=$(cat experiment_path_filter.txt\
+ \ 2>/dev/null || true)\n if [ -z \"${EXPERIMENT_PATH_FILTER}\" ]; then\n echo\
+ \ \"Resolve produced no filter (tooling failure or empty); falling back to quality_gates.\"\
+ \n EXPERIMENT_PATH_FILTER=\"quality_gates\"\n fi\n echo \"Experiment path\
+ \ filter: '${EXPERIMENT_PATH_FILTER}'\"\nfi\n"
- if [ "$RUN_CONFIG_ONLY" == "true" ]; then
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit-experimental-config-only\
\ \\\n--target-image ${COMPARISON_IMAGE} \\\n--target-sha ${CI_COMMIT_SHA} \\\n\
--target-config-dir ${CONFIG_DIR} \\\n--submission-metadata submission_metadata\
\ \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command\
\ failed with code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"\
job-submission\"\n exit $exit_code\n} \n"
- else
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit \\\n--baseline-image\
\ ${BASELINE_IMAGE} \\\n--comparison-image ${COMPARISON_IMAGE} \\\n--baseline-sha\
\ ${BASELINE_SHA} \\\n--comparison-sha ${CI_COMMIT_SHA} \\\n--target-config-dir\
+ \ ${CONFIG_DIR} \\\n${EXPERIMENT_PATH_FILTER:+--experiment-path-filter \"${EXPERIMENT_PATH_FILTER}\"\
- \ ${CONFIG_DIR} \\\n--submission-metadata submission_metadata \\\n--tags ${SMP_TAGS}\
? ^^^^^^^^^^^^ ------------
+ \ --runner container} \\\n--submission-metadata submission_metadata \\\n--tags\
? ^^^^^^^^^^^^^^^^^^
- \ || {\n exit_code=$?\n echo \"smp job submit command failed with code $exit_code\"\
? ---------------- --
+ \ ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command failed with\
? ++++++++++++
- \n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\n exit\
? --------
+ \ code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\
? +++++++++++++++++++
- \ $exit_code\n} \n"
+ \n exit $exit_code\n} \n"
? +++++++
- fi
- SMP_JOB_ID=$(jq -r '.jobId' submission_metadata)
- echo "SMP Job Id is ${SMP_JOB_ID}"
- datadog-ci tag --level job --tags smp_job_id:${SMP_JOB_ID}
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob status \\\n--wait \\\n--wait-delay-seconds\
\ 60 \\\n--submission-metadata submission_metadata || {\n exit_code=$?\n echo\
\ \"smp job status command failed with code $exit_code\"\n datadog-ci tag --level\
\ job --tags smp_failure_mode:\"job-status\"\n exit $exit_code\n}\n"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob sync \\\n--submission-metadata\
\ submission_metadata \\\n--output-path outputs || {\n exit_code=$?\n echo \"\
smp job sync command failed with code $exit_code\"\n datadog-ci tag --level job\
\ --tags smp_failure_mode:\"job-sync\"\n exit $exit_code\n}\n"
- cat outputs/report.md | sed "s/^\$/$(echo -ne '\uFEFF\u00A0\u200B')/g"
- datadog-ci junit upload --service datadog-agent outputs/junit.xml
- datadog-ci tag --level job --tags smp_failure_mode:"none"
- datadog-ci tag --level job --tags smp_optimization_goal:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal regression-detector || {\n exit_code=$?\n echo\
\ \"smp regression detector has detected a regression\"\n datadog-ci tag --level\
\ job --tags smp_optimization_goal:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_bounds_check:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal bounds-check || {\n exit_code=$?\n echo \"smp\
\ regression detector has detected a failed bounds check\"\n datadog-ci tag --level\
\ job --tags smp_bounds_check:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_quality_gates:"failed"
- "python3 <<'EOF'\nimport json\nimport sys\n\ntry:\n with open('outputs/report.json')\
\ as f:\n data = json.load(f)\nexcept FileNotFoundError:\n print(\"\
Machine readable report not found.\")\n sys.exit(1)\nexcept json.JSONDecodeError\
\ as e:\n print(f\"Error parsing JSON report: {e}\")\n sys.exit(1)\n\nexperiments\
\ = data.get('experiments', {})\nfailed = False\ndecision_record = []\n\nfor exp_name,\
\ exp_data in experiments.items():\n if exp_name.startswith('quality_gate_'):\n\
\ bounds_checks = exp_data.get('bounds_checks', {})\n for check_name,\
\ check_data in bounds_checks.items():\n results = check_data.get('results',\
\ {})\n comparison = results.get('comparison', [])\n num_total\
\ = len(comparison)\n failed_replicates = [\n replicate\
\ for replicate in comparison if not replicate.get('passed', False)\n \
\ ]\n num_failed = len(failed_replicates)\n num_passed\
\ = num_total - num_failed\n if failed_replicates:\n \
\ decision_record.append(\n f\"- **{exp_name}**, bounds check\
\ **{check_name}**: {num_passed}/{num_total} replicas passed. Failed {num_failed}\
\ which is > 0. Gate **FAILED**.\"\n )\n failed\
\ = True\n else:\n decision_record.append(\n \
\ f\"- **{exp_name}**, bounds check **{check_name}**: {num_passed}/{num_total}\
\ replicas passed. Gate passed.\"\n )\n\nwith open('outputs/decision_record.md',\
\ 'w') as f:\n # Extra newline since this is appended to another report\n \
\ f.write('\\n\\n## CI Pass/Fail Decision\\n\\n')\n if failed:\n f.write('\u274C\
\ **Failed.** Some Quality Gates were violated.\\n\\n')\n f.write('\\n'.join(decision_record))\n\
\ else:\n f.write('\u2705 **Passed.** All Quality Gates passed.\\n\\\
n')\n f.write('\\n'.join(decision_record))\n\nif failed:\n print(\"\
Quality gate failed, see decision record\")\n sys.exit(1)\nelse:\n print(\"\
Quality gate passed.\")\n sys.exit(0)\nEOF\n"
- datadog-ci tag --level job --tags smp_quality_gates:"passed"
stage: functional_test
tags:
- arch:amd64
- specific:true
timeout: 1h10m.smp_job_submit
.smp_job_submit:
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API} --aws-named-profile\
\ ${AWS_NAMED_PROFILE} \\\njob submit \\\n--baseline-image ${BASELINE_IMAGE} \\\n\
--comparison-image ${COMPARISON_IMAGE} \\\n--baseline-sha ${BASELINE_SHA} \\\n--comparison-sha\
- \ ${CI_COMMIT_SHA} \\\n--target-config-dir ${CONFIG_DIR} \\\n--submission-metadata\
- \ submission_metadata \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp\
- \ job submit command failed with code $exit_code\"\n datadog-ci tag --level job\
+ \ ${CI_COMMIT_SHA} \\\n--target-config-dir ${CONFIG_DIR} \\\n${EXPERIMENT_PATH_FILTER:+--experiment-path-filter\
+ \ \"${EXPERIMENT_PATH_FILTER}\" --runner container} \\\n--submission-metadata submission_metadata\
+ \ \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command failed\
+ \ with code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"\
- \ --tags smp_failure_mode:\"job-submission\"\n exit $exit_code\n} \n"
? ----------------------------
+ job-submission\"\n exit $exit_code\n} \n"single-machine-performance-metal-runners-regression_detector
single-machine-performance-metal-runners-regression_detector:
allow_failure: true
artifacts:
expire_in: 1 weeks
paths:
- submission_metadata
- outputs/report.md
- outputs/regression_signal.json
- outputs/bounds_check_signal.json
- outputs/junit.xml
- outputs/report.json
- outputs/decision_record.md
when: always
before_script:
- echo "BASELINE_SHA=${BASELINE_SHA}" > regression_detector.env
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
retry:
exit_codes:
- 42
max: 2
when:
- runner_system_failure
- stuck_or_timeout_failure
- unknown_failure
- api_failure
- scheduler_failure
- stale_schedule
- data_integrity_failure
script:
- DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
token)" || exit $?; export DATADOG_API_KEY
- datadog-ci tag --level job --tags smp_failure_mode:"timeout"
- mkdir outputs
- AWS_NAMED_PROFILE="single-machine-performance"
- "SMP_ACCOUNT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT account_id)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- SMP_ECR_URL=${SMP_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com
- "SMP_TEAM_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT \"${SMP_TEAM_NAME}_team_id\"\
) || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_API=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $SMP_API_URL)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_LOGIN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_TOKEN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- aws configure set aws_access_key_id "$SMP_BOT_ID" --profile ${AWS_NAMED_PROFILE}
- aws configure set aws_secret_access_key "$SMP_BOT_KEY" --profile ${AWS_NAMED_PROFILE}
- aws configure set region us-west-2 --profile ${AWS_NAMED_PROFILE}
- "aws --profile single-machine-performance s3 cp s3://smp-cli-releases/${SMP_VERSION}/x86_64-unknown-linux-musl/smp\
\ smp || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-fetch-cli\"\n exit $exit_code\n}\n"
- chmod +x smp
- source regression_detector.env
- echo "Baseline SHA is ${BASELINE_SHA}"
- echo -n "${BASELINE_SHA}" > "${CI_COMMIT_SHA}-baseline_sha"
- aws s3 cp --profile single-machine-performance --only-show-errors "${CI_COMMIT_SHA}-baseline_sha"
"s3://${SMP_TEAM_ID}-smp-artifacts/information/"
- BASELINE_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${BASELINE_SHA}-7-full-amd64
- echo "${BASELINE_SHA} | ${BASELINE_IMAGE}"
- COMPARISON_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${CI_COMMIT_SHA}-7-full-amd64
- echo "${CI_COMMIT_SHA} | ${COMPARISON_IMAGE}"
- SMP_TAGS="ci_pipeline_id=${PARENT_PIPELINE_ID},ci_job_id=${CI_JOB_ID},ci_commit_branch=${CI_COMMIT_BRANCH},purpose=agent_ci"
- echo "Tags passed through SMP are ${SMP_TAGS}"
- RUST_LOG="info,aws_config::profile::credentials=error"
- RUST_LOG_DEBUG="debug,aws_config::profile::credentials=error"
+ - "if [ \"${SELECT_EXPERIMENTS}\" == \"true\" ]; then\n export GITHUB_TOKEN=$(dd-octo-sts\
+ \ token --scope DataDog/datadog-agent --policy self.gitlab.comment-pr || true)\n\
+ \ # Resolve the PR's labels + changed files. The GitHub API calls live in the\
+ \ dda task (via\n # GithubAPI), not as curl/jq here. Empty outputs on no-PR/failure\
+ \ -> the resolver defaults.\n dda inv owners.smp-pr-context --branch \"${CI_COMMIT_BRANCH}\"\
+ \ --changed-files-out changed_files.txt --labels-out pr_labels.txt </dev/null\
+ \ \\\n || { echo \"owners.smp-pr-context failed; resolving default set.\";\
+ \ : > changed_files.txt; : > pr_labels.txt; }\n LABELS=$(cat pr_labels.txt 2>/dev/null\
+ \ || true)\n # Resolve the run set. On ANY failure or empty result, fall back\
+ \ to the always-run quality\n # gates so a selection-tooling problem (missing\
+ \ dda, resolve error, network) never silently\n # drops the gates -- the worst\
+ \ case is \"only gates run\", never \"nothing runs\".\n dda inv owners.smp-resolve\
+ \ --config-dir \"${CONFIG_DIR}\" --manifest \"${CONFIG_DIR}/selection.yaml\" --smp-bin\
+ \ ./smp --changed-files changed_files.txt --labels \"${LABELS}\" --runner container\
+ \ --exclude ebpf --out experiment_path_filter.txt </dev/null || echo \"owners.smp-resolve\
+ \ failed; falling back to quality_gates\"\n EXPERIMENT_PATH_FILTER=$(cat experiment_path_filter.txt\
+ \ 2>/dev/null || true)\n if [ -z \"${EXPERIMENT_PATH_FILTER}\" ]; then\n echo\
+ \ \"Resolve produced no filter (tooling failure or empty); falling back to quality_gates.\"\
+ \n EXPERIMENT_PATH_FILTER=\"quality_gates\"\n fi\n echo \"Experiment path\
+ \ filter: '${EXPERIMENT_PATH_FILTER}'\"\nfi\n"
- if [ "$RUN_CONFIG_ONLY" == "true" ]; then
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit-experimental-config-only\
\ \\\n--target-image ${COMPARISON_IMAGE} \\\n--target-sha ${CI_COMMIT_SHA} \\\n\
--target-config-dir ${CONFIG_DIR} \\\n--submission-metadata submission_metadata\
\ \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command\
\ failed with code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"\
job-submission\"\n exit $exit_code\n} \n"
- else
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit \\\n--baseline-image\
\ ${BASELINE_IMAGE} \\\n--comparison-image ${COMPARISON_IMAGE} \\\n--baseline-sha\
\ ${BASELINE_SHA} \\\n--comparison-sha ${CI_COMMIT_SHA} \\\n--target-config-dir\
+ \ ${CONFIG_DIR} \\\n${EXPERIMENT_PATH_FILTER:+--experiment-path-filter \"${EXPERIMENT_PATH_FILTER}\"\
- \ ${CONFIG_DIR} \\\n--submission-metadata submission_metadata \\\n--tags ${SMP_TAGS}\
? ^^^^^^^^^^^^ ------------
+ \ --runner container} \\\n--submission-metadata submission_metadata \\\n--tags\
? ^^^^^^^^^^^^^^^^^^
- \ || {\n exit_code=$?\n echo \"smp job submit command failed with code $exit_code\"\
? ---------------- --
+ \ ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command failed with\
? ++++++++++++
- \n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\n exit\
? --------
+ \ code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\
? +++++++++++++++++++
- \ $exit_code\n} \n"
+ \n exit $exit_code\n} \n"
? +++++++
- fi
- SMP_JOB_ID=$(jq -r '.jobId' submission_metadata)
- echo "SMP Job Id is ${SMP_JOB_ID}"
- datadog-ci tag --level job --tags smp_job_id:${SMP_JOB_ID}
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob status \\\n--wait \\\n--wait-delay-seconds\
\ 60 \\\n--submission-metadata submission_metadata || {\n exit_code=$?\n echo\
\ \"smp job status command failed with code $exit_code\"\n datadog-ci tag --level\
\ job --tags smp_failure_mode:\"job-status\"\n exit $exit_code\n}\n"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob sync \\\n--submission-metadata\
\ submission_metadata \\\n--output-path outputs || {\n exit_code=$?\n echo \"\
smp job sync command failed with code $exit_code\"\n datadog-ci tag --level job\
\ --tags smp_failure_mode:\"job-sync\"\n exit $exit_code\n}\n"
- cat outputs/report.md | sed "s/^\$/$(echo -ne '\uFEFF\u00A0\u200B')/g"
- datadog-ci junit upload --service datadog-agent outputs/junit.xml
- datadog-ci tag --level job --tags smp_failure_mode:"none"
- datadog-ci tag --level job --tags smp_optimization_goal:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal regression-detector || {\n exit_code=$?\n echo\
\ \"smp regression detector has detected a regression\"\n datadog-ci tag --level\
\ job --tags smp_optimization_goal:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_bounds_check:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal bounds-check || {\n exit_code=$?\n echo \"smp\
\ regression detector has detected a failed bounds check\"\n datadog-ci tag --level\
\ job --tags smp_bounds_check:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_quality_gates:"failed"
- "python3 <<'EOF'\nimport json\nimport sys\n\ntry:\n with open('outputs/report.json')\
\ as f:\n data = json.load(f)\nexcept FileNotFoundError:\n print(\"\
Machine readable report not found.\")\n sys.exit(1)\nexcept json.JSONDecodeError\
\ as e:\n print(f\"Error parsing JSON report: {e}\")\n sys.exit(1)\n\nexperiments\
\ = data.get('experiments', {})\nfailed = False\ndecision_record = []\n\nfor exp_name,\
\ exp_data in experiments.items():\n if exp_name.startswith('quality_gate_'):\n\
\ bounds_checks = exp_data.get('bounds_checks', {})\n for check_name,\
\ check_data in bounds_checks.items():\n results = check_data.get('results',\
\ {})\n comparison = results.get('comparison', [])\n num_total\
\ = len(comparison)\n failed_replicates = [\n replicate\
\ for replicate in comparison if not replicate.get('passed', False)\n \
\ ]\n num_failed = len(failed_replicates)\n num_passed\
\ = num_total - num_failed\n if failed_replicates:\n \
\ decision_record.append(\n f\"- **{exp_name}**, bounds check\
\ **{check_name}**: {num_passed}/{num_total} replicas passed. Failed {num_failed}\
\ which is > 0. Gate **FAILED**.\"\n )\n failed\
\ = True\n else:\n decision_record.append(\n \
\ f\"- **{exp_name}**, bounds check **{check_name}**: {num_passed}/{num_total}\
\ replicas passed. Gate passed.\"\n )\n\nwith open('outputs/decision_record.md',\
\ 'w') as f:\n # Extra newline since this is appended to another report\n \
\ f.write('\\n\\n## CI Pass/Fail Decision\\n\\n')\n if failed:\n f.write('\u274C\
\ **Failed.** Some Quality Gates were violated.\\n\\n')\n f.write('\\n'.join(decision_record))\n\
\ else:\n f.write('\u2705 **Passed.** All Quality Gates passed.\\n\\\
n')\n f.write('\\n'.join(decision_record))\n\nif failed:\n print(\"\
Quality gate failed, see decision record\")\n sys.exit(1)\nelse:\n print(\"\
Quality gate passed.\")\n sys.exit(0)\nEOF\n"
- datadog-ci tag --level job --tags smp_quality_gates:"passed"
stage: functional_test
tags:
- arch:amd64
- specific:true
timeout: 1h10m
variables:
BOT_LOGIN: bot_login_metal-runners
BOT_TOKEN: bot_token_metal-runners
CONFIG_DIR: test/regression/ebpf
SMP_API_URL: metal-runners_api_url
SMP_TEAM_NAME: metal-runners
SMP_VERSION: v0.27.0-nightly.20260423T145046Z
when: manualsingle-machine-performance-metal-runners-regression_detector_cfg
single-machine-performance-metal-runners-regression_detector_cfg:
allow_failure: true
artifacts:
expire_in: 1 weeks
paths:
- submission_metadata
- outputs/report.md
- outputs/regression_signal.json
- outputs/bounds_check_signal.json
- outputs/junit.xml
- outputs/report.json
- outputs/decision_record.md
when: always
before_script:
- echo "BASELINE_SHA=${BASELINE_SHA}" > regression_detector.env
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
retry:
exit_codes:
- 42
max: 2
when:
- runner_system_failure
- stuck_or_timeout_failure
- unknown_failure
- api_failure
- scheduler_failure
- stale_schedule
- data_integrity_failure
script:
- DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
token)" || exit $?; export DATADOG_API_KEY
- datadog-ci tag --level job --tags smp_failure_mode:"timeout"
- mkdir outputs
- AWS_NAMED_PROFILE="single-machine-performance"
- "SMP_ACCOUNT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT account_id)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- SMP_ECR_URL=${SMP_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com
- "SMP_TEAM_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT \"${SMP_TEAM_NAME}_team_id\"\
) || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_API=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $SMP_API_URL)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_LOGIN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_TOKEN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- aws configure set aws_access_key_id "$SMP_BOT_ID" --profile ${AWS_NAMED_PROFILE}
- aws configure set aws_secret_access_key "$SMP_BOT_KEY" --profile ${AWS_NAMED_PROFILE}
- aws configure set region us-west-2 --profile ${AWS_NAMED_PROFILE}
- "aws --profile single-machine-performance s3 cp s3://smp-cli-releases/${SMP_VERSION}/x86_64-unknown-linux-musl/smp\
\ smp || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-fetch-cli\"\n exit $exit_code\n}\n"
- chmod +x smp
- source regression_detector.env
- echo "Baseline SHA is ${BASELINE_SHA}"
- echo -n "${BASELINE_SHA}" > "${CI_COMMIT_SHA}-baseline_sha"
- aws s3 cp --profile single-machine-performance --only-show-errors "${CI_COMMIT_SHA}-baseline_sha"
"s3://${SMP_TEAM_ID}-smp-artifacts/information/"
- BASELINE_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${BASELINE_SHA}-7-full-amd64
- echo "${BASELINE_SHA} | ${BASELINE_IMAGE}"
- COMPARISON_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${CI_COMMIT_SHA}-7-full-amd64
- echo "${CI_COMMIT_SHA} | ${COMPARISON_IMAGE}"
- SMP_TAGS="ci_pipeline_id=${PARENT_PIPELINE_ID},ci_job_id=${CI_JOB_ID},ci_commit_branch=${CI_COMMIT_BRANCH},purpose=agent_ci"
- echo "Tags passed through SMP are ${SMP_TAGS}"
- RUST_LOG="info,aws_config::profile::credentials=error"
- RUST_LOG_DEBUG="debug,aws_config::profile::credentials=error"
+ - "if [ \"${SELECT_EXPERIMENTS}\" == \"true\" ]; then\n export GITHUB_TOKEN=$(dd-octo-sts\
+ \ token --scope DataDog/datadog-agent --policy self.gitlab.comment-pr || true)\n\
+ \ # Resolve the PR's labels + changed files. The GitHub API calls live in the\
+ \ dda task (via\n # GithubAPI), not as curl/jq here. Empty outputs on no-PR/failure\
+ \ -> the resolver defaults.\n dda inv owners.smp-pr-context --branch \"${CI_COMMIT_BRANCH}\"\
+ \ --changed-files-out changed_files.txt --labels-out pr_labels.txt </dev/null\
+ \ \\\n || { echo \"owners.smp-pr-context failed; resolving default set.\";\
+ \ : > changed_files.txt; : > pr_labels.txt; }\n LABELS=$(cat pr_labels.txt 2>/dev/null\
+ \ || true)\n # Resolve the run set. On ANY failure or empty result, fall back\
+ \ to the always-run quality\n # gates so a selection-tooling problem (missing\
+ \ dda, resolve error, network) never silently\n # drops the gates -- the worst\
+ \ case is \"only gates run\", never \"nothing runs\".\n dda inv owners.smp-resolve\
+ \ --config-dir \"${CONFIG_DIR}\" --manifest \"${CONFIG_DIR}/selection.yaml\" --smp-bin\
+ \ ./smp --changed-files changed_files.txt --labels \"${LABELS}\" --runner container\
+ \ --exclude ebpf --out experiment_path_filter.txt </dev/null || echo \"owners.smp-resolve\
+ \ failed; falling back to quality_gates\"\n EXPERIMENT_PATH_FILTER=$(cat experiment_path_filter.txt\
+ \ 2>/dev/null || true)\n if [ -z \"${EXPERIMENT_PATH_FILTER}\" ]; then\n echo\
+ \ \"Resolve produced no filter (tooling failure or empty); falling back to quality_gates.\"\
+ \n EXPERIMENT_PATH_FILTER=\"quality_gates\"\n fi\n echo \"Experiment path\
+ \ filter: '${EXPERIMENT_PATH_FILTER}'\"\nfi\n"
- if [ "$RUN_CONFIG_ONLY" == "true" ]; then
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit-experimental-config-only\
\ \\\n--target-image ${COMPARISON_IMAGE} \\\n--target-sha ${CI_COMMIT_SHA} \\\n\
--target-config-dir ${CONFIG_DIR} \\\n--submission-metadata submission_metadata\
\ \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command\
\ failed with code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"\
job-submission\"\n exit $exit_code\n} \n"
- else
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit \\\n--baseline-image\
\ ${BASELINE_IMAGE} \\\n--comparison-image ${COMPARISON_IMAGE} \\\n--baseline-sha\
\ ${BASELINE_SHA} \\\n--comparison-sha ${CI_COMMIT_SHA} \\\n--target-config-dir\
+ \ ${CONFIG_DIR} \\\n${EXPERIMENT_PATH_FILTER:+--experiment-path-filter \"${EXPERIMENT_PATH_FILTER}\"\
- \ ${CONFIG_DIR} \\\n--submission-metadata submission_metadata \\\n--tags ${SMP_TAGS}\
? ^^^^^^^^^^^^ ------------
+ \ --runner container} \\\n--submission-metadata submission_metadata \\\n--tags\
? ^^^^^^^^^^^^^^^^^^
- \ || {\n exit_code=$?\n echo \"smp job submit command failed with code $exit_code\"\
? ---------------- --
+ \ ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command failed with\
? ++++++++++++
- \n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\n exit\
? --------
+ \ code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\
? +++++++++++++++++++
- \ $exit_code\n} \n"
+ \n exit $exit_code\n} \n"
? +++++++
- fi
- SMP_JOB_ID=$(jq -r '.jobId' submission_metadata)
- echo "SMP Job Id is ${SMP_JOB_ID}"
- datadog-ci tag --level job --tags smp_job_id:${SMP_JOB_ID}
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob status \\\n--wait \\\n--wait-delay-seconds\
\ 60 \\\n--submission-metadata submission_metadata || {\n exit_code=$?\n echo\
\ \"smp job status command failed with code $exit_code\"\n datadog-ci tag --level\
\ job --tags smp_failure_mode:\"job-status\"\n exit $exit_code\n}\n"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob sync \\\n--submission-metadata\
\ submission_metadata \\\n--output-path outputs || {\n exit_code=$?\n echo \"\
smp job sync command failed with code $exit_code\"\n datadog-ci tag --level job\
\ --tags smp_failure_mode:\"job-sync\"\n exit $exit_code\n}\n"
- cat outputs/report.md | sed "s/^\$/$(echo -ne '\uFEFF\u00A0\u200B')/g"
- datadog-ci junit upload --service datadog-agent outputs/junit.xml
- datadog-ci tag --level job --tags smp_failure_mode:"none"
- datadog-ci tag --level job --tags smp_optimization_goal:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal regression-detector || {\n exit_code=$?\n echo\
\ \"smp regression detector has detected a regression\"\n datadog-ci tag --level\
\ job --tags smp_optimization_goal:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_bounds_check:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal bounds-check || {\n exit_code=$?\n echo \"smp\
\ regression detector has detected a failed bounds check\"\n datadog-ci tag --level\
\ job --tags smp_bounds_check:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_quality_gates:"failed"
- "python3 <<'EOF'\nimport json\nimport sys\n\ntry:\n with open('outputs/report.json')\
\ as f:\n data = json.load(f)\nexcept FileNotFoundError:\n print(\"\
Machine readable report not found.\")\n sys.exit(1)\nexcept json.JSONDecodeError\
\ as e:\n print(f\"Error parsing JSON report: {e}\")\n sys.exit(1)\n\nexperiments\
\ = data.get('experiments', {})\nfailed = False\ndecision_record = []\n\nfor exp_name,\
\ exp_data in experiments.items():\n if exp_name.startswith('quality_gate_'):\n\
\ bounds_checks = exp_data.get('bounds_checks', {})\n for check_name,\
\ check_data in bounds_checks.items():\n results = check_data.get('results',\
\ {})\n comparison = results.get('comparison', [])\n num_total\
\ = len(comparison)\n failed_replicates = [\n replicate\
\ for replicate in comparison if not replicate.get('passed', False)\n \
\ ]\n num_failed = len(failed_replicates)\n num_passed\
\ = num_total - num_failed\n if failed_replicates:\n \
\ decision_record.append(\n f\"- **{exp_name}**, bounds check\
\ **{check_name}**: {num_passed}/{num_total} replicas passed. Failed {num_failed}\
\ which is > 0. Gate **FAILED**.\"\n )\n failed\
\ = True\n else:\n decision_record.append(\n \
\ f\"- **{exp_name}**, bounds check **{check_name}**: {num_passed}/{num_total}\
\ replicas passed. Gate passed.\"\n )\n\nwith open('outputs/decision_record.md',\
\ 'w') as f:\n # Extra newline since this is appended to another report\n \
\ f.write('\\n\\n## CI Pass/Fail Decision\\n\\n')\n if failed:\n f.write('\u274C\
\ **Failed.** Some Quality Gates were violated.\\n\\n')\n f.write('\\n'.join(decision_record))\n\
\ else:\n f.write('\u2705 **Passed.** All Quality Gates passed.\\n\\\
n')\n f.write('\\n'.join(decision_record))\n\nif failed:\n print(\"\
Quality gate failed, see decision record\")\n sys.exit(1)\nelse:\n print(\"\
Quality gate passed.\")\n sys.exit(0)\nEOF\n"
- datadog-ci tag --level job --tags smp_quality_gates:"passed"
stage: functional_test
tags:
- arch:amd64
- specific:true
timeout: 1h10m
variables:
BOT_LOGIN: bot_login_metal-runners
BOT_TOKEN: bot_token_metal-runners
CONFIG_DIR: test/regression/ebpf/config-only
RUN_CONFIG_ONLY: 'true'
SMP_API_URL: metal-runners_api_url
SMP_TEAM_NAME: metal-runners
SMP_VERSION: v0.27.0-nightly.20260423T145046Z
when: manualsingle-machine-performance-regression_detector
single-machine-performance-regression_detector:
artifacts:
expire_in: 1 weeks
paths:
- submission_metadata
- outputs/report.md
- outputs/regression_signal.json
- outputs/bounds_check_signal.json
- outputs/junit.xml
- outputs/report.json
- outputs/decision_record.md
when: always
before_script:
- echo "BASELINE_SHA=${BASELINE_SHA}" > regression_detector.env
+ id_tokens:
+ DDOCTOSTS_ID_TOKEN:
+ aud: dd-octo-sts
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
retry:
exit_codes:
- 42
max: 2
when:
- runner_system_failure
- stuck_or_timeout_failure
- unknown_failure
- api_failure
- scheduler_failure
- stale_schedule
- data_integrity_failure
rules:
- allow_failure: false
if: $SMP_ALLOW_FAILURE == "false"
- allow_failure: true
when: on_success
script:
- DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
token)" || exit $?; export DATADOG_API_KEY
- datadog-ci tag --level job --tags smp_failure_mode:"timeout"
- mkdir outputs
- AWS_NAMED_PROFILE="single-machine-performance"
- "SMP_ACCOUNT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT account_id)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- SMP_ECR_URL=${SMP_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com
- "SMP_TEAM_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT \"${SMP_TEAM_NAME}_team_id\"\
) || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_API=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $SMP_API_URL)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_LOGIN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- "SMP_BOT_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SMP_ACCOUNT $BOT_TOKEN)\
\ || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-secrets\"\n exit $exit_code\n}\n"
- aws configure set aws_access_key_id "$SMP_BOT_ID" --profile ${AWS_NAMED_PROFILE}
- aws configure set aws_secret_access_key "$SMP_BOT_KEY" --profile ${AWS_NAMED_PROFILE}
- aws configure set region us-west-2 --profile ${AWS_NAMED_PROFILE}
- "aws --profile single-machine-performance s3 cp s3://smp-cli-releases/${SMP_VERSION}/x86_64-unknown-linux-musl/smp\
\ smp || {\n exit_code=$?\n datadog-ci tag --level job --tags smp_failure_mode:\"\
setup-fetch-cli\"\n exit $exit_code\n}\n"
- chmod +x smp
- source regression_detector.env
- echo "Baseline SHA is ${BASELINE_SHA}"
- echo -n "${BASELINE_SHA}" > "${CI_COMMIT_SHA}-baseline_sha"
- aws s3 cp --profile single-machine-performance --only-show-errors "${CI_COMMIT_SHA}-baseline_sha"
"s3://${SMP_TEAM_ID}-smp-artifacts/information/"
- BASELINE_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${BASELINE_SHA}-7-full-amd64
- echo "${BASELINE_SHA} | ${BASELINE_IMAGE}"
- COMPARISON_IMAGE=${SMP_ECR_URL}/${SMP_TEAM_ID}-agent:${CI_COMMIT_SHA}-7-full-amd64
- echo "${CI_COMMIT_SHA} | ${COMPARISON_IMAGE}"
- SMP_TAGS="ci_pipeline_id=${PARENT_PIPELINE_ID},ci_job_id=${CI_JOB_ID},ci_commit_branch=${CI_COMMIT_BRANCH},purpose=agent_ci"
- echo "Tags passed through SMP are ${SMP_TAGS}"
- RUST_LOG="info,aws_config::profile::credentials=error"
- RUST_LOG_DEBUG="debug,aws_config::profile::credentials=error"
+ - "if [ \"${SELECT_EXPERIMENTS}\" == \"true\" ]; then\n export GITHUB_TOKEN=$(dd-octo-sts\
+ \ token --scope DataDog/datadog-agent --policy self.gitlab.comment-pr || true)\n\
+ \ # Resolve the PR's labels + changed files. The GitHub API calls live in the\
+ \ dda task (via\n # GithubAPI), not as curl/jq here. Empty outputs on no-PR/failure\
+ \ -> the resolver defaults.\n dda inv owners.smp-pr-context --branch \"${CI_COMMIT_BRANCH}\"\
+ \ --changed-files-out changed_files.txt --labels-out pr_labels.txt </dev/null\
+ \ \\\n || { echo \"owners.smp-pr-context failed; resolving default set.\";\
+ \ : > changed_files.txt; : > pr_labels.txt; }\n LABELS=$(cat pr_labels.txt 2>/dev/null\
+ \ || true)\n # Resolve the run set. On ANY failure or empty result, fall back\
+ \ to the always-run quality\n # gates so a selection-tooling problem (missing\
+ \ dda, resolve error, network) never silently\n # drops the gates -- the worst\
+ \ case is \"only gates run\", never \"nothing runs\".\n dda inv owners.smp-resolve\
+ \ --config-dir \"${CONFIG_DIR}\" --manifest \"${CONFIG_DIR}/selection.yaml\" --smp-bin\
+ \ ./smp --changed-files changed_files.txt --labels \"${LABELS}\" --runner container\
+ \ --exclude ebpf --out experiment_path_filter.txt </dev/null || echo \"owners.smp-resolve\
+ \ failed; falling back to quality_gates\"\n EXPERIMENT_PATH_FILTER=$(cat experiment_path_filter.txt\
+ \ 2>/dev/null || true)\n if [ -z \"${EXPERIMENT_PATH_FILTER}\" ]; then\n echo\
+ \ \"Resolve produced no filter (tooling failure or empty); falling back to quality_gates.\"\
+ \n EXPERIMENT_PATH_FILTER=\"quality_gates\"\n fi\n echo \"Experiment path\
+ \ filter: '${EXPERIMENT_PATH_FILTER}'\"\nfi\n"
- if [ "$RUN_CONFIG_ONLY" == "true" ]; then
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit-experimental-config-only\
\ \\\n--target-image ${COMPARISON_IMAGE} \\\n--target-sha ${CI_COMMIT_SHA} \\\n\
--target-config-dir ${CONFIG_DIR} \\\n--submission-metadata submission_metadata\
\ \\\n--tags ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command\
\ failed with code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"\
job-submission\"\n exit $exit_code\n} \n"
- else
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob submit \\\n--baseline-image\
\ ${BASELINE_IMAGE} \\\n--comparison-image ${COMPARISON_IMAGE} \\\n--baseline-sha\
\ ${BASELINE_SHA} \\\n--comparison-sha ${CI_COMMIT_SHA} \\\n--target-config-dir\
+ \ ${CONFIG_DIR} \\\n${EXPERIMENT_PATH_FILTER:+--experiment-path-filter \"${EXPERIMENT_PATH_FILTER}\"\
- \ ${CONFIG_DIR} \\\n--submission-metadata submission_metadata \\\n--tags ${SMP_TAGS}\
? ^^^^^^^^^^^^ ------------
+ \ --runner container} \\\n--submission-metadata submission_metadata \\\n--tags\
? ^^^^^^^^^^^^^^^^^^
- \ || {\n exit_code=$?\n echo \"smp job submit command failed with code $exit_code\"\
? ---------------- --
+ \ ${SMP_TAGS} || {\n exit_code=$?\n echo \"smp job submit command failed with\
? ++++++++++++
- \n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\n exit\
? --------
+ \ code $exit_code\"\n datadog-ci tag --level job --tags smp_failure_mode:\"job-submission\"\
? +++++++++++++++++++
- \ $exit_code\n} \n"
+ \n exit $exit_code\n} \n"
? +++++++
- fi
- SMP_JOB_ID=$(jq -r '.jobId' submission_metadata)
- echo "SMP Job Id is ${SMP_JOB_ID}"
- datadog-ci tag --level job --tags smp_job_id:${SMP_JOB_ID}
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob status \\\n--wait \\\n--wait-delay-seconds\
\ 60 \\\n--submission-metadata submission_metadata || {\n exit_code=$?\n echo\
\ \"smp job status command failed with code $exit_code\"\n datadog-ci tag --level\
\ job --tags smp_failure_mode:\"job-status\"\n exit $exit_code\n}\n"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\njob sync \\\n--submission-metadata\
\ submission_metadata \\\n--output-path outputs || {\n exit_code=$?\n echo \"\
smp job sync command failed with code $exit_code\"\n datadog-ci tag --level job\
\ --tags smp_failure_mode:\"job-sync\"\n exit $exit_code\n}\n"
- cat outputs/report.md | sed "s/^\$/$(echo -ne '\uFEFF\u00A0\u200B')/g"
- datadog-ci junit upload --service datadog-agent outputs/junit.xml
- datadog-ci tag --level job --tags smp_failure_mode:"none"
- datadog-ci tag --level job --tags smp_optimization_goal:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal regression-detector || {\n exit_code=$?\n echo\
\ \"smp regression detector has detected a regression\"\n datadog-ci tag --level\
\ job --tags smp_optimization_goal:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_bounds_check:"passed"
- "RUST_LOG=\"${RUST_LOG}\" ./smp --team-id ${SMP_TEAM_ID} --api-base ${SMP_API}\
\ --aws-named-profile ${AWS_NAMED_PROFILE} \\\n job result \\\n --submission-metadata\
\ submission_metadata --signal bounds-check || {\n exit_code=$?\n echo \"smp\
\ regression detector has detected a failed bounds check\"\n datadog-ci tag --level\
\ job --tags smp_bounds_check:\"failed\"\n}\n"
- datadog-ci tag --level job --tags smp_quality_gates:"failed"
- "python3 <<'EOF'\nimport json\nimport sys\n\ntry:\n with open('outputs/report.json')\
\ as f:\n data = json.load(f)\nexcept FileNotFoundError:\n print(\"\
Machine readable report not found.\")\n sys.exit(1)\nexcept json.JSONDecodeError\
\ as e:\n print(f\"Error parsing JSON report: {e}\")\n sys.exit(1)\n\nexperiments\
\ = data.get('experiments', {})\nfailed = False\ndecision_record = []\n\nfor exp_name,\
\ exp_data in experiments.items():\n if exp_name.startswith('quality_gate_'):\n\
\ bounds_checks = exp_data.get('bounds_checks', {})\n for check_name,\
\ check_data in bounds_checks.items():\n results = check_data.get('results',\
\ {})\n comparison = results.get('comparison', [])\n num_total\
\ = len(comparison)\n failed_replicates = [\n replicate\
\ for replicate in comparison if not replicate.get('passed', False)\n \
\ ]\n num_failed = len(failed_replicates)\n num_passed\
\ = num_total - num_failed\n if failed_replicates:\n \
\ decision_record.append(\n f\"- **{exp_name}**, bounds check\
\ **{check_name}**: {num_passed}/{num_total} replicas passed. Failed {num_failed}\
\ which is > 0. Gate **FAILED**.\"\n )\n failed\
\ = True\n else:\n decision_record.append(\n \
\ f\"- **{exp_name}**, bounds check **{check_name}**: {num_passed}/{num_total}\
\ replicas passed. Gate passed.\"\n )\n\nwith open('outputs/decision_record.md',\
\ 'w') as f:\n # Extra newline since this is appended to another report\n \
\ f.write('\\n\\n## CI Pass/Fail Decision\\n\\n')\n if failed:\n f.write('\u274C\
\ **Failed.** Some Quality Gates were violated.\\n\\n')\n f.write('\\n'.join(decision_record))\n\
\ else:\n f.write('\u2705 **Passed.** All Quality Gates passed.\\n\\\
n')\n f.write('\\n'.join(decision_record))\n\nif failed:\n print(\"\
Quality gate failed, see decision record\")\n sys.exit(1)\nelse:\n print(\"\
Quality gate passed.\")\n sys.exit(0)\nEOF\n"
- datadog-ci tag --level job --tags smp_quality_gates:"passed"
stage: functional_test
tags:
- arch:amd64
- specific:true
timeout: 1h10m
variables:
BOT_LOGIN: bot_login
BOT_TOKEN: bot_token
CONFIG_DIR: test/regression
+ SELECT_EXPERIMENTS: 'true'
SMP_API_URL: api_url
SMP_TEAM_NAME: agent
- SMP_VERSION: v0.27.0
+ SMP_VERSION: dev-pr4702-6ac924e95Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 5 | 0 | 0 |
ℹ️ Diff available in the job log.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b86b077112
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| given PR is governed by a single central manifest, `selection.yaml`, which maps | ||
| **trigger buckets → experiments** (by glob, exact path, or experiment name): | ||
|
|
||
| * `always` — runs unconditionally, on every PR and in scheduled SMP runs. These |
There was a problem hiding this comment.
The always bucket is unconditional only after an SMP run has been triggered, not on every PR: the dev-branch trigger in .gitlab/test/functional_test/regression_detector.yml is still gated by .on_dev_branches_with_artifact_changes at lines 256–262, so PRs outside that change set run no quality gates. Describing this as “on every PR” gives contributors a false coverage guarantee; qualify it as every eligible/triggered SMP run.
AGENTS.md reference: AGENTS.md:L190-L192
Useful? React with 👍 / 👎.
Comment on lines
43
to
+46
| Use `.agents/skills/explain-lading-config/scripts/resolve-lading-config.sh` to | ||
| avoid ad-hoc matching. The script enumerates experiments under | ||
| `test/regression/cases/` (active) and `test/regression/x-disabled-cases/` | ||
| (disabled). Each experiment is a `<case>/lading/lading.yaml` addressed by its | ||
| case-directory name; disabled rows are flagged with a trailing `(disabled)` | ||
| column in the listing. `ebpf/cases/` (split-mode) and | ||
| `ebpf/config-only/cases/` are intentionally out of scope; if a user asks about | ||
| avoid ad-hoc matching. The script enumerates experiments under any `cases/` | ||
| directory within `test/regression/` (e.g. `quality_gates/cases/`, | ||
| `logs/<group>/cases/`) and `test/regression/x-disabled-cases/` (disabled). Each |
There was a problem hiding this comment.
Skill review score: Description 19/25, Writing philosophy 19/25, Structure/progressive disclosure 25/25, Output/examples 18/25; total 81/100. Top improvements: (1) declare the owning team as required for AI artifacts, (2) add a concrete sample invocation and resulting explanation so the output contract is directly visible, and (3) consider replacing the now 207-line shell resolver with Python or Go to keep its expanded discovery behavior easier to understand and maintain. Overall recommendation: Approve.
AGENTS.md reference: AGENTS.md:L169-L169
Useful? React with 👍 / 👎.
Contributor
Files inventory check summaryFile checks results against ancestor 2d00390b: Results for datadog-agent_7.84.0~devel.git.213.b86b077.pipeline.131107318-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.213.b86b077.pipeline.131107318-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates 33 successful checks with minimal change (< 2 KiB)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 2d00390 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_security_idle | memory utilization | +0.35 | [+0.24, +0.45] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.29 | [+0.17, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_mean_fs_load | memory utilization | +0.10 | [+0.03, +0.18] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.06 | [+0.01, +0.10] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.07 | [-0.32, +0.18] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_private_action_runner | memory utilization | -0.23 | [-0.35, -0.11] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.33 | [-1.20, +0.55] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_no_fs_load | memory utilization | -0.36 | [-0.50, -0.21] | 1 | Logs bounds checks dashboard |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ❌ | quality_gate_idle | memory_usage | 0/10 | 174.40MiB > 154MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 741.23KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ❌ | quality_gate_idle_all_features | memory_usage | 7/10 | 516.63MiB > 512MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.13MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 17 ≤ 40 | bounds checks dashboard |
| ❌ | quality_gate_logs | memory_usage | 2/10 | 203.30MiB > 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.22MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 362.41 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 18 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 406.80MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
| ✅ | quality_gate_private_action_runner | memory_usage | 10/10 | 72.23MiB ≤ 75MiB | bounds checks dashboard |
| ✅ | quality_gate_security_idle | cpu_usage | 10/10 | 28.56 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_idle | memory_usage | 10/10 | 328.70MiB ≤ 330MiB | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | cpu_usage | 10/10 | 63.41 ≤ 200 | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | memory_usage | 10/10 | 307.01MiB ≤ 310MiB | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | cpu_usage | 10/10 | 21.40 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | memory_usage | 10/10 | 309.21MiB ≤ 320MiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 7/10 replicas passed. Failed 3 which is > 0. Gate FAILED.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 2/10 replicas passed. Failed 8 which is > 0. Gate FAILED.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pr-driven experiment selection for smp regression tests. instead of a fixed suite, a central selection.yaml maps experiments to when they run — always, on codeowners involvement, or behind a label.
The smp cli does the actual resolving, ci just wires it up. Also moves the quality gates under quality_gates/ and drops them in the always bucket.
base of a 3-pr stack, the real logs experiments get added on top. why/how is in test/regression/adr-experiment-selection.md + experiment-selection-guide.md.
Motivation
Describe how you validated your changes
Additional Notes