Skip to content

[EBPF] Exclude Host Profiler from library uprobes - #54937

Open
Gandem wants to merge 1 commit into
mainfrom
nayef/exclude-host-profiler-uprobes
Open

[EBPF] Exclude Host Profiler from library uprobes#54937
Gandem wants to merge 1 commit into
mainfrom
nayef/exclude-host-profiler-uprobes

Conversation

@Gandem

@Gandem Gandem commented Aug 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

  • Makes the event-driven UprobeAttacher.AttachLibrary path honor ExcludeInternal before registering a library.
  • Classifies the packaged host-profiler binary as an internal Datadog process.
  • Shares executable resolution and error classification between process and library attachment paths.
  • Adds coverage for Host Profiler exclusion, normal-process attachment, opt-out behavior, and exited-process handling.

Motivation

Host Profiler inspects shared libraries mapped by other processes. The shared-library watcher attributes successful opens to the opener, so native TLS library opens can be associated with the long-lived Host Profiler PID. Since AttachLibrary did not enforce ExcludeInternal, those references could keep uprobe registrations and system-probe file descriptors alive until Host Profiler exited.

Describe how you validated your changes

  • gofmt is clean for the changed Go files.
  • git diff --check passes.
  • Added focused unit tests in pkg/ebpf/uprobes/attacher_test.go.
  • Two independent static reviews found no correctness issues; one cleanup finding was applied.
  • Attempted dda inv test --targets=./pkg/ebpf/uprobes, but the sandbox blocked Bazel dependency access with Operation not permitted while fetching https://bcr.bazel.build/. CI validation is required.

Additional Notes

No release note because Host Profiler remains in preview. This PR intentionally leaves the generic shared-library watcher unchanged; filtering is enforced at the attacher policy boundary.

@Gandem
Gandem requested a review from a team as a code owner August 14, 2026 21:38
@Gandem
Gandem requested review from a team August 14, 2026 21:38
@Gandem Gandem added the changelog/no-changelog No changelog entry needed label Aug 14, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/ebpf-platform labels Aug 14, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Aug 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 2d00390b:

Results for datadog-agent_7.84.0~devel.git.213.ef95b89.pipeline.131115375-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.213.ef95b89.pipeline.131115375-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2d00390
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 759.674 MiB
agent_deb_amd64_fips 712.535 MiB
agent_heroku_amd64 312.013 MiB
agent_rpm_amd64 759.657 MiB
agent_rpm_amd64_fips 712.518 MiB
agent_rpm_arm64 735.422 MiB
agent_rpm_arm64_fips 691.605 MiB
agent_suse_amd64 759.657 MiB
agent_suse_amd64_fips 712.518 MiB
agent_suse_arm64 735.422 MiB
agent_suse_arm64_fips 691.605 MiB
docker_agent_amd64 818.289 MiB
docker_agent_arm64 819.098 MiB
docker_agent_jmx_amd64 1009.187 MiB
docker_agent_jmx_arm64 998.648 MiB
docker_cluster_agent_amd64 210.475 MiB
docker_cluster_agent_arm64 223.456 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.482 MiB
docker_dogstatsd_arm64 37.560 MiB
docker_host_profiler_amd64 305.814 MiB
docker_host_profiler_arm64 317.125 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.475 MiB
iot_agent_deb_arm64 43.127 MiB
iot_agent_deb_armhf 43.910 MiB
iot_agent_rpm_amd64 46.476 MiB
iot_agent_suse_amd64 46.475 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: c2edb2ba-9901-48e3-b383-25de8cf17b7d

Baseline: 2d00390
Comparison: ef95b89
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.45 [+1.58, +3.31] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +1.64 [+1.39, +1.89] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.49 [+0.37, +0.61] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.34 [+0.22, +0.46] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.29 [+0.14, +0.43] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.14 [+0.07, +0.21] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.07 [-0.03, +0.18] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.33 [-0.37, -0.29] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.62MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 740.65KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 521.45MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 203.86MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.25MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 361.70 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 404.86MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.30MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 27.61 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 327.40MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 60.84 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 302.91MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.08 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 311.83MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR medium review PR review might take time team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant