Skip to content

[AAD-6] Evict inactive observer series - #54948

Open
CelianR wants to merge 2 commits into
mainfrom
celian/series-eviction-aad-6
Open

[AAD-6] Evict inactive observer series#54948
CelianR wants to merge 2 commits into
mainfrom
celian/series-eviction-aad-6

Conversation

@CelianR

@CelianR CelianR commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Evicts inactive series after a configured TTL (5m by default).

There was only eviction after a max series threshold so the cardinality was always increasing, this checks periodically inactive series and remove them.

Config:

anomaly_detection:
  storage:
    inactive_series_check_interval: 5m
    inactive_series_ttl: 5m

Motivation

Describe how you validated your changes

Added debug print when we evict series, sent a custom series and verified that after the series is stale it is being evicted.

Additional Notes

@CelianR CelianR added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Aug 17, 2026
@CelianR CelianR self-assigned this Aug 17, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Aug 17, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Aug 17, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@CelianR
CelianR marked this pull request as ready for review August 17, 2026 09:05
@CelianR
CelianR requested review from a team as code owners August 17, 2026 09:05
@CelianR
CelianR requested a review from dustmop August 17, 2026 09:05
@datadog-prod-us1-3

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor fec92d8c:

Results for datadog-agent_7.84.0~devel.git.220.2a2c291.pipeline.131283868-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.220.2a2c291.pipeline.131283868-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fec92d8
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +12.0 KiB (0.00% increase, -0.27% of buffer) 760.215 → 760.227 → 764.500
agent_deb_amd64_fips +8.0 KiB (0.00% increase, -0.29% of buffer) 713.076 → 713.084 → 715.740
agent_heroku_amd64 +4.0 KiB (0.00% increase, -0.06% of buffer) 312.555 → 312.559 → 319.050
agent_msi +5.5 KiB (0.00% increase, -0.03% of buffer) 644.198 → 644.204 → 660.960
agent_rpm_amd64 +12.0 KiB (0.00% increase, -0.27% of buffer) 760.199 → 760.211 → 764.470
agent_rpm_amd64_fips +8.0 KiB (0.00% increase, -0.29% of buffer) 713.060 → 713.068 → 715.740
agent_rpm_arm64 +4.0 KiB (0.00% increase, -0.68% of buffer) 735.964 → 735.968 → 736.540
agent_suse_amd64 +12.0 KiB (0.00% increase, -0.27% of buffer) 760.199 → 760.211 → 764.470
agent_suse_amd64_fips +8.0 KiB (0.00% increase, -0.29% of buffer) 713.060 → 713.068 → 715.740
agent_suse_arm64 +4.0 KiB (0.00% increase, -0.68% of buffer) 735.964 → 735.968 → 736.540
docker_agent_amd64 +12.0 KiB (0.00% increase, -0.97% of buffer) 818.831 → 818.843 → 820.040
docker_agent_arm64 +3.99 KiB (0.00% increase, -0.35% of buffer) 819.640 → 819.644 → 820.740
docker_agent_jmx_amd64 +12.0 KiB (0.00% increase, -1.09% of buffer) 1009.729 → 1009.740 → 1010.800
docker_agent_jmx_arm64 +4.0 KiB (0.00% increase, -0.32% of buffer) 999.190 → 999.194 → 1000.420
docker_dogstatsd_arm64 +64.0 KiB (0.17% increase, -8.80% of buffer) 37.560 → 37.622 → 38.270
iot_agent_deb_armhf +4.0 KiB (0.01% increase, -0.36% of buffer) 43.910 → 43.914 → 44.990
17 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_rpm_arm64_fips 692.151 MiB
agent_suse_arm64_fips 692.151 MiB
docker_cluster_agent_amd64 210.475 MiB
docker_cluster_agent_arm64 223.456 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.482 MiB
docker_host_profiler_amd64 305.815 MiB
docker_host_profiler_arm64 317.124 MiB
dogstatsd_deb_amd64 30.224 MiB
dogstatsd_deb_arm64 28.247 MiB
dogstatsd_rpm_amd64 30.224 MiB
dogstatsd_suse_amd64 30.224 MiB
iot_agent_deb_amd64 46.475 MiB
iot_agent_deb_arm64 43.127 MiB
iot_agent_rpm_amd64 46.476 MiB
iot_agent_suse_amd64 46.475 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: f0f56275-f3f3-4e61-8cfb-2c9ec8614a5a

Baseline: fec92d8
Comparison: 2a2c291
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.86 [+0.62, +1.11] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.58 [+0.46, +0.70] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.43 [-0.44, +1.30] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.23 [+0.15, +0.30] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.03 [-0.01, +0.07] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.09 [-0.24, +0.06] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.21 [-0.32, -0.09] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.24 [-0.35, -0.14] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 172.75MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 742.18KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 510.44MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 202.98MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.84MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 362.02 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 398.21MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.14MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 25.87 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 327.74MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 58.60 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 306.96MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 21.33 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 314.47MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/fleet-automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant