chore: Use a protected env for upgrade workflow #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the dependency upgrade workflow
upgrade.yml
use an environmentprotected-main-env
.Motivation
Right now the secrets for the GitHub App (
GH_APP_ID
andGH_APP_PRIVATE_KEY
) are repo secrets, which can be made more secure by changing to environment secrets following this guide: https://datadoghq.atlassian.net/wiki/spaces/SECENG/pages/3034155880/Guide+How+to+Secure+Your+GitHub+Repositories#Secret-managementBefore this PR, I just created an environment
protected-main-env
that has the two secrets. After this PR is merged, I will remove the two repo secrets.Testing Guidelines
To test after merging this PR because the workflow can only run on main.
Additional Notes
Types of Changes
Check all that apply
Jira: https://datadoghq.atlassian.net/browse/SVLS-6927