fix: Changing Scope of Log Group Lookup in DataDogStepFunctions construct - #667
Open
mjdean94 wants to merge 1 commit into
Open
fix: Changing Scope of Log Group Lookup in DataDogStepFunctions construct#667mjdean94 wants to merge 1 commit into
mjdean94 wants to merge 1 commit into
Conversation
…unctions construct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #666
This updates the scope of the log group lookup in DatadogStepFunctions to be consistent with the scope of a newly-created log group in the same construct. Previously, newly-created log groups used the state machine as their scope while lookups used the DatadogStepFunctions construct itself.
Motivation
My team encountered a synth error when using this construct with multiple statemachines that had predefined log groups because of a name collision in LogGroup constructs.
Testing Guidelines
I verified that all existing unit tests passed.
Additional Notes
My assumption is that this was a miss in the original implementation of this construct, as I don't see any reason why the scopes would be different. While I can see the potential for this to be a breaking change, I also don't think anyone would've been able to use this construct with predefined log groups unless they only had exactly one statemachine in their stack.
Types of Changes
Check all that apply