pool string builders used in aggregator to concatenate tags#336
Open
jstncbllr wants to merge 2 commits into
Open
pool string builders used in aggregator to concatenate tags#336jstncbllr wants to merge 2 commits into
jstncbllr wants to merge 2 commits into
Conversation
…ncbllr/master # Conflicts: # statsd/aggregator.go # statsd/aggregator_test.go
Contributor
|
@review codex |
atanzu
requested changes
Jun 3, 2026
| var sb strings.Builder | ||
| sb := stringBuilderPool.Get().(*strings.Builder) | ||
| defer func() { | ||
| sb.Reset() |
Contributor
There was a problem hiding this comment.
I have a concern about correctness of this approach.
AFAIR sb.String() returns a string backed directly by the builder's internal buffer, so it does not copy. The defer here resets and returns the builder to the pool before the caller ever uses the returned strings, meaning the next goroutine to get the builder will overwrite the buffer that the returned string values still point into. This is silent heap corruption under concurrent use and might not be caught by the race detector.
Contributor
|
Hi @jstncbllr , Thank you for suggesting this improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduced allocations significantly for us.