[AGTMETRICS-233] Add support for OpenTelemetry Agent and Agent Data Plane to DAPs. (v1.15.0 backport) #1954
Conversation
…lane to DAPs. (v1.15.0 backport)
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
|
|
||
| "github.com/DataDog/datadog-operator/api/datadoghq/common" | ||
| apicommon "github.com/DataDog/datadog-operator/api/datadoghq/common" |
There was a problem hiding this comment.
⚪ Code Quality Violation
Verify that importing the same package multiple times is necessary. (...read more)
In Go, duplicate imports refer to importing the same package multiple times in a single file. It is considered a best practice to avoid duplicate imports in Go for the following reasons:
- Code readability and maintainability: Duplicate imports can make code harder to read and understand. When the same package is imported multiple times, it can lead to confusion and make it more difficult to determine the source of a particular symbol or function. Keeping imports concise and free of duplicates helps improve code readability and maintainability.
- Name conflicts: Duplicate imports introduce the risk of name conflicts. If the same package is imported multiple times, Go does not distinguish between them, which can result in name clashes between symbols from different imports. This can cause compilation errors or unexpected behavior, making the code prone to bugs and difficult to troubleshoot.
- Package initialization: Each package in Go can have an initialization function,
init(), which is executed during package initialization. When the same package is imported multiple times, theinit()function is run multiple times as well. This can lead to unexpected side effects and violate assumptions made by the package initialization code. - Compilation efficiency: Duplicate imports can impact compilation time and increase the size of the resulting binary. The Go compiler needs to process each imported package, and duplicating imports can cause unnecessary overhead during the build process.
To avoid these issues, it is recommended to keep imports concise and remove any duplicates. Go provides a handy feature where you can group multiple imports from the same package on a single line, reducing duplication. Additionally, using aliases when necessary can help resolve naming conflicts between symbols from different packages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tobz/v1.15.0-backport #1954 +/- ##
======================================================
Coverage 50.36% 50.37%
======================================================
Files 228 228
Lines 21774 21776 +2
======================================================
+ Hits 10967 10969 +2
Misses 10259 10259
Partials 548 548
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
3 participants
What does this PR do?
Backport of #1951.
Motivation
No intention of merging this PR, but wanted to submit it as a PR to have kind of a paper trail that we're building a custom image from it that will be used temporarily on a few clusters while we wait for v1.16.0.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel